Skip to content

wifi: Assorted fixes for RC1 issues #18476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 4, 2024
Merged

wifi: Assorted fixes for RC1 issues #18476

merged 5 commits into from
Nov 4, 2024

Conversation

@krish2718
Copy link
Contributor

@krish2718 krish2718 commented Nov 1, 2024

  • Revert revert of quarantine, left a couple of Matter over Wi-Fi tests in Quarantine.
  • Pull fixes for Wi-Fi RC1 testing issues

@github-actions github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Nov 1, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Nov 1, 2024 •
edited
Loading

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
zephyr nrfconnect/sdk-zephyr@25f14b4 nrfconnect/sdk-zephyr@86bff0f (main) nrfconnect/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@krish2718 krish2718 requested a review from richabp November 1, 2024 18:29
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Nov 1, 2024 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 6

Inputs:

Sources:

sdk-nrf: PR head: e880aed5f8c3ff09eb683b3ba795b5a32eb41f3e
zephyr: PR head: 86bff0f8539ae0fc7154bac0ccd889b4133cc298

more details

sdk-nrf:

PR head: e880aed5f8c3ff09eb683b3ba795b5a32eb41f3e
merge base: 9e61aa7cab4435aba07b1eae019f7fb4ae2adaf2
target head (main): 9e61aa7cab4435aba07b1eae019f7fb4ae2adaf2
Diff

zephyr:

PR head: 86bff0f8539ae0fc7154bac0ccd889b4133cc298
merge base: 25f14b4f8ecba7423f39ead3c117c0d86a096c5b
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (13) 
applications
│  ├── matter_bridge
│  │  │ sample.yaml
samples
│  ├── wifi
│  │  ├── radio_test
│  │  │  │ sample.yaml
scripts
│  │ quarantine.yaml
west.yml
zephyr
│  ├── boards
│  │  ├── nordic
│  │  │  ├── thingy53
│  │  │  │  │ thingy53_nrf5340_cpunet.dts
│  ├── drivers
│  │  ├── wifi
│  │  │  ├── nrfwifi
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  ├── inc
│  │  │  │  │  │ wpa_supp_if.h
│  │  │  │  ├── src
│  │  │  │  │  ├── fmac_main.c
│  │  │  │  │  ├── qspi
│  │  │  │  │  │  ├── src
│  │  │  │  │  │  │  │ qspi_if.c
│  │  │  │  │  │ wpa_supp_if.c
│  ├── modules
│  │  ├── hostap
│  │  │  ├── CMakeLists.txt
│  │  │  │ Kconfig
│  │ west.yml

Outputs:

Toolchain

Version: b44b7a08c9
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:b44b7a08c9_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 578
    • sdk-zephyr test count: 7229
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-chip
    • ✅ test-fw-nrfconnect-nrf-iot_cloud
    • ✅ test-fw-nrfconnect-rs
    • ✅ test-fw-nrfconnect-fem
    • ✅ test-sdk-find-my
    • ✅ test-fw-nrfconnect-nrf-iot_mosh
    • ✅ test-fw-nrfconnect-nrf-iot_positioning
    • ✅ test-sdk-wifi
    • ✅ test-low-level
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Nov 1, 2024

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@krish2718 krish2718 force-pushed the revert_quarantine_nrf70 branch from debe37e to 167dadc Compare November 2, 2024 12:12
@rlubos
Copy link
Contributor

rlubos commented Nov 4, 2024

In the previous quarantine revert there was also a thread_coex sample failure:
https://jenkins-ncs.nordicsemi.no/job/latest/job/sdk-nrf/job/main/4194/testReport/junit/thingy53_nrf5340_cpuapp_sample.nrf7002_eb.thingy53/thread_coex/Build___Test_with_Twister___Twister_NRF_1_10___sample_nrf7002_eb_thingy53_thread_coex/
Is this addressed here?

@krish2718
Copy link
Contributor Author

krish2718 commented Nov 4, 2024

In the previous quarantine revert there was also a thread_coex sample failure: https://jenkins-ncs.nordicsemi.no/job/latest/job/sdk-nrf/job/main/4194/testReport/junit/thingy53_nrf5340_cpuapp_sample.nrf7002_eb.thingy53/thread_coex/Build___Test_with_Twister___Twister_NRF_1_10___sample_nrf7002_eb_thingy53_thread_coex/ Is this addressed here?

Yes, it works now.

@krish2718 krish2718 force-pushed the revert_quarantine_nrf70 branch from 167dadc to 02e3aaa Compare November 4, 2024 09:41
@krish2718 krish2718 requested review from a team and rado17 as code owners November 4, 2024 09:41
@NordicBuilder NordicBuilder removed the DNM label Nov 4, 2024
@krish2718
manifest: sdk-zephyr: Pull Wi-Fi fixes
55175e7 
Assorted Wi-Fi fixes for RC1 issues.

Signed-off-by: Chaitanya Tata <[email protected]>
@krish2718
applications: matter_bridge: Fix shield for Wi-Fi
fd9f983 
nRF7002EB Wi-Fi support needs two shields to be passed. Please note
nRF70 Wi-Fi snippet is skipped as this applications overwrites the DTS.

Signed-off-by: Chaitanya Tata <[email protected]>
@krish2718
samples: wifi: radio_test: Fix the shields for 54 Series
d5822b9 
Using the same arg overwrites the previous shield, they should be passed
together and in proper order.

Signed-off-by: Chaitanya Tata <[email protected]>
@krish2718
Reapply "scripts: Revert quarantine for nRF70 samples"
8a78e28 
This reverts commit 7fa28ae.

Signed-off-by: Chaitanya Tata <[email protected]>
@krish2718
quarantine: Matter + 54H samples
e880aed 
54H + Wi-Fi is PSA only, but Matter is Legacy crypto and that is causing
build issues (MbedTLS configs).

For now Quarantine these samples till we figure out the issue.

Signed-off-by: Chaitanya Tata <[email protected]>
@krish2718 krish2718 force-pushed the revert_quarantine_nrf70 branch from 02e3aaa to e880aed Compare November 4, 2024 09:50
@rlubos
Copy link
Contributor

rlubos commented Nov 4, 2024

@krish2718 Please backport.

@rlubos rlubos merged commit 384ecab into nrfconnect:main Nov 4, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LuDuda LuDuda LuDuda approved these changes

@rlubos rlubos rlubos approved these changes

@bama-nordic bama-nordic bama-nordic approved these changes

@richabp richabp richabp approved these changes

@krga2022 krga2022 krga2022 approved these changes

@ArekBalysNordic ArekBalysNordic Awaiting requested review from ArekBalysNordic

@markaj-nordic markaj-nordic Awaiting requested review from markaj-nordic

@sachinthegreen sachinthegreen Awaiting requested review from sachinthegreen sachinthegreen is a code owner

@rado17 rado17 Awaiting requested review from rado17

Assignees

No one assigned

Labels

changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. manifest manifest-zephyr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@krish2718 @NordicBuilder @rlubos @LuDuda @bama-nordic @richabp @krga2022