Skip to content

wifi: hostap: Add a module to manage hostap crypto configuration #18803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 2, 2024
Merged

wifi: hostap: Add a module to manage hostap crypto configuration #18803

merged 3 commits into from
Dec 2, 2024

Conversation

@krish2718
Copy link
Contributor

@krish2718 krish2718 commented Nov 11, 2024

Instead of managing NCS crypto for hostap using nrf noup patches, this modules overrides the crypto config for NCS using external crypto support.

@krish2718 krish2718 requested review from a team as code owners November 11, 2024 19:41
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Nov 11, 2024 •
edited
Loading

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
zephyr nrfconnect/sdk-zephyr@b476270 nrfconnect/sdk-zephyr@53f5e6d (main) nrfconnect/[email protected]

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

krish2718
krish2718 commented Nov 11, 2024
View reviewed changes
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Nov 11, 2024 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 8

Inputs:

Sources:

sdk-nrf: PR head: f9fce8b86e430c45261b502891939e19bdc6c1c0
zephyr: PR head: 53f5e6dae760d95db2dcb5efac83b83023484043

more details

sdk-nrf:

PR head: f9fce8b86e430c45261b502891939e19bdc6c1c0
merge base: 013a72255d936b0e060d79d7a16f44d8d3f7fb3d
target head (main): ec4d5bf8d7c66382e55f0b472a12697a37f4142c
Diff

zephyr:

PR head: 53f5e6dae760d95db2dcb5efac83b83023484043
merge base: b4762701d5b8d1a2e6924a21cbbe64e8fdebb1eb
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (8) 
CODEOWNERS
subsys
│  ├── net
│  │  ├── lib
│  │  │  ├── CMakeLists.txt
│  │  │  ├── Kconfig
│  │  │  ├── hostap_crypto
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  │ Kconfig
west.yml
zephyr
│  ├── modules
│  │  ├── hostap
│  │  │  ├── CMakeLists.txt
│  │  │  │ Kconfig

Outputs:

Toolchain

Version: b77d8c1312
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:b77d8c1312_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 345
    • sdk-zephyr test count: 5449
  • ✅ Integration tests
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Nov 11, 2024

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@nordicjm
Copy link
Contributor

nordicjm commented Nov 12, 2024

Remember to add the skip manifest text if you are going to create your own manifest so #18802 doesn't get created

@krish2718 krish2718 mentioned this pull request Nov 12, 2024
Closed
sachinthegreen
sachinthegreen approved these changes Nov 12, 2024
View reviewed changes
@krish2718 krish2718 force-pushed the hostap_ext_crypto branch 2 times, most recently from be77c09 to 4d537a3 Compare November 14, 2024 18:35
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Nov 14, 2024

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

@github-actions github-actions bot removed the manifest label Nov 28, 2024
@krish2718 krish2718 added this to the 2.9.0 milestone Nov 30, 2024
@krish2718
net: lib: Add a new hostap crypto library
fb797b0 
This libray is primarily to maintain NCS build for hostap using nRF
security. It uses external crypto option in the upstream hostap to
overriwde crypto configuration.

Signed-off-by: Chaitanya Tata <[email protected]>
@krish2718
codeowners: Add missing entry for nRF70 external flash module
92b4c1f 
This was missed in the original commit.

Signed-off-by: Chaitanya Tata <[email protected]>
@krish2718
manifest: sdk-zephy: Pull external crypto support for hostap
f9fce8b 
Pulls in external crypto support for hostap.

Signed-off-by: Chaitanya Tata <[email protected]>
@NordicBuilder NordicBuilder removed the DNM label Dec 2, 2024
@rlubos rlubos merged commit c4e70ba into nrfconnect:main Dec 2, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jukkar jukkar jukkar approved these changes

@rlubos rlubos rlubos approved these changes

@nordicjm nordicjm nordicjm approved these changes

@rado17 rado17 rado17 approved these changes

@sachinthegreen sachinthegreen sachinthegreen approved these changes

+1 more reviewer

@VivekUppunda VivekUppunda VivekUppunda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

manifest manifest-zephyr

Projects

None yet

Milestone

2.9.0

Development

Successfully merging this pull request may close these issues.

8 participants

@krish2718 @NordicBuilder @nordicjm @jukkar @rlubos @rado17 @sachinthegreen @VivekUppunda