Skip to content

Adjust ncs-create-board to the agreed schema #20352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 17, 2025
Merged

Adjust ncs-create-board to the agreed schema #20352

merged 4 commits into from
Feb 17, 2025

Conversation

@gmarull
Copy link
Member

@gmarull gmarull commented Feb 13, 2025

So that communication between VSCode and extension is standardized.

Taken from #19056, without nRF54H specific bits.

@gmarull
scripts: west_commands: create_board: return schema+state
ad5afaf 
When requesting the schema, return the actual schema and its initial
state (empty).

Signed-off-by: Gerard Marull-Paretas <[email protected]>
@gmarull
scripts: west_commands: create_board: return list of post-actions
b01ceb6 
When passed a JSON response to generate a board, return a list of
actions or commands that should be performed afterwards.

Signed-off-by: Gerard Marull-Paretas <[email protected]>
@gmarull
scripts: west_commands: add JSON excepthook
f3971f0 
To be used with west commands implementing a jsonschema based protocol.

Signed-off-by: Gerard Marull-Paretas <[email protected]>
@gmarull
scripts: west_commands: install JSON hook to commands using jsonschema
bf436a5 
Commands using a jsonschema based protocol will now report errors
formatted in JSON.

Signed-off-by: Gerard Marull-Paretas <[email protected]>
@gmarull gmarull requested a review from kylebonnici February 13, 2025 13:57
@gmarull gmarull requested a review from a team as a code owner February 13, 2025 13:57
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Feb 13, 2025 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 1

Inputs:

Sources:

sdk-nrf: PR head: bf436a546ddd9748eb19eed527f4ac16da4fa2a6

more details

sdk-nrf:

PR head: bf436a546ddd9748eb19eed527f4ac16da4fa2a6
merge base: 8caef9de8300989f034575a3b7fe9a52c631a2b4
target head (main): 8caef9de8300989f034575a3b7fe9a52c631a2b4
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (3) 
CODEOWNERS
scripts
│  ├── west_commands
│  │  ├── create_board
│  │  │  │ ncs_create_board.py
│  │  ├── utils
│  │  │  │ __init__.py

Outputs:

Toolchain

Version: 342151af73
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:342151af73_bbe5b33786

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 32
  • ✅ Integration tests
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

kylebonnici
kylebonnici approved these changes Feb 14, 2025
View reviewed changes
Copy link

@kylebonnici kylebonnici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with vscode and works as expected

@gmarull gmarull requested a review from nordicjm February 14, 2025 14:28
@gmarull gmarull merged commit 6dc332e into nrfconnect:main Feb 17, 2025
17 checks passed
@gmarull gmarull deleted the bicrgen-no-54h branch February 17, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kylebonnici kylebonnici kylebonnici approved these changes

@nordicjm nordicjm nordicjm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gmarull @NordicBuilder @kylebonnici @nordicjm