Skip to content

Conversation

@rghaddab
Copy link
Contributor

@rghaddab rghaddab commented Feb 28, 2025

Introduces a new ZMS backend and changes some CONFIGs needed by some samples

test_crypto: PR-793

@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Feb 28, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Feb 28, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
find-my https://github.com/nrfconnect/sdk-find-my/commit/8cb1eb9f39f121bdfd5656a46ec29331e5e1ceae https://github.com/nrfconnect/sdk-find-my/commit/d5f277dad34d6a19c332ba244348603f95402573 (main) nrfconnect/[email protected]
matter nrfconnect/sdk-connectedhomeip@54ce2c1 nrfconnect/sdk-connectedhomeip@153abdf (master) nrfconnect/[email protected]
zephyr nrfconnect/sdk-zephyr@c9a539d nrfconnect/sdk-zephyr@749f6b5 (main) nrfconnect/[email protected]

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Feb 28, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 62

Inputs:

Sources:

sdk-nrf: PR head: 3c295054a133eea1dc006a4cea4350937a1a6f16
find-my: PR head: d5f277dad34d6a19c332ba244348603f95402573
matter: PR head: 153abdfa90076380fe7fd32e16c81af6eff06e0e
zephyr: PR head: 749f6b5252fc4c3359cfa7fa4a09d65f544d9b6f

more details

sdk-nrf:

PR head: 3c295054a133eea1dc006a4cea4350937a1a6f16
merge base: de3390bab1f27bb8e47a847e19a0d713829084a8
target head (main): de3390bab1f27bb8e47a847e19a0d713829084a8
Diff

find-my:

PR head: d5f277dad34d6a19c332ba244348603f95402573
merge base: 8cb1eb9f39f121bdfd5656a46ec29331e5e1ceae
Diff

matter:

PR head: 153abdfa90076380fe7fd32e16c81af6eff06e0e
merge base: 54ce2c1db67f53eb77ec10c11d39a3aeca336e88
Diff

zephyr:

PR head: 749f6b5252fc4c3359cfa7fa4a09d65f544d9b6f
merge base: c9a539dac2900d053e57d80c6f381f1b6e46dbd6
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (102)
CODEOWNERS
doc
│  ├── nrf
│  │  ├── app_dev
│  │  │  ├── device_guides
│  │  │  │  ├── nrf54l
│  │  │  │  │  │ zms.rst
│  │  ├── releases_and_maturity
│  │  │  ├── migration
│  │  │  │  │ migration_guide_3.0.rst
include
│  │ flash_map_pm.h
modules
│  ├── lib
│  │  ├── matter
│  │  │  ├── src
│  │  │  │  ├── platform
│  │  │  │  │  ├── Zephyr
│  │  │  │  │  │  ├── ConfigurationManagerImpl.cpp
│  │  │  │  │  │  │ KeyValueStoreManagerImpl.cpp
samples
│  ├── bluetooth
│  │  ├── mesh
│  │  │  ├── ble_peripheral_lbs_coex
│  │  │  │  ├── boards
│  │  │  │  │  ├── nrf54l15dk_nrf54l05_cpuapp.conf
│  │  │  │  │  ├── nrf54l15dk_nrf54l10_cpuapp.conf
│  │  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp.conf
│  │  │  ├── chat
│  │  │  │  ├── boards
│  │  │  │  │  ├── nrf54l15dk_nrf54l05_cpuapp.conf
│  │  │  │  │  ├── nrf54l15dk_nrf54l10_cpuapp.conf
│  │  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp.conf
│  │  │  ├── dfu
│  │  │  │  ├── distributor
│  │  │  │  │  ├── boards
│  │  │  │  │  │  ├── nrf54l15dk_nrf54l10_cpuapp.conf
│  │  │  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp.conf
│  │  │  │  ├── target
│  │  │  │  │  ├── boards
│  │  │  │  │  │  ├── nrf54l15dk_nrf54l10_cpuapp.conf
│  │  │  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp.conf
│  │  │  ├── light
│  │  │  │  ├── boards
│  │  │  │  │  ├── nrf54l15dk_nrf54l05_cpuapp.conf
│  │  │  │  │  ├── nrf54l15dk_nrf54l10_cpuapp.conf
│  │  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp.conf
│  │  │  ├── light_ctrl
│  │  │  │  ├── boards
│  │  │  │  │  ├── nrf54l15dk_nrf54l05_cpuapp.conf
│  │  │  │  │  ├── nrf54l15dk_nrf54l10_cpuapp.conf
│  │  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp.conf
│  │  │  ├── light_dimmer
│  │  │  │  ├── boards
│  │  │  │  │  ├── nrf54l15dk_nrf54l05_cpuapp.conf
│  │  │  │  │  ├── nrf54l15dk_nrf54l10_cpuapp.conf
│  │  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp.conf
│  │  │  ├── light_switch
│  │  │  │  ├── boards
│  │  │  │  │  ├── nrf54l15dk_nrf54l05_cpuapp.conf
│  │  │  │  │  ├── nrf54l15dk_nrf54l10_cpuapp.conf
│  │  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp.conf
│  │  │  ├── sensor_client
│  │  │  │  ├── boards
│  │  │  │  │  ├── nrf54l15dk_nrf54l05_cpuapp.conf
│  │  │  │  │  ├── nrf54l15dk_nrf54l10_cpuapp.conf
│  │  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp.conf
│  │  │  ├── sensor_server
│  │  │  │  ├── boards
│  │  │  │  │  ├── nrf54l15dk_nrf54l05_cpuapp.conf
│  │  │  │  │  ├── nrf54l15dk_nrf54l10_cpuapp.conf
│  │  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp.conf
│  │  │  ├── silvair_enocean
│  │  │  │  ├── boards
│  │  │  │  │  ├── nrf54l15dk_nrf54l05_cpuapp.conf
│  │  │  │  │  ├── nrf54l15dk_nrf54l10_cpuapp.conf
│  │  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp.conf
│  ├── common
│  │  ├── mcumgr_bt_ota_dfu
│  │  │  │ Kconfig
│  ├── matter
│  │  ├── common
│  │  │  ├── src
│  │  │  │  ├── persistent_storage
│  │  │  │  │  │ persistent_storage_shell.cpp
│  │  ├── light_bulb
│  │  │  ├── boards
│  │  │  │  ├── nrf54l15dk_nrf54l15_cpuapp.conf
│  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp_ns.conf
│  │  ├── light_switch
│  │  │  ├── boards
│  │  │  │  ├── nrf54l15dk_nrf54l15_cpuapp.conf
│  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp_ns.conf
│  │  ├── lock
│  │  │  ├── boards
│  │  │  │  ├── nrf54l15dk_nrf54l15_cpuapp.conf
│  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp_ns.conf
│  │  │  ├── src
│  │  │  │  ├── access
│  │  │  │  │  │ access_storage.cpp
│  │  ├── manufacturer_specific
│  │  │  ├── boards
│  │  │  │  ├── nrf54l15dk_nrf54l10_cpuapp.conf
│  │  │  │  ├── nrf54l15dk_nrf54l15_cpuapp.conf
│  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp_ns.conf
│  │  ├── smoke_co_alarm
│  │  │  ├── boards
│  │  │  │  ├── nrf54l15dk_nrf54l10_cpuapp.conf
│  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp.conf
│  │  ├── template
│  │  │  ├── boards
│  │  │  │  ├── nrf54l15dk_nrf54l10_cpuapp.conf
│  │  │  │  ├── nrf54l15dk_nrf54l15_cpuapp.conf
│  │  │  │  ├── nrf54l15dk_nrf54l15_cpuapp_internal.conf
│  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp_ns.conf
│  │  ├── thermostat
│  │  │  ├── boards
│  │  │  │  ├── nrf54l15dk_nrf54l15_cpuapp.conf
│  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp_ns.conf
│  │  ├── window_covering
│  │  │  ├── boards
│  │  │  │  ├── nrf54l15dk_nrf54l15_cpuapp.conf
│  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp_ns.conf
│  ├── openthread
│  │  ├── cli
│  │  │  ├── boards
│  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp.conf
│  │  ├── coprocessor
│  │  │  ├── boards
│  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp.conf
scripts
│  ├── ci
│  │  │ license_allow_list.yaml
subsys
│  ├── CMakeLists.txt
│  ├── Kconfig
│  ├── partition_manager
│  │  ├── CMakeLists.txt
│  │  │ Kconfig
│  ├── settings
│  │  ├── CMakeLists.txt
│  │  ├── Kconfig
│  │  ├── include
│  │  │  ├── settings
│  │  │  │  │ settings_zms_legacy.h
│  │  ├── src
│  │  │  ├── CMakeLists.txt
│  │  │  │ settings_zms_legacy.c
│  ├── trusted_storage
│  │  │ Kconfig
west.yml
zephyr
│  ├── doc
│  │  ├── services
│  │  │  ├── settings
│  │  │  │  │ index.rst
│  │  │  ├── storage
│  │  │  │  ├── zms
│  │  │  │  │  │ zms.rst
│  │  │ zephyr.doxyfile.in
│  ├── include
│  │  ├── zephyr
│  │  │  ├── fs
│  │  │  │  │ zms.h
│  │  │  ├── settings
│  │  │  │  │ settings.h
│  ├── samples
│  │  ├── subsys
│  │  │  ├── fs
│  │  │  │  ├── zms
│  │  │  │  │  ├── Kconfig
│  │  │  │  │  ├── README.rst
│  │  │  │  │  ├── prj.conf
│  │  │  │  │  ├── sample.yaml
│  │  │  │  │  ├── src
│  │  │  │  │  │  │ main.c
│  ├── subsys
│  │  ├── fs
│  │  │  ├── zms
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  ├── Kconfig
│  │  │  │  ├── zms.c
│  │  │  │  │ zms_priv.h
│  │  ├── settings
│  │  │  ├── Kconfig
│  │  │  ├── include
│  │  │  │  ├── settings
│  │  │  │  │  │ settings_zms.h
│  │  │  ├── src
│  │  │  │  ├── settings_store.c
│  │  │  │  │ settings_zms.c
│  ├── tests
│  │  ├── subsys
│  │  │  ├── fs
│  │  │  │  ├── zms
│  │  │  │  │  ├── Kconfig
│  │  │  │  │  ├── src
│  │  │  │  │  │  │ main.c
│  │  │  ├── settings
│  │  │  │  ├── functional
│  │  │  │  │  ├── src
│  │  │  │  │  │  │ settings_basic_test.c
│  │  │  │  │  ├── zms
│  │  │  │  │  │  ├── CMakeLists.txt
│  │  │  │  │  │  ├── prj.conf
│  │  │  │  │  │  ├── settings_test_zms.c
│  │  │  │  │  │  │ testcase.yaml
│  │  │  │  ├── performance
│  │  │  │  │  ├── CMakeLists.txt
│  │  │  │  │  ├── prj.conf
│  │  │  │  │  ├── settings_test_perf.c
│  │  │  │  │  │ testcase.yaml

File list hidden for private repositories.
If you have access you can see the diff via the github link.
find-my Diff

Outputs:

Toolchain

Version: 7cbc0036f4
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:7cbc0036f4_8bf7ca4353

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
  • ❌ Integration tests
    • ✅ test-sdk-audio
    • ❌ desktop52_verification
    • ✅ test-fw-nrfconnect-boot
    • ✅ test-fw-nrfconnect-apps
    • ✅ test_ble_nrf_config
    • ✅ test-fw-nrfconnect-ble_mesh
    • ✅ test-fw-nrfconnect-ble_samples
    • ❌ test-fw-nrfconnect-chip
    • ✅ test-fw-nrfconnect-nfc
    • ✅ test-fw-nrfconnect-nrf-iot_cloud
    • ✅ test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • ✅ test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • ✅ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • ✅ test-fw-nrfconnect-nrf-iot_samples
    • ✅ doc-internal
    • ❌ test-fw-nrfconnect-nrf-iot_thingy91
    • ✅ test-fw-nrfconnect-nrf_crypto
    • ❌ test-fw-nrfconnect-proprietary_esb
    • ✅ test-fw-nrfconnect-rpc
    • ✅ test-fw-nrfconnect-rs
    • ✅ test-fw-nrfconnect-fem
    • ✅ test-fw-nrfconnect-tfm
    • ❌ test-fw-nrfconnect-thread
    • ✅ test-sdk-find-my
    • ❌ test-fw-nrfconnect-nrf-iot_mosh
    • ❌ test-fw-nrfconnect-nrf-iot_positioning
    • ❌ test-sdk-wifi
    • ✅ test-low-level
    • ✅ test-sdk-pmic-samples
    • ✅ test-sdk-mcuboot
    • ✅ test-sdk-dfu
    • ❌ test-fw-nrfconnect-ps
    • ✅ test-secdom-samples-public
    • ⚠️ test-fw-nrfconnect-fw-update

Note: This message is automatically posted and updated by the CI

@github-actions
Copy link

github-actions bot commented Feb 28, 2025

@rghaddab rghaddab force-pushed the rghaddab/draft-backend-zms branch from 600d255 to 885c7dc Compare March 3, 2025 13:17
@rghaddab rghaddab force-pushed the rghaddab/draft-backend-zms branch 5 times, most recently from 529f6ce to fafc0ec Compare March 10, 2025 09:30
@github-actions github-actions bot removed the doc-required PR must not be merged without tech writer approval. label Mar 10, 2025
@rghaddab rghaddab force-pushed the rghaddab/draft-backend-zms branch 4 times, most recently from 696a26f to 7261ff7 Compare March 13, 2025 10:49
@rghaddab rghaddab force-pushed the rghaddab/draft-backend-zms branch from 7261ff7 to 9a7f58b Compare March 19, 2025 21:08
@sonarqubecloud
Copy link

@rghaddab rghaddab force-pushed the rghaddab/draft-backend-zms branch 4 times, most recently from 0280e9f to 48d122a Compare March 31, 2025 13:36
@rghaddab rghaddab marked this pull request as ready for review March 31, 2025 13:36
@rghaddab rghaddab requested review from a team as code owners March 31, 2025 13:36
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you cannot just copy an open source file from one repo into another repo and change the License.

The copyright and license of the original file should be kept.

Ref: https://github.com/nrfconnect/sdk-zephyr/blob/06c6605ca152de466718b0cb3f73ae7bba17e6ff/subsys/settings/include/settings/settings_zms.h#L2-L4

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tejlmand the Apache 2.0 got rejected by the compliance check.
What should I put there ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tejlmand the Apache 2.0 got rejected by the compliance check. What should I put there ?

It's not compliance but the license check which probably fails.
That said, then it really doesn't matter what license check says, you still can't change a license just to get something passing.

You should update: https://github.com/nrfconnect/sdk-nrf/blob/main/scripts/ci/license_allow_list.yaml#L38-L40

Comment on lines 2 to 4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you cannot just copy an open source file from one repo into another repo and change the License.

The copyright and license of the original file should be kept.

Ref: https://github.com/nrfconnect/sdk-zephyr/blob/06c6605ca152de466718b0cb3f73ae7bba17e6ff/subsys/settings/src/settings_zms.c#L2-L4

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, may be under libraries.

@rghaddab rghaddab force-pushed the rghaddab/draft-backend-zms branch from 23c1f41 to b6a21df Compare April 8, 2025 10:27
@rghaddab rghaddab mentioned this pull request Apr 8, 2025
3 tasks
@rghaddab rghaddab force-pushed the rghaddab/draft-backend-zms branch from b6a21df to 5070f10 Compare April 8, 2025 13:28
@rghaddab rghaddab requested review from nordicjm and tejlmand April 8, 2025 13:55
@nordic-piks
Copy link
Contributor

To have green CI (at least low-level) you need to rebase on #21408 and later on #21325

@rghaddab rghaddab force-pushed the rghaddab/draft-backend-zms branch 2 times, most recently from 44ec620 to 299beab Compare April 9, 2025 21:41
@kapi-no
Copy link
Contributor

kapi-no commented Apr 10, 2025

This change breaks our projects in the https://github.com/nrfconnect/sdk-find-my repository.

@rghaddab, can you align the repository before this PR is merged?

CC: @ns-tolu

@carlescufi carlescufi force-pushed the rghaddab/draft-backend-zms branch from 299beab to cff2a66 Compare April 10, 2025 08:45
@rghaddab rghaddab force-pushed the rghaddab/draft-backend-zms branch from cff2a66 to 4e5c047 Compare April 10, 2025 19:17
@rghaddab rghaddab force-pushed the rghaddab/draft-backend-zms branch 2 times, most recently from b0e6adb to 0a193ea Compare April 11, 2025 10:16
@kapi-no
Copy link
Contributor

kapi-no commented Apr 11, 2025

This change breaks our projects in the https://github.com/nrfconnect/sdk-find-my repository.

@rghaddab, can you align the repository before this PR is merged?

CC: @ns-tolu

This is addressed now in the sdk-find-my repository (see the sdk-find-my PR plugged into the west manifest)

Copy link
Contributor

@kapi-no kapi-no left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as the alignment for the Apple Find My is addressed

@rghaddab rghaddab force-pushed the rghaddab/draft-backend-zms branch 2 times, most recently from 0afdba2 to cd734d9 Compare April 11, 2025 18:04
NordicBuilder and others added 3 commits April 12, 2025 13:41
Update manifest for sdk-zephyr, connectedhomeip and sdk-find-my.
Some of the CONFIGs for ZMS and for its backend for Settings has been
added and others deleted.

Signed-off-by: Nordic Builder <[email protected]>
The legacy ZMS backend is needed by some applications that need to
maintain their backward compatibility.

Signed-off-by: Riadh Ghaddab <[email protected]>
Add notes on how to maintain backward compatibility with legacy backend
Details some Kconfig options added with the new backend.

Signed-off-by: Riadh Ghaddab <[email protected]>
@rghaddab rghaddab force-pushed the rghaddab/draft-backend-zms branch from cd734d9 to 3c29505 Compare April 12, 2025 11:41
@NordicBuilder NordicBuilder removed the DNM label Apr 12, 2025
@carlescufi carlescufi merged commit 0701042 into nrfconnect:main Apr 12, 2025
16 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.