-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New ZMS backend for Settings #20691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New ZMS backend for Settings #20691
Conversation
|
The following west manifest projects have changed revision in this Pull Request: ✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 3c295054a133eea1dc006a4cea4350937a1a6f16 more detailssdk-nrf:
find-my:
matter:
zephyr:
Github labels
List of changed files detected by CI (102)File list hidden for private repositories. Outputs:ToolchainVersion: 7cbc0036f4 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
|
You can find the documentation preview for this PR here. Preview links for modified nRF Connect SDK documents: https://ncsdoc.z6.web.core.windows.net/PR-20691/nrf/app_dev/device_guides/nrf54l/zms.html |
600d255 to
885c7dc
Compare
529f6ce to
fafc0ec
Compare
696a26f to
7261ff7
Compare
7261ff7 to
9a7f58b
Compare
|
0280e9f to
48d122a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you cannot just copy an open source file from one repo into another repo and change the License.
The copyright and license of the original file should be kept.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tejlmand the Apache 2.0 got rejected by the compliance check.
What should I put there ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tejlmand the Apache 2.0 got rejected by the compliance check. What should I put there ?
It's not compliance but the license check which probably fails.
That said, then it really doesn't matter what license check says, you still can't change a license just to get something passing.
You should update: https://github.com/nrfconnect/sdk-nrf/blob/main/scripts/ci/license_allow_list.yaml#L38-L40
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you cannot just copy an open source file from one repo into another repo and change the License.
The copyright and license of the original file should be kept.
doc/nrf/releases_and_maturity/migration/migration_guide_3.0.rst
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, may be under libraries.
23c1f41 to
b6a21df
Compare
b6a21df to
5070f10
Compare
44ec620 to
299beab
Compare
|
This change breaks our projects in the https://github.com/nrfconnect/sdk-find-my repository. @rghaddab, can you align the repository before this PR is merged? CC: @ns-tolu |
299beab to
cff2a66
Compare
cff2a66 to
4e5c047
Compare
b0e6adb to
0a193ea
Compare
This is addressed now in the sdk-find-my repository (see the sdk-find-my PR plugged into the west manifest) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as the alignment for the Apple Find My is addressed
0afdba2 to
cd734d9
Compare
Update manifest for sdk-zephyr, connectedhomeip and sdk-find-my. Some of the CONFIGs for ZMS and for its backend for Settings has been added and others deleted. Signed-off-by: Nordic Builder <[email protected]>
The legacy ZMS backend is needed by some applications that need to maintain their backward compatibility. Signed-off-by: Riadh Ghaddab <[email protected]>
Add notes on how to maintain backward compatibility with legacy backend Details some Kconfig options added with the new backend. Signed-off-by: Riadh Ghaddab <[email protected]>
cd734d9 to
3c29505
Compare



Introduces a new ZMS backend and changes some CONFIGs needed by some samples
test_crypto: PR-793