Skip to content

samples: bluetooth: Additional optimizations for Power Profiling #21332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2025
Merged

samples: bluetooth: Additional optimizations for Power Profiling #21332

merged 1 commit into from
Apr 3, 2025

Conversation

@doki-nordic
Copy link
Contributor

@doki-nordic doki-nordic commented Apr 2, 2025 •
edited
Loading

To reduce power consumption, the Bluetooth Peripheral power profiling
samples can be configured further. This commit adds such optimizations
and updates the documentation to inform the user how to reduce power
even more.

@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Apr 2, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Apr 2, 2025 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 5

Inputs:

Sources:

sdk-nrf: PR head: b24f5e44f54b6937edfc7aeda5b71a911de76668

more details

sdk-nrf:

PR head: b24f5e44f54b6937edfc7aeda5b71a911de76668
merge base: f495e974ca0e3bb3bb8a43e846221ed3f6c7608e
target head (main): f495e974ca0e3bb3bb8a43e846221ed3f6c7608e
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (3) 
samples
│  ├── bluetooth
│  │  ├── peripheral_power_profiling
│  │  │  ├── Kconfig
│  │  │  ├── README.rst
│  │  │  ├── src
│  │  │  │  │ main.c

Outputs:

Toolchain

Version: 7dbe0e2658
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:7dbe0e2658_8bf7ca4353

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 506
  • ✅ Integration tests
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@github-actions
Copy link

github-actions bot commented Apr 2, 2025 •
edited
Loading

You can find the documentation preview for this PR here.

Preview links for modified nRF Connect SDK documents:

https://ncsdoc.z6.web.core.windows.net/PR-21332/nrf/samples/bluetooth/peripheral_power_profiling/README.html

@github-actions github-actions bot added the doc-required PR must not be merged without tech writer approval. label Apr 2, 2025
@doki-nordic doki-nordic changed the title BLE Power Profiling - additional optimizations samples: bluetooth: Additional optimizations for Power Profiling Apr 2, 2025
@doki-nordic doki-nordic marked this pull request as ready for review April 2, 2025 23:31
@doki-nordic doki-nordic requested review from a team as code owners April 2, 2025 23:31
peknis
peknis requested changes Apr 3, 2025
View reviewed changes
@doki-nordic doki-nordic force-pushed the power-prof-optim branch 2 times, most recently from ef80963 to a717cbb Compare April 3, 2025 07:22
@doki-nordic
samples: bluetooth: Additional optimizations for Power Profiling
b24f5e4 
To reduce power consumption, the Bluetooth Peripheral power profiling
samples can be configured further. This commit adds such optimizations
and updates the documentation to inform the user how to reduce power
even more.

Signed-off-by: Dominik Kilian <[email protected]>
grochu
grochu approved these changes Apr 3, 2025
View reviewed changes
Copy link
Contributor

@grochu grochu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just please add a note in the release notes

@doki-nordic
Copy link
Contributor Author

doki-nordic commented Apr 3, 2025

just please add a note in the release notes

To avoid checks re-triggering, I will put into release notes PR for 3.0.

@umapraseeda
Copy link
Contributor

umapraseeda commented Apr 3, 2025

just please add a note in the release notes

To avoid checks re-triggering, I will put into release notes PR for 3.0.
Please add it here: #21339. Thanks!

@carlescufi carlescufi merged commit 1e2a467 into nrfconnect:main Apr 3, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grochu grochu grochu approved these changes

@nordicjm nordicjm nordicjm approved these changes

@peknis peknis peknis approved these changes

Assignees

No one assigned

Labels

changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. doc-required PR must not be merged without tech writer approval.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@doki-nordic @NordicBuilder @umapraseeda @grochu @nordicjm @peknis @carlescufi