drivers: mspi: Add shim driver for sQSPI #21430

anangl · 2025-04-04T15:05:14Z

Add a translation layer that allows using the sQSPI soft peripheral through the Zephyr MSPI API.
Also modify the manifest to pull in related changes required in sdk-zephyr.

NordicBuilder · 2025-04-04T15:06:33Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff
zephyr	nrfconnect/sdk-zephyr@`80ef797`	nrfconnect/sdk-zephyr@`4034b0f`	nrfconnect/[email protected]

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

NordicBuilder · 2025-04-04T15:07:58Z

CI Information

^{To view the history of this post, clich the 'edited' button above}
Build number: 9

Inputs:

Sources:

sdk-nrf: PR head: 8a8e238ccb81acba7bc9ec631e1d6b66818d4514
zephyr: PR head: 4034b0f2881a648453b4f6640952a220ff0b200b

more details

sdk-nrf:

PR head: 8a8e238ccb81acba7bc9ec631e1d6b66818d4514
merge base: 1b616da1221bdc9b271fff34833f5267da1ffce5
target head (main): 1b616da1221bdc9b271fff34833f5267da1ffce5
Diff

zephyr:

PR head: 4034b0f2881a648453b4f6640952a220ff0b200b
merge base: 80ef7970f0d1fdf506a3b1b644849a92a46f7c6f
Diff

Github labels

Enabled	Name	Description
	ci-disabled	Disable the ci execution
	ci-all-test	Run all of ci, no test spec filtering will be done
	ci-force-downstream	Force execution of downstream even if twister fails
	ci-run-twister	Force run twister
	ci-run-zephyr-twister	Force run zephyr twister

List of changed files detected by CI (26)

CODEOWNERS
drivers
│  ├── mspi
│  │  ├── CMakeLists.txt
│  │  ├── Kconfig
│  │  ├── Kconfig.sqspi
│  │  │ mspi_sqspi.c
dts
│  ├── bindings
│  │  ├── mspi
│  │  │  │ nordic,nrf-sqspi.yaml
samples
│  ├── zephyr
│  │  ├── drivers
│  │  │  ├── jesd216
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  ├── boards
│  │  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp_sqspi.overlay
│  │  │  │  ├── prj.conf
│  │  │  │  │ sample.yaml
│  │  │  ├── spi_flash
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  ├── boards
│  │  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp_sqspi.overlay
│  │  │  │  ├── prj.conf
│  │  │  │  │ sample.yaml
tests
│  ├── zephyr
│  │  ├── drivers
│  │  │  ├── flash
│  │  │  │  ├── common
│  │  │  │  │  ├── boards
│  │  │  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp_sqspi.overlay
│  │  │  │  │  ├── sysbuild.conf
│  │  │  │  │  │ testcase.yaml
west.yml
zephyr
│  ├── drivers
│  │  ├── misc
│  │  │  ├── nordic_vpr_launcher
│  │  │  │  ├── Kconfig
│  │  │  │  │ nordic_vpr_launcher.c
│  │  ├── pinctrl
│  │  │  │ pinctrl_nrf.c
│  ├── dts
│  │  ├── bindings
│  │  │  ├── riscv
│  │  │  │  │ nordic,nrf-vpr-coprocessor.yaml
│  ├── soc
│  │  ├── nordic
│  │  │  ├── common
│  │  │  │  │ nrf54hx_nrf92x_mpu_regions.c
│  ├── subsys
│  │  ├── bluetooth
│  │  │  ├── mesh
│  │  │  │  │ access.c
│  │  ├── net
│  │  │  ├── l2
│  │  │  │  ├── openthread
│  │  │  │  │  │ openthread.c
│  ├── tests
│  │  ├── bsim
│  │  │  ├── bluetooth
│  │  │  │  ├── mesh
│  │  │  │  │  ├── src
│  │  │  │  │  │  │ test_cdp1.c

Outputs:

Toolchain

Version: 7cbc0036f4
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:7cbc0036f4_8bf7ca4353

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

◻️ Toolchain - Skipped: existing toolchain is used
✅ Build twister
- sdk-nrf test count: 1574
- sdk-zephyr test count: 1611
❌ Integration tests
- ❌ test-sdk-audio
- ✅ test-fw-nrfconnect-ble_mesh
- ✅ test-fw-nrfconnect-chip
- ✅ test-fw-nrfconnect-nfc
- ✅ test-fw-nrfconnect-nrf-iot_cloud
- ✅ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
- ✅ test-fw-nrfconnect-nrf-iot_thingy91
- ✅ test-fw-nrfconnect-rs
- ✅ test-fw-nrfconnect-fem
- ✅ test-fw-nrfconnect-thread
- ✅ test-sdk-find-my
- ✅ test-fw-nrfconnect-nrf-iot_mosh
- ✅ test-fw-nrfconnect-nrf-iot_positioning
- ✅ test-low-level
- ✅ test-sdk-dfu

Disabled integration tests

- desktop52_verification
- doc-internal
- test_ble_nrf_config
- test-fw-nrfconnect-apps
- test-fw-nrfconnect-ble_samples
- test-fw-nrfconnect-boot
- test-fw-nrfconnect-nrf-iot_libmodem-nrf
- test-fw-nrfconnect-nrf-iot_samples
- test-fw-nrfconnect-nrf-iot_serial_lte_modem
- test-fw-nrfconnect-nrf_crypto
- test-fw-nrfconnect-proprietary_esb
- test-fw-nrfconnect-ps
- test-fw-nrfconnect-rpc
- test-fw-nrfconnect-tfm
- test-sdk-mcuboot
- test-sdk-pmic-samples
- test-sdk-wifi
- test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

github-actions · 2025-04-04T15:44:58Z

You can find the documentation preview for this PR here.

gmarull · 2025-04-04T19:11:57Z

drivers/mspi/CMakeLists.txt

this looks hackish, such code should be compiled/included based on a simple Kconfig selection

Well, this is what the sQSPI driver requires me to set. I don't quite see how I could simplify it further on my end (I only use one Kconfig option - MSPI_NRF_SQSPI).

Could sQSPI layer be structured properly?

anangl · 2025-04-07T11:34:32Z

On nRF54H20, the shim driver was so far only tested with a logic analyzer using a simple application that requested TX transfers in 1-1-4 mode (to mimic what is actually needed in communication with a display).

nordicjm

Build system changes OK, though do agree that it could look a bit more zephyr-ish

masz-nordic · 2025-04-07T14:24:34Z

tests/zephyr/drivers/flash/common/boards/nrf54l15dk_nrf54l15_cpuapp_sqspi.overlay

Alignment similar to this:
958fa23
will be needed when #21325 is merged.

anangl · 2025-04-08T09:51:45Z

Rebased.

nordic-piks · 2025-04-09T05:54:45Z

To have green CI (at least low-level) you need to rebase on #21408 and later on #21325

anangl · 2025-04-09T07:51:18Z

To have green CI (at least low-level) you need to rebase on #21408 and later on #21325

Yes, I'll wait for #21325.

Add a translation layer that allows using the sQSPI soft peripheral through the Zephyr MSPI API. Also modify the manifest to pull in related changes required in sdk-zephyr. Signed-off-by: Andrzej Głąbek <[email protected]>

Add test scenario that allows testing the MSPI shim driver for the sQSPI soft peripheral on the nRF54L15 DK. Alter the existing configuration so that the SDP MSPI is enabled only when needed. Signed-off-by: Andrzej Głąbek <[email protected]>

Add NCS specific configurations for two standard Zephyr samples: spi_flash and jesd216, so that they can be run on the nRF54L15 DK using the sQSPI soft peripheral. Signed-off-by: Andrzej Głąbek <[email protected]>

anangl · 2025-04-09T21:44:08Z

Rebased and updated with SHA.

anangl requested review from a team as code owners April 4, 2025 15:05

github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Apr 4, 2025

NordicBuilder added manifest-zephyr DNM labels Apr 4, 2025

anangl added this to the 3.0.0 milestone Apr 4, 2025

anangl mentioned this pull request Apr 4, 2025

manifest: sdk-zephyr: [nrf fromlist][nrf noup] Changes needed for MSPI shim driver for sQSPI #21429

Closed

anangl force-pushed the mspi_sqspi branch 2 times, most recently from cd9d2e7 to c53e0dd Compare April 4, 2025 15:25

gmarull reviewed Apr 4, 2025

View reviewed changes

nordic-piks approved these changes Apr 7, 2025

View reviewed changes

nordic-segl approved these changes Apr 7, 2025

View reviewed changes

anangl force-pushed the mspi_sqspi branch 2 times, most recently from db7becc to 73a9c9a Compare April 7, 2025 10:47

github-actions bot removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Apr 7, 2025

nordicjm approved these changes Apr 7, 2025

View reviewed changes

masz-nordic approved these changes Apr 7, 2025

View reviewed changes

anangl force-pushed the mspi_sqspi branch from 73a9c9a to b008d1b Compare April 8, 2025 09:51

anangl force-pushed the mspi_sqspi branch from b008d1b to dd161bc Compare April 8, 2025 09:56

anangl added 3 commits April 9, 2025 23:37

drivers: mspi: Add shim driver for sQSPI

b49df25

Add a translation layer that allows using the sQSPI soft peripheral through the Zephyr MSPI API. Also modify the manifest to pull in related changes required in sdk-zephyr. Signed-off-by: Andrzej Głąbek <[email protected]>

samples: zephyr: drivers: Add sQSPI scenario for spi_flash and jesd216

8a8e238

Add NCS specific configurations for two standard Zephyr samples: spi_flash and jesd216, so that they can be run on the nRF54L15 DK using the sQSPI soft peripheral. Signed-off-by: Andrzej Głąbek <[email protected]>

anangl force-pushed the mspi_sqspi branch from dd161bc to 2ca8c47 Compare April 9, 2025 21:43

NordicBuilder removed the DNM label Apr 9, 2025

anangl force-pushed the mspi_sqspi branch from 2ca8c47 to 8a8e238 Compare April 9, 2025 21:45

rlubos mentioned this pull request Apr 10, 2025

manifest: sdk-zephyr: [nrf fromlist] net: openthread: Add missing error checks #21461

Closed

carlescufi merged commit 133a89d into nrfconnect:main Apr 10, 2025
8 of 9 checks passed

anangl deleted the mspi_sqspi branch April 10, 2025 08:26

anangl added the backport v3.0-branch label Apr 10, 2025

anangl mentioned this pull request Apr 10, 2025

Backport #21430 #21620

Merged

anangl mentioned this pull request May 27, 2025

drivers: mspi_sqspi: A few corrections #22539

Merged

drivers: mspi: Add shim driver for sQSPI #21430

drivers: mspi: Add shim driver for sQSPI #21430

Uh oh!

Conversation

anangl commented Apr 4, 2025

Uh oh!

NordicBuilder commented Apr 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NordicBuilder commented Apr 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI Information

Inputs:

Sources:

Github labels

Outputs:

Toolchain

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

Uh oh!

github-actions bot commented Apr 4, 2025

Uh oh!

gmarull Apr 4, 2025

Choose a reason for hiding this comment

Uh oh!

anangl Apr 7, 2025

Choose a reason for hiding this comment

Uh oh!

gmarull Apr 7, 2025

Choose a reason for hiding this comment

Uh oh!

anangl commented Apr 7, 2025

Uh oh!

nordicjm left a comment

Choose a reason for hiding this comment

Uh oh!

masz-nordic Apr 7, 2025

Choose a reason for hiding this comment

Uh oh!

anangl commented Apr 8, 2025

Uh oh!

nordic-piks commented Apr 9, 2025

Uh oh!

anangl commented Apr 9, 2025

Uh oh!

anangl commented Apr 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

NordicBuilder commented Apr 4, 2025 •

edited

Loading

NordicBuilder commented Apr 4, 2025 •

edited

Loading