Skip to content

modules: tfm: Add nRF54L10 non secure target support. #22019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 15, 2025
Merged

modules: tfm: Add nRF54L10 non secure target support. #22019

merged 2 commits into from
May 15, 2025

Conversation

@Vge0rge
Copy link
Contributor

@Vge0rge Vge0rge commented Apr 23, 2025 •
edited
Loading

No description provided.

@github-actions github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Apr 23, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Apr 23, 2025 •
edited
Loading

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Apr 23, 2025 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 12

Inputs:

Sources:

sdk-nrf: PR head: 5a95c5117fcfa3bd5f0a64f4561c381fa770b373

more details

sdk-nrf:

PR head: 5a95c5117fcfa3bd5f0a64f4561c381fa770b373
merge base: 7f616711c38e8d273ed7adc38490a9d9566dade9
target head (main): fda6aa1d0bb8847fa801cc8fd5ad11bff877f2ee
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (31) 
doc
│  ├── nrf
│  │  ├── includes
│  │  │  │ sample_board_rows.txt
modules
│  ├── trusted-firmware-m
│  │  ├── Kconfig.tfm.defconfig
│  │  ├── Kconfig.tfm.pm
│  │  ├── tfm_boards
│  │  │  ├── CMakeLists.txt
│  │  │  ├── board
│  │  │  │  │ device_cfg.h
│  │  │  ├── common
│  │  │  │  │ assert.c
│  │  │  ├── external_core.cmake
│  │  │  ├── nrf54l10_cpuapp
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  ├── config.cmake
│  │  │  │  ├── cpuarch.cmake
│  │  │  │  ├── ns
│  │  │  │  │  │ cpuarch_ns.cmake
samples
│  ├── crypto
│  │  ├── aes_cbc
│  │  │  │ sample.yaml
│  │  ├── aes_ccm
│  │  │  │ sample.yaml
│  │  ├── aes_ctr
│  │  │  │ sample.yaml
│  │  ├── aes_gcm
│  │  │  │ sample.yaml
│  │  ├── chachapoly
│  │  │  │ sample.yaml
│  │  ├── ecdh
│  │  │  │ sample.yaml
│  │  ├── ecdsa
│  │  │  │ sample.yaml
│  │  ├── ecjpake
│  │  │  │ sample.yaml
│  │  ├── eddsa
│  │  │  │ sample.yaml
│  │  ├── hkdf
│  │  │  │ sample.yaml
│  │  ├── hmac
│  │  │  │ sample.yaml
│  │  ├── pbkdf2
│  │  │  │ sample.yaml
│  │  ├── persistent_key_usage
│  │  │  │ sample.yaml
│  │  ├── psa_tls
│  │  │  ├── boards
│  │  │  │  ├── nrf54l15dk_nrf54l10_cpuapp_ns.conf
│  │  │  │  │ nrf54l15dk_nrf54l10_cpuapp_ns.overlay
│  │  │  │ sample.yaml
│  │  ├── rng
│  │  │  │ sample.yaml
│  │  ├── rsa
│  │  │  │ sample.yaml
│  │  ├── sha256
│  │  │  │ sample.yaml
│  │  ├── spake2p
│  │  │  │ sample.yaml

Outputs:

Toolchain

Version: 1d2c5d0ab5
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:1d2c5d0ab5_8bf7ca4353

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 11
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-boot
    • ✅ test-fw-nrfconnect-nrf_crypto
    • ✅ test-fw-nrfconnect-tfm
    • ✅ test-sdk-find-my
    • ✅ test-sdk-mcuboot
    • ⚠️ test-fw-nrfconnect-fw-update
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-thread-main
    • test-low-level
    • test-sdk-audio
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@Vge0rge Vge0rge closed this May 5, 2025
@Vge0rge Vge0rge reopened this May 5, 2025
@Vge0rge Vge0rge marked this pull request as ready for review May 5, 2025 09:00
@Vge0rge Vge0rge requested review from a team as code owners May 5, 2025 09:00
@Vge0rge Vge0rge force-pushed the l10_ns_support branch 4 times, most recently from 5c804fa to 17f43b6 Compare May 8, 2025 14:09
@Vge0rge Vge0rge requested a review from a team as a code owner May 8, 2025 14:09
@github-actions github-actions bot added the doc-required PR must not be merged without tech writer approval. label May 8, 2025
@github-actions
Copy link

github-actions bot commented May 8, 2025

You can find the documentation preview for this PR here.

degjorva
degjorva approved these changes May 8, 2025
View reviewed changes
Copy link
Contributor

@degjorva degjorva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Nit: inherits not iherits in commit message.

umapraseeda
umapraseeda reviewed May 9, 2025
View reviewed changes
@Vge0rge Vge0rge force-pushed the l10_ns_support branch 2 times, most recently from 385d2e4 to 4541e37 Compare May 13, 2025 13:36
nordicjm
nordicjm approved these changes May 14, 2025
View reviewed changes
modules/trusted-firmware-m/Kconfig.tfm.defconfig Outdated
Copy link
Contributor

@nordicjm nordicjm May 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit typo *secure

Copy link
Contributor Author

@Vge0rge Vge0rge May 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will update, thanks!

umapraseeda
umapraseeda reviewed May 14, 2025
View reviewed changes
doc/nrf/includes/sample_board_rows.txt Outdated
Copy link
Contributor

@umapraseeda umapraseeda May 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To eliminate the build error, please add the following also:

.. nrf54l15dk_nrf54l10_cpuapp_ns

| :ref:`nRF54L15 DK (emulating nRF54L10) <ug_nrf54l>` | PCA10156 | :ref:`nrf54l15dk zephyr:nrf54l15dk_nrf54l15` | ``nrf54l15dk/nrf54l10/cpuapp/ns`` |

Copy link
Contributor Author

@Vge0rge Vge0rge May 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, will do

Copy link
Contributor Author

@Vge0rge Vge0rge May 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did that actually but the reference didn't work so I replaced it with ":zephyr:board:nrf54l15dk" which is used by all the other variants as well.

@Vge0rge
modules: tf-m: Add support for nRF54L10 non secure target
54728b0 
Add support for the non secure target: nrf54l15dk/nrf54l10/cpuapp/ns
in NCS. This defines the target and iherits nearly all configuration
and code from nRF54L15. An exception to that was the default
RAM region for TF-M which was reduced to 64KB.

Ref: NCSDK-30404

Signed-off-by: Georgios Vasilakis <[email protected]>
@github-actions github-actions bot removed the manifest label May 14, 2025
@Vge0rge
samples: crypto: Add the nRF54L10 non secure target
5a95c51 
Add the non secure target for the nRF54L10 to all the
supported crypto samples.

For the psa_tls sample the reserved RRAM and SRAM regions
for the RISCV core are deleted since the sample require
~115K SRAM and it cannot fit otherwise. The RISCV core
is not used by the sample so this should not affect anything.

Ref: NCSDK-30404

Signed-off-by: Georgios Vasilakis <[email protected]>
@rlubos rlubos merged commit 7c1ac42 into nrfconnect:main May 15, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@degjorva degjorva degjorva approved these changes

@nordicjm nordicjm nordicjm approved these changes

@umapraseeda umapraseeda umapraseeda approved these changes

Assignees

No one assigned

Labels

changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. doc-required PR must not be merged without tech writer approval.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Vge0rge @NordicBuilder @degjorva @nordicjm @umapraseeda @rlubos