mpsl: nrf2220 temperature compensation #22143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
doc-required
umapraseeda
approved these changes
May 5, 2025
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 46ef7329fc7bcf319ae3244181b12b47017c70c6 more detailssdk-nrf:
Github labels
List of changed files detected by CI (8)Outputs:ToolchainVersion: 1d2c5d0ab5 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
ankuns
force-pushed
the
nrf2220_temperature_compensation
branch
from
89dd65d to
d549926
Compare
peknis
requested changes
May 5, 2025
grochu
approved these changes
May 5, 2025
|
You can find the documentation preview for this PR here. Preview links for modified nRF Connect SDK documents: https://ncsdoc.z6.web.core.windows.net/PR-22143/nrf/app_dev/device_guides/fem/fem_nrf2220.html |
ankuns
force-pushed
the
nrf2220_temperature_compensation
branch
from
d549926 to
33a016d
Compare
e-rk
approved these changes
May 5, 2025
peknis
approved these changes
May 5, 2025
ankuns
force-pushed
the
nrf2220_temperature_compensation
branch
from
33a016d to
c6cfd4e
Compare
piotrkoziar
approved these changes
May 6, 2025
nordicjm
approved these changes
May 6, 2025
There was a problem hiding this comment.
alignment of these are all off
For the nRF2220 the temperature compensation feature is added. It allows to achieve better output power accuracy among the whole supported temperature range. The feature is enabled by the MPSL_FEM_NRF2220_TEMPERATURE_COMPENSATION Kconfig option. It relies on functions provided by MPSL in the sdk-nrfxlib. The temperature source can be taken from the SoC or can be set by custom implementation. Signed-off-by: Andrzej Kuros <[email protected]>
The nRF2220 temperature compensation is recently added. The protocols relying on the fem_al do not use the MPSL scheduler. In this case the function `mpsl_fem_nrf2220_temperature_changed_update_now` must be called by a protocol driver which for this case is the fem_al. Signed-off-by: Andrzej Kuros <[email protected]>
The changelog entry is added. Signed-off-by: Andrzej Kuros <[email protected]>
ankuns
force-pushed
the
nrf2220_temperature_compensation
branch
from
c6cfd4e to
46ef732
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings in a temperature compensation feature for the nrf2220 Front-End Module allowing better accuracy of output power setting.
The API exposed by the MPSL https://github.com/nrfconnect/sdk-nrfxlib/blob/main/mpsl/fem/nrf2220/include/protocol/mpsl_fem_nrf2220_protocol_api.h
is used.
The nRF2220 temperature compensation feature is enabled by the new Kconfig option
MPSL_FEM_NRF2220_TEMPERATURE_COMPENSATION.The temperature is provided by either taking the SoC temperature (default) Kconfig option
MPSL_FEM_NRF2220_TEMPERATURE_SOURCE_SOCor is provided by userMPSL_FEM_NRF2220_TEMPERATURE_SOURCE_CUSTOM.The feature requires a i2c_nrfx_twim driver extension covered by PR nrfconnect/sdk-zephyr#2585 (already in sdk-zephyr). This extension provides just the ability to take exclusive access to the TWIM bus. Extending the i2c_nrfx_twim driver in upstream was considered inappropriate. It was agreed that whil having exclusive access to the i2c bus, the feature will use the nrfx_twim driver directly.
Note: This is a new PR for #20960 that has been partially reviewed (closed by bot NordicBuilder), I can't reopen that PR.