From e02bc615b7cb4d2cf12187d38f676b2e98cc86cb Mon Sep 17 00:00:00 2001 From: Michal Leksinski Date: Thu, 8 May 2025 00:25:22 +0200 Subject: [PATCH] applications: zigbee_weather_station: fix negative values logging A fix for logging negative temperature values and logging unification. Signed-off-by: Michal Leksinski --- applications/zigbee_weather_station/src/sensor.c | 9 +++------ .../releases/release-notes-changelog.rst | 8 ++++++++ 2 files changed, 11 insertions(+), 6 deletions(-) diff --git a/applications/zigbee_weather_station/src/sensor.c b/applications/zigbee_weather_station/src/sensor.c index bf50ff161b06..b64c855902f7 100644 --- a/applications/zigbee_weather_station/src/sensor.c +++ b/applications/zigbee_weather_station/src/sensor.c @@ -91,9 +91,8 @@ int sensor_get_temperature(float *temperature) if (err) { LOG_ERR("Failed to get sensor channel: %d", err); } else { - LOG_INF("Sensor T:%3d.%06d [*C]", - sensor_temperature.val1, sensor_temperature.val2); *temperature = convert_sensor_value(sensor_temperature); + LOG_INF("Sensor T:%9.3f [*C]", (double)(*temperature)); } } else { LOG_ERR("Sensor not initialized"); @@ -121,9 +120,8 @@ int sensor_get_pressure(float *pressure) if (err) { LOG_ERR("Failed to get sensor channel: %d", err); } else { - LOG_INF("Sensor P:%3d.%06d [kPa]", - sensor_pressure.val1, sensor_pressure.val2); *pressure = convert_sensor_value(sensor_pressure); + LOG_INF("Sensor P:%9.3f [kPa]", (double)(*pressure)); } } else { LOG_ERR("Sensor not initialized"); @@ -151,9 +149,8 @@ int sensor_get_humidity(float *humidity) if (err) { LOG_ERR("Failed to get sensor channel: %d", err); } else { - LOG_INF("Sensor H:%3d.%06d [%%]", - sensor_humidity.val1, sensor_humidity.val2); *humidity = convert_sensor_value(sensor_humidity); + LOG_INF("Sensor H:%9.3f [%%]", (double)(*humidity)); } } else { LOG_ERR("Sensor not initialized"); diff --git a/doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst b/doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst index 52ce5b5b55b9..5dabaf4015fc 100644 --- a/doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst +++ b/doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst @@ -220,6 +220,14 @@ Thingy:53: Matter weather station |no_changes_yet_note| +Thingy:53: Zigbee weather station +--------------------------------- + +* Added: + + * A fix for logging negative temperature values. + * Logging unification. + Samples =======