Skip to content

samples: nrf_rpc: entropy_nrf53: Use NCS network core Kconfigs #23145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2025
Merged

samples: nrf_rpc: entropy_nrf53: Use NCS network core Kconfigs #23145

merged 1 commit into from
Jul 31, 2025

Conversation

@nordicjm
Copy link
Contributor

@nordicjm nordicjm commented Jul 7, 2025 

Uses the NCS sysbuild Kconfigs for configuring the remote image
for this sample rather than manually adding a sample which altered
the flash order

@nordicjm nordicjm requested review from a team as code owners July 7, 2025 07:02
@github-actions github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Jul 7, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jul 7, 2025 •
edited
Loading

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jul 7, 2025 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 3

Inputs:

Sources:

sdk-nrf: PR head: 352d3eabb3edd3f9c708e75cc3d9931b93fb7d39

more details

sdk-nrf:

PR head: 352d3eabb3edd3f9c708e75cc3d9931b93fb7d39
merge base: 4b7d70fd3fa0c13d7fa767f885953287ce1ef732
target head (main): ae4ec2568b7ca95f0df3ee66d38f132b086122a9
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (2) 
samples
│  ├── nrf_rpc
│  │  ├── entropy_nrf53
│  │  │  ├── Kconfig.sysbuild
│  │  │  │ sysbuild.cmake

Outputs:

Toolchain

Version: bd39d1676f
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:bd39d1676f_bba2ea5f2e

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 4
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-rpc
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps-main
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread-main
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@github-actions
Copy link

github-actions bot commented Jul 7, 2025

You can find the documentation preview for this PR here.

@nordicjm nordicjm requested review from a team July 17, 2025 13:45
@github-actions github-actions bot removed the manifest label Jul 18, 2025
@nordicjm
Copy link
Contributor Author

nordicjm commented Jul 24, 2025

@nrfconnect/ncs-si-muffin @nrfconnect/ncs-protocols-serialization please review

Damian-Nordic
Damian-Nordic reviewed Jul 24, 2025
View reviewed changes
samples/nrf_rpc/entropy_nrf53/Kconfig.sysbuild Outdated
Copy link
Contributor

@Damian-Nordic Damian-Nordic Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Help text copy-pasted?

Copy link
Contributor Author

@nordicjm nordicjm Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@nordicjm
samples: nrf_rpc: entropy_nrf53: Use NCS network core Kconfigs
352d3ea 
Uses the NCS sysbuild Kconfigs for configuring the remote image
for this sample rather than manually adding a sample which altered
the flash order

Signed-off-by: Jamie McCrae <[email protected]>
@nordicjm nordicjm requested a review from Damian-Nordic July 24, 2025 11:03
grochu
grochu approved these changes Jul 30, 2025
View reviewed changes
Copy link
Contributor

@grochu grochu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not really very familiar with the sysbuild configurations, and how their layout should be. It's probably fine if it works, though looks like a lot of options for quite a simple case.

@nordicjm nordicjm merged commit 30c6c4a into nrfconnect:main Jul 31, 2025
12 checks passed
@nordicjm nordicjm deleted the fixentropysample branch September 23, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grochu grochu grochu approved these changes

@tejlmand tejlmand tejlmand approved these changes

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

Assignees

No one assigned

Labels

changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nordicjm @NordicBuilder @grochu @tejlmand @Damian-Nordic