Skip to content

applications: nrf_desktop: usb_state: fix SoF Kconfig dependencies #23332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2025
Merged

applications: nrf_desktop: usb_state: fix SoF Kconfig dependencies #23332

merged 1 commit into from
Jul 17, 2025

Conversation

@kapi-no
Copy link
Contributor

@kapi-no kapi-no commented Jul 16, 2025

Added the missing dependency on the UDC_ENABLE_SOF Kconfig option to the SoF synchronization Kconfig option. This Kconfig is part of the USB state module in the nRF Desktop application.

This fix aligns the nRF Desktop with the changes introduced by the following PR:

#23193

@kapi-no
applications: nrf_desktop: usb_state: fix SoF Kconfig dependencies
59fbb10 
Added the missing dependency on the UDC_ENABLE_SOF Kconfig option
to the SoF synchronization Kconfig option. This Kconfig is part
of the USB state module in the nRF Desktop application.

This fix aligns the nRF Desktop with the changes introduced by
the following PR:

nrfconnect#23193

Signed-off-by: Kamil Piszczek <[email protected]>
@kapi-no kapi-no requested a review from a team as a code owner July 16, 2025 13:46
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jul 16, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jul 16, 2025 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 1

Inputs:

Sources:

sdk-nrf: PR head: 59fbb10ef3fff6c0c456e80b553f37589cbb0e26

more details

sdk-nrf:

PR head: 59fbb10ef3fff6c0c456e80b553f37589cbb0e26
merge base: 087d1e6a098a677a83d1f5afac8ab0053d474d03
target head (main): 764fc6e1074e7dbf738c6232cf3ad3cb90f1b8d3
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (1) 
applications
│  ├── nrf_desktop
│  │  ├── src
│  │  │  ├── modules
│  │  │  │  │ Kconfig.usb_state

Outputs:

Toolchain

Version: 684b32e022
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:684b32e022_bba2ea5f2e

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 47
  • ✅ Integration tests
    • ✅ desktop52_verification
Disabled integration tests
    • test-fw-nrfconnect-nrf_lrcs_mosh
    • test-fw-nrfconnect-nrf_lrcs_positioning
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps-main
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread-main
    • test-low-level
    • test-sdk-audio
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jul 16, 2025

Memory footprint analysis revealed the following potential issues

applications.nrf_desktop.zdebug.uart[nrf54lm20dk/nrf54lm20a/cpuapp]: ROM size increased by 572[B] in comparison to the main[087d1e6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug.uart[[email protected]/nrf54lm20a/cpuapp]: ROM size increased by 572[B] in comparison to the main[087d1e6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug.uart[[email protected]/nrf54lm20a/cpuapp]: ROM size increased by 572[B] in comparison to the main[087d1e6] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)

Note: This message is automatically posted and updated by the CI (latest/sdk-nrf/PR-23332/1)

@github-actions
Copy link

github-actions bot commented Jul 16, 2025

You can find the documentation preview for this PR here.

@kapi-no kapi-no merged commit 5664daa into nrfconnect:main Jul 17, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zycz zycz zycz approved these changes

@nordicjm nordicjm nordicjm approved these changes

@alstrzebonski alstrzebonski alstrzebonski approved these changes

Assignees

No one assigned

Labels

changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kapi-no @NordicBuilder @zycz @nordicjm @alstrzebonski