mpsl: Add support for HFCLK24M to MPSL clock driver #23498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
manifest
changelog-entry-required
|
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: dad02ba96f1e18bd401460a78a4511d0369d29ee more detailssdk-nrf:
nrfxlib:
Github labels
List of changed files detected by CI (272)Outputs:ToolchainVersion: Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
ppryga-nordic
force-pushed
the
mpsl-clock-driver-add-hfclk24m
branch
from
ccbddea to
a467401
Compare
ppryga-nordic
changed the title
|
@ppryga-nordic typo in PR title? "mspl:" |
miha-nordic
approved these changes
Jul 31, 2025
ppryga-nordic
changed the title
|
This PR requires updated nrfxlib, with MPSL that supports HFCLK24M. The work on that is in progress. |
ppryga-nordic
force-pushed
the
mpsl-clock-driver-add-hfclk24m
branch
from
a467401 to
c3f5139
Compare
|
You can find the documentation preview for this PR here. |
Memory footprint analysis revealed the following potential issuesapplications.nrf_desktop.zdebug.uart.kmu_provision[nrf54l15dk/nrf54l10/cpuapp]: ROM size increased by 596[B] in comparison to the main[b5613c8] branch. - link (cc: @nrfconnect/ncs-si-bluebagel) Note: This message is automatically posted and updated by the CI (latest/sdk-nrf/PR-23498/8) |
cvinayak
approved these changes
Aug 1, 2025
Comment on lines
32
to
34
There was a problem hiding this comment.
Should there be a LOG_WRN here for debugging purposes, if required?
There was a problem hiding this comment.
Good idea. LOG_WRN added.
ppryga-nordic
force-pushed
the
mpsl-clock-driver-add-hfclk24m
branch
from
c3f5139 to
d782118
Compare
|
CI failed on some framework issue. Re-run with skipping of all passing stages. |
cvinayak
approved these changes
Aug 1, 2025
nordicjm
approved these changes
Aug 1, 2025
hermabe
approved these changes
Aug 1, 2025
anangl
reviewed
Aug 1, 2025
There was a problem hiding this comment.
This will be included through <nrfx_clock.h>. But anyway, do you actually need this inclusion?
There was a problem hiding this comment.
I added it because something was failing at some point. Personally I prefer to include required headers explicitly. If you insist I can remove it.
There was a problem hiding this comment.
I've removed it to speed up the PR.
There was a problem hiding this comment.
I added it because something was failing at some point. Personally I prefer to include required headers explicitly. If you insist I can remove it.
The thing is that this header doesn't seem to be required here.
There was a problem hiding this comment.
Suggested change
| #define LOG_LEVEL CONFIG_FLASH_LOG_LEVEL | |
| #include <zephyr/logging/log.h> | |
| LOG_MODULE_REGISTER(nrfx_clock_mpsl); | |
| #include <zephyr/logging/log.h> | |
| LOG_MODULE_REGISTER(nrfx_clock_mpsl, CONFIG_CLOCK_CONTROL_LOG_LEVEL); |
Comment on lines
25
to
27
There was a problem hiding this comment.
Intentional fall-through? A related comment would be helpful.
There was a problem hiding this comment.
Nope, thanks for catching this!
ppryga-nordic
force-pushed
the
mpsl-clock-driver-add-hfclk24m
branch
from
d782118 to
b5fa13d
Compare
There is a new HFCLK source HFCLK24M that might be used when MPSL internal clok driver is enabled. That clock is used for example by USB. The MPSL didn't support any other HFCLK except HFXO. The commit adds changes in MPSL clock driver that are based on new clock API provided by the MPSL library. Signed-off-by: Piotr Pryga <[email protected]>
ppryga-nordic
force-pushed
the
mpsl-clock-driver-add-hfclk24m
branch
from
b5fa13d to
fca1c98
Compare
|
Corrected use of |
anangl
approved these changes
Aug 1, 2025
Automatically created by Github Action Signed-off-by: Nordic Builder <[email protected]> (cherry picked from commit 8eb9eb0cceb6db27bb106a0a5f8d2be8801897d2) Signed-off-by: Piotr Pryga <[email protected]>
ppryga-nordic
force-pushed
the
mpsl-clock-driver-add-hfclk24m
branch
from
fca1c98 to
dad02ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a new HFCLK source HFCLK24M that might be used when
MPSL internal clok driver is enabled. That clock is used for
example by USB. The MPSL didn't support any other HFCLK except
HFXO.
The commit adds changes in MPSL clock driver that are based
on new clock API provided by the MPSL library.
Signed-off-by: Piotr Pryga [email protected]