Skip to content

Conversation

@nordic-segl
Copy link
Contributor

@nordic-segl nordic-segl commented Oct 17, 2025

Enable comparator test on nrf54lv10dk/nrf54lv10a/cpuapp/ns.
Enable clock_control tests on nrf54lv10dk/nrf54lv10a/cpuapp/ns.
Enable kernel/timer_behavior on nrf54lv10dk/nrf54lv10a/cpuapp/ns.

@nordic-segl nordic-segl requested a review from a team as a code owner October 17, 2025 10:02
@NordicBuilder NordicBuilder added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 17, 2025
@NordicBuilder NordicBuilder requested a review from a team October 17, 2025 10:02
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 17, 2025

CI Information

To view the history of this post, click the 'edited' button above
Build number: 9

Inputs:

Sources:

sdk-nrf: PR head: 05624a78e031b482c5a58ad6579ce30cef750831

more details

sdk-nrf:

PR head: 05624a78e031b482c5a58ad6579ce30cef750831
merge base: e29167dc81fb0d63e371f04346e0f9f56504a234
target head (main): 2b1d723d240405d2a31e03b0b89abe1309d073b8
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (10)
tests
│  ├── zephyr
│  │  ├── drivers
│  │  │  ├── comparator
│  │  │  │  ├── gpio_loopback
│  │  │  │  │  ├── boards
│  │  │  │  │  │  ├── nrf54lv10dk_nrf54lv10a_common.dtsi
│  │  │  │  │  │  ├── nrf54lv10dk_nrf54lv10a_cpuapp.overlay
│  │  │  │  │  │  │ nrf54lv10dk_nrf54lv10a_cpuapp_ns.overlay
│  │  │  │  │  ├── snippets
│  │  │  │  │  │  ├── nrf_comp
│  │  │  │  │  │  │  │ snippet.yml
│  │  │  │  │  │  ├── nrf_lpcomp
│  │  │  │  │  │  │  │ snippet.yml
│  │  │  │  │  ├── socs
│  │  │  │  │  │  ├── nrf54lv10a_cpuapp_nrf_comp.overlay
│  │  │  │  │  │  ├── nrf54lv10a_cpuapp_nrf_lpcomp.overlay
│  │  │  │  │  │  ├── nrf54lv10a_cpuapp_ns_nrf_comp.overlay
│  │  │  │  │  │  │ nrf54lv10a_cpuapp_ns_nrf_lpcomp.overlay
│  │  │  │  │  │ testcase.yaml

Outputs:

Toolchain

Version: 46667c6630
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:46667c6630_bba2ea5f2e

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 2
  • ✅ Integration tests
    • ✅ test-low-level
Disabled integration tests
    • desktop52_verification
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps-main
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread-main
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@nordic-segl
Copy link
Contributor Author

Works in CI:

12:07:55  INFO    - 1/4 [email protected]/nrf54lv10a/cpuapp nrf.extended.drivers.comparator.gpio_loopback.nrf_lpcomp PASSED (device: 1051613579, 4.045s <zephyr>)
12:07:55  INFO    - 2/4 [email protected]/nrf54lv10a/cpuapp nrf.extended.drivers.comparator.gpio_loopback.nrf_comp PASSED (device: 1051623308, 3.941s <zephyr>)
12:07:56  INFO    - 3/4 [email protected]/nrf54lv10a/cpuapp/ns nrf.extended.drivers.comparator.gpio_loopback.nrf_comp PASSED (device: 1051641694, 7.152s <zephyr>)
12:07:59  INFO    - 4/4 [email protected]/nrf54lv10a/cpuapp/ns nrf.extended.drivers.comparator.gpio_loopback.nrf_lpcomp PASSED (device: 1051613579, 7.552s <zephyr>)

@NordicBuilder NordicBuilder requested a review from a team October 17, 2025 13:51
@nordic-segl
Copy link
Contributor Author

nrf.extended.drivers.clock.nrf_lf_clock_start_xtal_no_wait has to be quarantined

@nordic-segl nordic-segl force-pushed the NRFX-8517_Test-comparator-on-lv10-ns branch from ead1be7 to fbacbd3 Compare October 20, 2025 06:41
@NordicBuilder NordicBuilder requested a review from a team October 20, 2025 06:41
@nordic-segl nordic-segl force-pushed the NRFX-8517_Test-comparator-on-lv10-ns branch from fbacbd3 to f821576 Compare October 20, 2025 09:15
@nordic-segl nordic-segl changed the title tests: zephyr: drivers: comparator: gpio_loopback: Enable on LV10 NS tests: zephyr: drivers: Enable driver tests on LV10 NS part 1 Oct 20, 2025
nrf54lv10dk/nrf54lv10a/cpuapp:
append:
EXTRA_DTC_OVERLAY_FILE: boards/nrf54lv10dk_nrf54lv10a_cpuapp.overlay
nrf54lv10dk/nrf54lv10a/cpuapp/ns:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

abuse of snippets, remove this and use board overlays

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Directory tests/zephyr/* contains tests copied from upstream Zephyr.
We use them to verify "unofficial" platforms like nrf54lv10, nrf54ls05, nrf7120, etc.
We do that by adding overlays and extending platform_allow list.
Idea is to apply identical changes to samples/tests when the target is upstreamed.

I can change this to use overlays, but when LV10 is pushed to the upstream Zephyr, it will be discarded because this test in the upstream uses code snippets:
https://github.com/zephyrproject-rtos/zephyr/tree/main/tests/drivers/comparator/gpio_loopback/snippets/nrf_comp/boards

Therefore, unless upstream test is modified, this request demands work that will ultimately be discarded.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to tight schedule, I propose to merge this as is.
I created task NRFX-8570 to rework the comparator with gpio loopback test.

Copy link
Contributor

@tejlmand tejlmand Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is another variant of #24430 (comment)

Why is it better to keep wrong behavior now, and then have two follow-up PRs, one ins sdk-nrf and later upstream Zephyr, instead of doing it correct here, and then do only one followup PR upstream afterwards ?

Copy link
Contributor

@nordic-piks nordic-piks Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not have time for such cleaning now. It was not planned. We are just before new product launch thus we focus on testing not refactoring.
Beside any work which is not coordinated with upstream cause more problem that is solves - we have then problems doing fromlist/fromtree when downstream is not aligned, as commit check fails.
I do not see point doing any refactor here and now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nordic-segl nordic-segl requested a review from nordicjm October 20, 2025 12:29
@nordic-segl nordic-segl force-pushed the NRFX-8517_Test-comparator-on-lv10-ns branch from f821576 to 7b4fbd7 Compare October 21, 2025 11:10
@NordicBuilder NordicBuilder requested review from a team October 21, 2025 11:10
@nordic-segl nordic-segl force-pushed the NRFX-8517_Test-comparator-on-lv10-ns branch from 7b4fbd7 to bc1ebad Compare October 21, 2025 11:44
@nordic-segl nordic-segl force-pushed the NRFX-8517_Test-comparator-on-lv10-ns branch from bc1ebad to 2402596 Compare October 21, 2025 12:22
@NordicBuilder NordicBuilder requested review from a team October 21, 2025 12:23
@nordic-segl nordic-segl removed the DNM label Oct 21, 2025
@nordic-segl
Copy link
Contributor Author

Works in CI:

14:43:55  INFO    - 1/4 [email protected]/nrf54lv10a/cpuapp nrf.extended.drivers.comparator.gpio_loopback.nrf_comp PASSED (device: 1051681250, 3.534s <zephyr>)
14:43:55  INFO    - 2/4 [email protected]/nrf54lv10a/cpuapp nrf.extended.drivers.comparator.gpio_loopback.nrf_lpcomp PASSED (device: 1051660370, 3.626s <zephyr>)
14:43:58  INFO    - 3/4 [email protected]/nrf54lv10a/cpuapp/ns nrf.extended.drivers.comparator.gpio_loopback.nrf_comp PASSED (device: 1051674470, 6.016s <zephyr>)
14:44:02  INFO    - 4/4 [email protected]/nrf54lv10a/cpuapp/ns nrf.extended.drivers.comparator.gpio_loopback.nrf_lpcomp PASSED (device: 1051681250, 5.995s <zephyr>)

Enable comparator test on nrf54lv10dk/nrf54lv10a/cpuapp/ns.

Signed-off-by: Sebastian Głąb <[email protected]>
@nordic-segl nordic-segl force-pushed the NRFX-8517_Test-comparator-on-lv10-ns branch from 2402596 to 05624a7 Compare October 22, 2025 06:48
@nordic-piks nordic-piks added this to the 3.2.0-preview3 milestone Oct 22, 2025
@nordic-piks nordic-piks merged commit 82a26f2 into nrfconnect:main Oct 22, 2025
18 checks passed
@nordic-segl nordic-segl deleted the NRFX-8517_Test-comparator-on-lv10-ns branch October 22, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants