Skip to content

Add nRF7120 support to I2S test cases #25300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add nRF7120 support to I2S test cases #25300

wants to merge 1 commit into from

Conversation

@erdemsimsek
Copy link

This commit adds support for the nRF7120 PDK platform to the I2S driver tests by adding device tree overlays and platform configurations for the i2s_api, i2s_additonal and i2s_speed test suites.

Add nRF7120 support to I2S test cases
0fb092f 
This commit adds support for the nRF7120 PDK platform to the I2S driver tests
by adding device tree overlays and platform configurations for the i2s_api, i2s_additonal and
i2s_speed test suites.

Signed-off-by: Erdem Simsek <[email protected]>
@erdemsimsek erdemsimsek requested review from a team as code owners October 29, 2025 11:44
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Erdem Simsek seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@NordicBuilder NordicBuilder added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 29, 2025
nordic-segl
nordic-segl reviewed Oct 29, 2025
View reviewed changes
tests/zephyr/drivers/i2s/i2s_additional/testcase.yaml
fixture: gpio_loopback
depends_on:
- future_target
nrf.extended.drivers.i2s.additional.gpio_loopback.nrf71:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: You can use nrf.extended.drivers.i2s.additional.gpio_loopback for nrf7120.
All targets (that can run this test) were moved to upstream -> test was disabled with depends_on: future_target that is never meet.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 29, 2025 •
edited
Loading

CI Information

To view the history of this post, click the 'edited' button above
Build number: 1

Inputs:

Sources:

sdk-nrf: PR head: 0fb092f9a4cd663e2447598d387ef49da4bb1944

more details

sdk-nrf:

PR head: 0fb092f9a4cd663e2447598d387ef49da4bb1944
merge base: 59cb41da4e3d03619fead0ee0a3a2f05a5990ebd
target head (main): ca33bb19c8b35b0b7cd57291161db528052295e1
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (7) 
dts
│  ├── common
│  │  ├── nordic
│  │  │  │ nrf7120_enga.dtsi
tests
│  ├── zephyr
│  │  ├── drivers
│  │  │  ├── i2s
│  │  │  │  ├── i2s_additional
│  │  │  │  │  ├── boards
│  │  │  │  │  │  │ nrf7120pdk_nrf7120_cpuapp.overlay
│  │  │  │  │  │ testcase.yaml
│  │  │  │  ├── i2s_api
│  │  │  │  │  ├── boards
│  │  │  │  │  │  │ nrf7120pdk_nrf7120_cpuapp.overlay
│  │  │  │  │  │ testcase.yaml
│  │  │  │  ├── i2s_speed
│  │  │  │  │  ├── boards
│  │  │  │  │  │  │ nrf7120pdk_nrf7120_cpuapp.overlay
│  │  │  │  │  │ testcase.yaml

Outputs:

Toolchain

Version: cfa6b06338
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:cfa6b06338_e595b21c39

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ❌ Build twister
    • sdk-nrf test count: 30
  • ❌ Integration tests
    • ❌ test-low-level
Disabled integration tests
    • test-fw-nrfconnect-nrf_lrcs_positioning
    • desktop52_verification
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps-main
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread-main
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

nordic-segl
nordic-segl reviewed Oct 29, 2025
View reviewed changes
tests/zephyr/drivers/i2s/i2s_additional/boards/nrf7120pdk_nrf7120_cpuapp.overlay
status = "okay";
pinctrl-0 = <&tdm_default_alt>;
pinctrl-names = "default";
sck-clock-source = "ACLK";
Copy link
Contributor

@nordic-segl nordic-segl Oct 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that in every overlay You switch clock source to audio PLL. Is this intentional?
https://github.com/nrfconnect/sdk-zephyr/blob/main/dts/bindings/i2s/nordic%2Cnrf-tdm.yaml#L49

There is audio PLL in 54H20 (Product Specification says that nrf7120 has ACLK instead):
https://github.com/nrfconnect/sdk-zephyr/blob/main/dts/vendor/nordic/nrf54h20.dtsi#L213

For example, here nrf54LM20 uses default PCLK:
https://github.com/nrfconnect/sdk-zephyr/blob/main/tests/drivers/i2s/i2s_speed/boards/nrf54lm20dk_nrf54lm20a_cpuapp.overlay#L26

@erdemsimsek
Copy link
Author

Waiting nrfconnect/sdk-zephyr#3440 to be merged to run CI testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nordic-segl nordic-segl nordic-segl approved these changes

@nordic-piks nordic-piks nordic-piks approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@erdemsimsek @CLAassistant @NordicBuilder @nordic-segl @nordic-piks