Skip to content

Commit 06ae8a9

Browse files
LingaoMcvinayak
authored andcommitted
Bluetooth: Host: Use actual user_data size
Use actual user_data size not default by 8. Signed-off-by: Lingao Meng <[email protected]> (cherry picked from commit 0ddb6aa) Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
1 parent 1ddb58d commit 06ae8a9

File tree

7 files changed

+20
-14
lines changed

7 files changed

+20
-14
lines changed

subsys/bluetooth/controller/hci/hci.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4953,7 +4953,8 @@ static void vs_read_tx_power_level(struct net_buf *buf, struct net_buf **evt)
49534953

49544954
#if defined(CONFIG_BT_HCI_VS_FATAL_ERROR)
49554955
/* A memory pool for vandor specific events for fatal error reporting purposes. */
4956-
NET_BUF_POOL_FIXED_DEFINE(vs_err_tx_pool, 1, BT_BUF_EVT_RX_SIZE, 8, NULL);
4956+
NET_BUF_POOL_FIXED_DEFINE(vs_err_tx_pool, 1, BT_BUF_EVT_RX_SIZE,
4957+
sizeof(struct bt_buf_data), NULL);
49574958

49584959
/* The alias for convenience of Controller HCI implementation. Controller is build for
49594960
* a particular architecture hence the alias will allow to avoid conditional compilation.

subsys/bluetooth/host/buf.c

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,24 +33,25 @@
3333
* Having a dedicated pool for it ensures that exhaustion of the RX pool
3434
* cannot block the delivery of this priority event.
3535
*/
36-
NET_BUF_POOL_FIXED_DEFINE(num_complete_pool, 1, NUM_COMLETE_EVENT_SIZE, 8, NULL);
36+
NET_BUF_POOL_FIXED_DEFINE(num_complete_pool, 1, NUM_COMLETE_EVENT_SIZE,
37+
sizeof(struct bt_buf_data), NULL);
3738
#endif /* CONFIG_BT_CONN || CONFIG_BT_ISO */
3839

3940
NET_BUF_POOL_FIXED_DEFINE(discardable_pool, CONFIG_BT_BUF_EVT_DISCARDABLE_COUNT,
40-
BT_BUF_EVT_SIZE(CONFIG_BT_BUF_EVT_DISCARDABLE_SIZE), 8,
41-
NULL);
41+
BT_BUF_EVT_SIZE(CONFIG_BT_BUF_EVT_DISCARDABLE_SIZE),
42+
sizeof(struct bt_buf_data), NULL);
4243

4344
#if defined(CONFIG_BT_HCI_ACL_FLOW_CONTROL)
4445
NET_BUF_POOL_DEFINE(acl_in_pool, CONFIG_BT_BUF_ACL_RX_COUNT,
4546
BT_BUF_ACL_SIZE(CONFIG_BT_BUF_ACL_RX_SIZE),
4647
sizeof(struct acl_data), bt_hci_host_num_completed_packets);
4748

4849
NET_BUF_POOL_FIXED_DEFINE(evt_pool, CONFIG_BT_BUF_EVT_RX_COUNT,
49-
BT_BUF_EVT_RX_SIZE, 8,
50+
BT_BUF_EVT_RX_SIZE, sizeof(struct bt_buf_data),
5051
NULL);
5152
#else
5253
NET_BUF_POOL_FIXED_DEFINE(hci_rx_pool, BT_BUF_RX_COUNT,
53-
BT_BUF_RX_SIZE, 8,
54+
BT_BUF_RX_SIZE, sizeof(struct bt_buf_data),
5455
NULL);
5556
#endif /* CONFIG_BT_HCI_ACL_FLOW_CONTROL */
5657

subsys/bluetooth/host/hci_core.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ void bt_hci_cmd_state_set_init(struct net_buf *buf,
130130
*/
131131
#define CMD_BUF_SIZE MAX(BT_BUF_EVT_RX_SIZE, BT_BUF_CMD_TX_SIZE)
132132
NET_BUF_POOL_FIXED_DEFINE(hci_cmd_pool, CONFIG_BT_BUF_CMD_TX_COUNT,
133-
CMD_BUF_SIZE, 8, NULL);
133+
CMD_BUF_SIZE, sizeof(struct bt_buf_data), NULL);
134134

135135
struct event_handler {
136136
uint8_t event;

subsys/bluetooth/host/hci_raw.c

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,14 +41,17 @@ static uint8_t raw_mode;
4141
#endif
4242

4343
NET_BUF_POOL_FIXED_DEFINE(hci_rx_pool, BT_BUF_RX_COUNT,
44-
BT_BUF_RX_SIZE, 8, NULL);
44+
BT_BUF_RX_SIZE, sizeof(struct bt_buf_data), NULL);
4545
NET_BUF_POOL_FIXED_DEFINE(hci_cmd_pool, CONFIG_BT_BUF_CMD_TX_COUNT,
46-
BT_BUF_CMD_SIZE(CONFIG_BT_BUF_CMD_TX_SIZE), 8, NULL);
46+
BT_BUF_CMD_SIZE(CONFIG_BT_BUF_CMD_TX_SIZE),
47+
sizeof(struct bt_buf_data), NULL);
4748
NET_BUF_POOL_FIXED_DEFINE(hci_acl_pool, CONFIG_BT_BUF_ACL_TX_COUNT,
48-
BT_BUF_ACL_SIZE(CONFIG_BT_BUF_ACL_TX_SIZE), 8, NULL);
49+
BT_BUF_ACL_SIZE(CONFIG_BT_BUF_ACL_TX_SIZE),
50+
sizeof(struct bt_buf_data), NULL);
4951
#if defined(CONFIG_BT_ISO)
5052
NET_BUF_POOL_FIXED_DEFINE(hci_iso_pool, CONFIG_BT_ISO_TX_BUF_COUNT,
51-
BT_ISO_SDU_BUF_SIZE(CONFIG_BT_ISO_TX_MTU), 8, NULL);
53+
BT_ISO_SDU_BUF_SIZE(CONFIG_BT_ISO_TX_MTU),
54+
sizeof(struct bt_buf_data), NULL);
5255
#endif /* CONFIG_BT_ISO */
5356

5457
struct bt_dev_raw bt_dev;

subsys/bluetooth/host/hfp_hf.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ LOG_MODULE_REGISTER(bt_hfp_hf);
3535
struct bt_hfp_hf_cb *bt_hf;
3636

3737
NET_BUF_POOL_FIXED_DEFINE(hf_pool, CONFIG_BT_MAX_CONN + 1,
38-
BT_RFCOMM_BUF_SIZE(BT_HF_CLIENT_MAX_PDU), 8, NULL);
38+
BT_RFCOMM_BUF_SIZE(BT_HF_CLIENT_MAX_PDU), 0, NULL);
3939

4040
static struct bt_hfp_hf bt_hfp_hf_pool[CONFIG_BT_MAX_CONN];
4141

subsys/bluetooth/host/iso.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,8 @@ LOG_MODULE_REGISTER(bt_iso);
3636

3737
#if defined(CONFIG_BT_ISO_UNICAST) || defined(CONFIG_BT_ISO_SYNC_RECEIVER)
3838
NET_BUF_POOL_FIXED_DEFINE(iso_rx_pool, CONFIG_BT_ISO_RX_BUF_COUNT,
39-
BT_ISO_SDU_BUF_SIZE(CONFIG_BT_ISO_RX_MTU), 8, NULL);
39+
BT_ISO_SDU_BUF_SIZE(CONFIG_BT_ISO_RX_MTU),
40+
sizeof(struct iso_data), NULL);
4041

4142
static struct bt_iso_recv_info iso_info_data[CONFIG_BT_ISO_RX_BUF_COUNT];
4243
#define iso_info(buf) (&iso_info_data[net_buf_id(buf)])

subsys/bluetooth/shell/rfcomm.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333

3434
#define DATA_MTU 48
3535

36-
NET_BUF_POOL_FIXED_DEFINE(pool, 1, DATA_MTU, 8, NULL);
36+
NET_BUF_POOL_FIXED_DEFINE(pool, 1, DATA_MTU, 0, NULL);
3737

3838
static struct bt_sdp_attribute spp_attrs[] = {
3939
BT_SDP_NEW_SERVICE,

0 commit comments

Comments
 (0)