Skip to content

Commit 23680b8

Browse files
drivers: i2c: i2c_nrfx: minor fixes
Minor alignment and fix failing tests. Signed-off-by: Adam Kondraciuk <[email protected]>
1 parent a0491b6 commit 23680b8

File tree

4 files changed

+15
-23
lines changed

4 files changed

+15
-23
lines changed

drivers/i2c/i2c_nrfx_twim.c

Lines changed: 11 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -262,10 +262,10 @@ static DEVICE_API(i2c, i2c_nrfx_twim_driver_api) = {
262262
BUILD_ASSERT(I2C_FREQUENCY(DT_DRV_INST(idx)) != I2C_NRFX_TWIM_INVALID_FREQUENCY, \
263263
"Wrong I2C " #idx " frequency setting in dts"); \
264264
static struct i2c_nrfx_twim_data twim_##idx##_data; \
265-
static struct i2c_nrfx_twim_common_config twim_##idx##z_config; \
265+
static struct i2c_nrfx_twim_common_config twim_##idx##z_config; \
266266
static void pre_init##idx(void) \
267267
{ \
268-
twim_##idx##z_config.twim = &twim_##idx##_data.twim; \
268+
twim_##idx##z_config.twim = &twim_##idx##_data.twim; \
269269
twim_##idx##_data.twim.p_twim = (NRF_TWIM_Type *)DT_INST_REG_ADDR(idx); \
270270
IRQ_CONNECT(DT_INST_IRQN(idx), DT_INST_IRQ(idx, priority), nrfx_twim_irq_handler, \
271271
&twim_##idx##_data.twim, 0); \
@@ -286,24 +286,17 @@ static DEVICE_API(i2c, i2c_nrfx_twim_driver_api) = {
286286
.pre_init = pre_init##idx, \
287287
.pcfg = PINCTRL_DT_INST_DEV_CONFIG_GET(idx), \
288288
IF_ENABLED(USES_MSG_BUF(idx), \
289-
(.msg_buf = twim_##idx##_msg_buf,)) \
290-
.max_transfer_size = BIT_MASK( \
291-
DT_INST_PROP(idx, easydma_maxcnt_bits)), \
292-
}; \
293-
PM_DEVICE_DT_INST_DEFINE(idx, twim_nrfx_pm_action, \
294-
I2C_PM_ISR_SAFE(idx)); \
295-
I2C_DEVICE_DT_INST_DEINIT_DEFINE(idx, \
296-
i2c_nrfx_twim_init, \
297-
i2c_nrfx_twim_deinit, \
298-
PM_DEVICE_DT_INST_GET(idx), \
299-
&twim_##idx##_data, \
300-
&twim_##idx##z_config, \
301-
POST_KERNEL, \
302-
CONFIG_I2C_INIT_PRIORITY, \
303-
&i2c_nrfx_twim_driver_api)
289+
(.msg_buf = twim_##idx##_msg_buf,)) .max_transfer_size = \
290+
BIT_MASK(DT_INST_PROP(idx, easydma_maxcnt_bits)), \
291+
}; \
292+
PM_DEVICE_DT_INST_DEFINE(idx, twim_nrfx_pm_action, I2C_PM_ISR_SAFE(idx)); \
293+
I2C_DEVICE_DT_INST_DEINIT_DEFINE(idx, i2c_nrfx_twim_init, i2c_nrfx_twim_deinit, \
294+
PM_DEVICE_DT_INST_GET(idx), &twim_##idx##_data, \
295+
&twim_##idx##z_config, POST_KERNEL, \
296+
CONFIG_I2C_INIT_PRIORITY, &i2c_nrfx_twim_driver_api)
304297

305298
#define I2C_MEMORY_SECTION(idx) \
306-
COND_CODE_1(DT_NODE_HAS_PROP(DT_DRV_INST(idx), prop), \
299+
COND_CODE_1(DT_NODE_HAS_PROP(DT_DRV_INST(idx), memory_regions), \
307300
(__attribute__((__section__(LINKER_DT_NODE_REGION_NAME( \
308301
DT_PHANDLE(DT_DRV_INST(idx), memory_regions)))))), \
309302
())

drivers/i2c/i2c_nrfx_twim_common.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ extern "C" {
3838
* no longer ISR safe. This macro let's us check if we will be requesting/releasing
3939
* power domains and determines PM device ISR safety value.
4040
*/
41-
#define I2C_PM_ISR_SAFE(idx) \
41+
#define I2C_PM_ISR_SAFE(idx) \
4242
COND_CODE_1( \
4343
UTIL_AND( \
4444
IS_ENABLED(CONFIG_PM_DEVICE_POWER_DOMAIN), \

drivers/i2c/i2c_nrfx_twim_rtio.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,7 @@ static int i2c_nrfx_twim_rtio_deinit(const struct device *dev)
293293
}, \
294294
.ctx = &_i2c##idx##_twim_rtio, \
295295
}; \
296-
PM_DEVICE_DT_INST_DEFINE(idx, twim_nrfx_pm_action, I2C_PM_ISR_SAFE(idx)); \
296+
PM_DEVICE_DT_INST_DEFINE(idx, twim_nrfx_pm_action, I2C_PM_ISR_SAFE(idx)); \
297297
I2C_DEVICE_DT_INST_DEINIT_DEFINE(idx, i2c_nrfx_twim_rtio_init, i2c_nrfx_twim_rtio_deinit, \
298298
PM_DEVICE_DT_INST_GET(idx), &twim_##idx##z_data, \
299299
&twim_##idx##z_config, POST_KERNEL, \

drivers/i2c/i2c_nrfx_twis.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -162,8 +162,7 @@ static void shim_nrf_twis_handle_write_done(const struct device *dev)
162162
callbacks->buf_write_received(target_config, dev_config->buf, nrfx_twis_rx_amount(twis));
163163
}
164164

165-
static void shim_nrf_twis_event_handler(const struct device *dev,
166-
nrfx_twis_event_t const *event)
165+
static void shim_nrf_twis_event_handler(const struct device *dev, nrfx_twis_event_t const *event)
167166
{
168167
switch (event->type) {
169168
case NRFX_TWIS_EVT_READ_REQ:
@@ -318,7 +317,7 @@ static int shim_nrf_twis_deinit(const struct device *dev)
318317
&SHIM_NRF_TWIS_NAME(id, data).twis, 0); \
319318
} \
320319
\
321-
static void SHIM_NRF_TWIS_NAME(id, event_handler)(nrfx_twis_event_t const *event) \
320+
static void SHIM_NRF_TWIS_NAME(id, event_handler)(nrfx_twis_event_t const *event) \
322321
{ \
323322
shim_nrf_twis_event_handler(DEVICE_DT_INST_GET(id), event); \
324323
} \

0 commit comments

Comments
 (0)