Skip to content

Commit 25c0bb1

Browse files
carlocaionembolivar-nordic
authored andcommitted
[nrf fromtree] ipc_service: static_vrings: Set WQ default type to PRIO_COOP
In 92d8329 a new DT property was introduced to set the WQ priority of the instance. The fallback value when the property was not present was arbitrarily set to <0 PRIO_PREEMPT>. The problem is that this value is actually changing the behaviour for the code that is not explicitly setting the DT property, breaking in some cases the existing code. Move the default value to <0 PRIO_COOP> to give the old code a consistent behaviour before and after the 92d8329 commit. Signed-off-by: Carlo Caione <[email protected]> (cherry picked from commit 7f51907)
1 parent 1ffb386 commit 25c0bb1

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

dts/bindings/ipc/zephyr,ipc-openamp-static-vrings.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,4 +42,5 @@ properties:
4242
or for K_PRIO_PREEMPT(2)
4343
priority = <2 PRIO_PREEMPT>;
4444
45-
When this property is missing a default priority of 0 is assumed.
45+
When this property is missing a default priority of <0 PRIO_COOP> is
46+
assumed.

subsys/ipc/ipc_service/backends/ipc_rpmsg_static_vrings.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -610,7 +610,7 @@ static int backend_init(const struct device *instance)
610610
(0)), \
611611
.wq_prio_type = COND_CODE_1(DT_INST_NODE_HAS_PROP(i, zephyr_priority), \
612612
(DT_INST_PROP_BY_IDX(i, zephyr_priority, 1)), \
613-
(PRIO_PREEMPT)), \
613+
(PRIO_COOP)), \
614614
.id = i, \
615615
}
616616

0 commit comments

Comments
 (0)