Skip to content

Commit 7409f0f

Browse files
committed
Revert "[nrf fromlist] arch: Allow to specify memory for S2RAM resume"
This reverts commit cc5a1b4. Signed-off-by: Andrzej Puzdrowski <[email protected]>
1 parent e4fed30 commit 7409f0f

File tree

2 files changed

+0
-17
lines changed

2 files changed

+0
-17
lines changed

arch/arm/core/cortex_m/reset.S

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -101,17 +101,6 @@ SECTION_SUBSEC_FUNC(TEXT,_reset_section,__start)
101101
#endif /* CONFIG_INIT_ARCH_HW_AT_BOOT */
102102

103103
#if defined(CONFIG_PM_S2RAM)
104-
#if DT_NODE_EXISTS(DT_NODELABEL(pm_s2ram_stack)) &&\
105-
DT_NODE_HAS_COMPAT(DT_NODELABEL(pm_s2ram_stack), zephyr_memory_region)
106-
/* In certain scenarios, the interrupt stack is actually not safe to overwrite.
107-
* For example, when MCUboot is used, the bootloader's "z_interrupt_stack" and the
108-
* loaded image's "z_interrupt_stacks" are NOT at the same address, and writing to
109-
* the former would corrupt unrelated data from the loaded image. To support such
110-
* scenarios, if the Device Tree provides a specially named "zephyr,memory-region",
111-
* use it as the stack to run arch_pm_s2ram_resume instead of the interrupt stack.
112-
*/
113-
ldr r0, =DT_REG_ADDR(DT_NODELABEL(pm_s2ram_stack)) + DT_REG_SIZE(DT_NODELABEL(pm_s2ram_stack))
114-
#else
115104
/*
116105
* Temporarily set MSP to interrupt stack so that arch_pm_s2ram_resume can
117106
* use stack for calling pm_s2ram_mark_check_and_clear.
@@ -124,7 +113,6 @@ SECTION_SUBSEC_FUNC(TEXT,_reset_section,__start)
124113
* a short while, there is no change in behavior in either of the paths.
125114
*/
126115
ldr r0, =z_interrupt_stacks + CONFIG_ISR_STACK_SIZE + MPU_GUARD_ALIGN_AND_SIZE
127-
#endif
128116
msr msp, r0
129117

130118
bl arch_pm_s2ram_resume

subsys/pm/Kconfig

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,11 +41,6 @@ config PM_S2RAM
4141
When enabled on Cortex-M, and a 'zephyr,memory-region' compatible node with nodelabel
4242
'pm_s2ram' is defined in DT, _cpu_context symbol (located in arch/arm/core/cortex_m/pm_s2ram.c)
4343
is placed in linker section given by 'zephyr,memory-region' property of aforementioned node.
44-
Additionally on Cortex-M, if a 'zephyr,memory-region' compatible node with nodelabel
45-
'pm_s2ram_stack' is defined in DT, this region will be used as a temporary program stack
46-
for the S2RAM resume logic. The assembly reset handling code itself makes a single push of
47-
the return address, but the SoC-specific function (pm_s2ram_mark_check_and_clear) must be
48-
analyzed to determine the required stack size.
4944

5045
config PM_S2RAM_CUSTOM_MARKING
5146
bool "Use custom marking functions"

0 commit comments

Comments
 (0)