[nrf fromtree] Revert "Bluetooth: att: don't re-use the ATT buffer for confirmations"

This reverts commit 4cd0748a407b118145916393a954231ee11abb1e.

Signed-off-by: Jonathan Rico <[email protected]>
(cherry picked from commit 41f96a6dcb971cffaa2ca1a8322573804fa1537e)

Author: jori-nordic

subsys/bluetooth/host/att.c

@@ -670,12 +670,10 @@ static struct net_buf *bt_att_chan_create_pdu(struct bt_att_chan *chan, uint8_t
 
 	switch (att_op_get_type(op)) {
 	case ATT_RESPONSE:
-		/* Use a timeout only when responding */
-		timeout = BT_ATT_TIMEOUT;
-		re_use = true;
-		break;
 	case ATT_CONFIRMATION:
+		/* Use a timeout only when responding/confirming */
 		timeout = BT_ATT_TIMEOUT;
+		re_use = true;
 		break;
 	default:
 		timeout = K_FOREVER;
@@ -703,7 +701,7 @@ static struct net_buf *bt_att_chan_create_pdu(struct bt_att_chan *chan, uint8_t
 			 * This is better than an assert as an assert would
 			 * allow a peer to DoS us.
 			 */
-			LOG_ERR("already processing a REQ/RSP on chan %p", chan);
+			LOG_ERR("already processing a transaction on chan %p", chan);
 
 			return NULL;
 		}