Skip to content

Commit 82e05d6

Browse files
krish2718rlubos
authored andcommitted
[nrf fromtree] drivers: nrfwifi: Fixes from doc review
Help text fixes from doc-team. Signed-off-by: Richa Pandey <[email protected]> Signed-off-by: Chaitanya Tata <[email protected]> (cherry picked from commit 580707e) (cherry picked from commit 7d6d734)
1 parent 88561ad commit 82e05d6

File tree

1 file changed

+68
-76
lines changed

1 file changed

+68
-76
lines changed

drivers/wifi/nrfwifi/Kconfig.nrfwifi

Lines changed: 68 additions & 76 deletions
Original file line numberDiff line numberDiff line change
@@ -69,15 +69,14 @@ config NRF70_RADIO_TEST
6969
bool "Radio test mode of the nRF70 driver"
7070

7171
config NRF70_OFFLOADED_RAW_TX
72-
bool "Offloaded raw Tx mode of the nRF70 driver"
72+
bool "Offloaded raw TX mode of the nRF70 driver"
7373

7474
config NRF70_SYSTEM_WITH_RAW_MODES
7575
bool "nRF70 system mode with raw modes"
7676
depends on WIFI_NRF7002 || WIFI_NRF7001
7777
select WIFI_NM_WPA_SUPPLICANT
7878
help
79-
Select this option to enable system mode of the nRF70 driver with raw modes
80-
79+
Select this option to enable system mode of the nRF70 driver with raw modes.
8180
endchoice
8281

8382
config NRF70_SYSTEM_MODE_COMMON
@@ -88,7 +87,7 @@ config NET_L2_ETHERNET
8887
default y if (!NRF70_RADIO_TEST && !NRF70_OFFLOADED_RAW_TX)
8988

9089
config HEAP_MEM_POOL_ADD_SIZE_NRF70
91-
# Use a maximum that works for typical usecases and boards, each sample/app can override
90+
# Use a maximum that works for typical use cases and boards, each sample/app can override
9291
# this value if needed by using CONFIG_HEAP_MEM_POOL_IGNORE_MIN
9392
def_int 25000 if NRF70_SCAN_ONLY
9493
def_int 150000
@@ -98,7 +97,7 @@ config NRF70_STA_MODE
9897
bool "nRF70 STA mode"
9998
default y
10099
help
101-
Select this option to enable STA mode of the nRF70 driver
100+
Select this option to enable STA mode of the nRF70 driver.
102101

103102
config NRF70_AP_MODE
104103
bool "Access point mode"
@@ -117,7 +116,7 @@ config NRF70_RAW_DATA_RX
117116
select EXPERIMENTAL
118117

119118
config NRF70_PROMISC_DATA_RX
120-
bool "promiscuous RX sniffer operation in the driver"
119+
bool "Promiscuous RX sniffer operation in the driver"
121120
select WIFI_NM_WPA_SUPPLICANT
122121
select EXPERIMENTAL
123122
select NET_PROMISCUOUS_MODE
@@ -154,7 +153,7 @@ config NRF_WIFI_PATCHES_EXTERNAL
154153
endchoice
155154

156155
config NRF_WIFI_LOW_POWER
157-
bool "low power mode in nRF Wi-Fi chipsets"
156+
bool "Low power mode in nRF Wi-Fi chipsets"
158157
default y
159158

160159
config NRF70_TCP_IP_CHECKSUM_OFFLOAD
@@ -235,7 +234,7 @@ config NRF70_PCB_LOSS_2G
235234
range 0 4
236235
help
237236
Specifies PCB loss from the antenna connector to the RF pin.
238-
The values are in dB scale in steps of 1dB and range of 0-4dB.
237+
The values are in dB scale in steps of 1 dB and range of 0-4 dB.
239238
The loss is considered in the RX path only.
240239

241240
config NRF70_PCB_LOSS_5G_BAND1
@@ -244,7 +243,7 @@ config NRF70_PCB_LOSS_5G_BAND1
244243
range 0 4
245244
help
246245
Specifies PCB loss from the antenna connector to the RF pin.
247-
The values are in dB scale in steps of 1dB and range of 0-4dB.
246+
The values are in dB scale in steps of 1 dB and range of 0-4 dB.
248247
The loss is considered in the RX path only.
249248

250249
config NRF70_PCB_LOSS_5G_BAND2
@@ -253,7 +252,7 @@ config NRF70_PCB_LOSS_5G_BAND2
253252
range 0 4
254253
help
255254
Specifies PCB loss from the antenna connector to the RF pin.
256-
The values are in dB scale in steps of 1dB and range of 0-4dB.
255+
The values are in dB scale in steps of 1 dB and range of 0-4 dB.
257256
The loss is considered in the RX path only.
258257

259258
config NRF70_PCB_LOSS_5G_BAND3
@@ -262,7 +261,7 @@ config NRF70_PCB_LOSS_5G_BAND3
262261
range 0 4
263262
help
264263
Specifies PCB loss from the antenna connector to the RF pin.
265-
The values are in dB scale in steps of 1dB and range of 0-4dB.
264+
The values are in dB scale in steps of 1 dB and range of 0-4 dB.
266265
The loss is considered in the RX path only.
267266

268267
config NRF70_ANT_GAIN_2G
@@ -491,25 +490,23 @@ config NRF70_RPU_PS_IDLE_TIMEOUT_MS
491490
config NRF70_RPU_EXTEND_TWT_SP
492491
bool "extending TWT service period"
493492
help
494-
In case frames accepted before beginning of SP are not
495-
transmitted before the SP completes then typically they are
496-
dropped to conform to SP window as per specification i.e., no
493+
In case frames accepted before the beginning of SP are not
494+
transmitted before the SP completes, then typically they are
495+
dropped to conform to the SP window as per the specification that is, no
497496
transmission outside SP window.
498-
499-
This feature mitigates the frame loss by transmitting even after SP
500-
completion by using standard contention mechanism which is allowed
497+
This feature mitigates frame loss by transmitting even after SP
498+
completion by using a standard contention mechanism, which is allowed
501499
in specification but not recommended. As the device is actively transmitting
502500
beyond SP, the power consumption increases depending on the amount
503-
of traffic available at the start of SP.
504-
505-
Please note that if a frame is sent after SP starts it will be queued and this
501+
of traffic available at the start of the SP.
502+
Note that if a frame is sent after the SP starts, it will be queued, and this
506503
mechanism is not used.
507504
endif # NRF_WIFI_LOW_POWER
508505

509506
config WIFI_FIXED_MAC_ADDRESS
510-
string "WiFi Fixed MAC address in format XX:XX:XX:XX:XX:XX"
507+
string "Wi-Fi Fixed MAC address in format XX:XX:XX:XX:XX:XX"
511508
help
512-
This overrides the MAC address read from OTP. Strictly for testing purposes only.
509+
This option overrides the MAC address read from OTP. It is strictly for testing purposes only.
513510

514511
choice
515512
prompt "Wi-Fi MAC address type"
@@ -529,7 +526,7 @@ config WIFI_FIXED_MAC_ADDRESS_ENABLED
529526
Enable fixed MAC address
530527

531528
config WIFI_RANDOM_MAC_ADDRESS
532-
bool "random MAC address generation at runtime"
529+
bool "Random MAC address generation at runtime"
533530
depends on ENTROPY_GENERATOR
534531
help
535532
This option enables random MAC address generation at runtime.
@@ -541,17 +538,17 @@ config NRF70_RSSI_STALE_TIMEOUT_MS
541538
int "RSSI stale timeout in milliseconds"
542539
default 1000
543540
help
544-
RSSI stale timeout is the period after which driver queries
545-
RPU to get the RSSI the value.
546-
If data is active (e.g. ping), driver stores the RSSI value from
541+
RSSI stale timeout is the period after which the driver queries
542+
RPU to get the RSSI value.
543+
If data is active (for example, ping), the driver stores the RSSI value from
547544
the received frames and provides this stored information
548-
to wpa_supplicant. In this case a higher value will be suitable
549-
as stored RSSI value at driver will be updated regularly.
545+
to wpa_supplicant. In this case, a higher value will be suitable
546+
as the stored RSSI value at the driver will be updated regularly.
550547
If data is not active or after the stale timeout duration,
551-
driver queries the RPU to get the RSSI value
552-
and provides it to wpa_supplicant. The value should be set to lower
553-
value as driver does not store it and requires RPU to provide the
554-
info.
548+
the driver queries the RPU to get the RSSI value
549+
and provides it to wpa_supplicant. The value should be set to a lower
550+
value as the driver does not store it and requires RPU to provide the
551+
information.
555552

556553
if NETWORKING
557554
# Finetune defaults for certain system components used by the driver
@@ -581,7 +578,7 @@ config MAIN_STACK_SIZE
581578
config SHELL_STACK_SIZE
582579
default 4096
583580

584-
# Override the Wi-Fi subsytems WIFI_MGMT_SCAN_SSID_FILT_MAX parameter,
581+
# Override the Wi-Fi subsystems WIFI_MGMT_SCAN_SSID_FILT_MAX parameter,
585582
# since we support a maximum of 2 SSIDs for scan result filtering.
586583
config WIFI_MGMT_SCAN_SSID_FILT_MAX
587584
default 2
@@ -594,7 +591,7 @@ config NRF_WIFI_SCAN_MAX_BSS_CNT
594591
Maximum number of scan results to return. 0 represents unlimited number of BSSes.
595592

596593
config NRF_WIFI_BEAMFORMING
597-
bool "Wi-Fi beamforming. Enabling beamforming can provide slight improvement in performance where as disabling it can provide better power saving in low network activity applications"
594+
bool "Wi-Fi beamforming. Enabling beamforming can provide a slight improvement in performance, whereas disabling it can provide better power savings in low network activity applications"
598595
default y
599596

600597
config WIFI_NRF70_SCAN_TIMEOUT_S
@@ -631,19 +628,18 @@ config NRF_WIFI_IFACE_MTU
631628
default 1500
632629

633630
config WIFI_NRF70_SKIP_LOCAL_ADMIN_MAC
634-
bool "Suppress networks with non-individual MAC address as BSSID in the scan results"
631+
bool "Suppress networks with non-individual MAC addresses as BSSID in the scan results"
635632
help
636-
Wi-Fi access points use locally administered MAC address to manage
637-
multiple virtual interfaces, for geo-location usecase these networks
638-
from the virtual interfaces do not help in anyway as they are co-located with the primary interface
639-
that has globally unique MAC address.
640-
633+
Wi-Fi access points use locally administered MAC addresses to manage
634+
multiple virtual interfaces. For geo-location use cases, these networks
635+
from the virtual interfaces do not help in any way as they are co-located with the primary interface
636+
that has a globally unique MAC address.
641637
So, to save resources, this option drops such networks from the scan results.
642638

643639
config WIFI_NRF70_SCAN_DISABLE_DFS_CHANNELS
644640
bool "Disables DFS channels in scan operation"
645641
help
646-
This option disables inclusion of DFS channels in scan operation.
642+
This option disables inclusion of the DFS channels in the scan operation.
647643
This is useful to reduce the scan time, as DFS channels are seldom used.
648644

649645
config NET_INTERFACE_NAME_LEN
@@ -655,30 +651,29 @@ config NRF_WIFI_AP_DEAD_DETECT_TIMEOUT
655651
range 1 30
656652
default 20
657653
help
658-
The number of seconds after which AP is declared dead if no beacons
659-
are received from the AP. Used to detect AP silently going down e.g., power off.
654+
The number of seconds after which the AP is declared dead if no beacons
655+
are received from the AP. This is used to detect AP silently going down, for example, due to power off.
660656

661657
config NRF_WIFI_RPU_RECOVERY
662658
bool "RPU recovery mechanism"
663659
depends on NRF_WIFI_LOW_POWER
664660
default y
665661
select EXPERIMENTAL
666662
help
667-
Enable RPU recovery mechanism to recover from RPU (nRF70) hang.
668-
This feature performs an interface reset (down and up) which triggers
669-
a RPU coldboot. Application's network connection will be lost during
670-
the recovery process and it is application's responsibility to
663+
Enable the RPU recovery mechanism to recover from an RPU (nRF70) hang.
664+
This feature performs an interface reset (down and up), which triggers
665+
a RPU cold boot. The application's network connection will be lost during
666+
the recovery process, and it is the application's responsibility to
671667
re-establish the network connection.
672668

673669
if NRF_WIFI_RPU_RECOVERY
674-
675670
config NRF_WIFI_RPU_RECOVERY_PROPAGATION_DELAY_MS
676671
int "RPU recovery propagation delay in milliseconds"
677672
default 2000
678673
help
679674
Propagation delay in milliseconds to wait after RPU is powered down
680675
before powering it up. This delay is required to ensure that the recovery
681-
is propagted to all the applications and stack and have enough time to
676+
is propagated to all the applications and stack and have enough time to
682677
clean up the resources.
683678

684679
config NET_MGMT_EVENT_QUEUE_SIZE
@@ -689,16 +684,16 @@ config NRF_WIFI_RPU_RECOVERY_PROPAGATION_DELAY_MS
689684
int "RPU recovery propagation delay in milliseconds"
690685
default 10
691686
help
692-
Propagation delay in milliseconds to wait after RPU is powered down
687+
Propagation delay in milliseconds to wait after the RPU is powered down
693688
before powering it up. This delay is required to ensure that the recovery
694-
is propagated to all the applications and stack and have enough time to
689+
is propagated to all the applications and stack, and has enough time to
695690
clean up the resources.
696691

697692
config NRF_WIFI_RPU_RECOVERY_PS_ACTIVE_TIMEOUT_MS
698693
int "RPU recovery power save active timeout in milliseconds"
699694
default 50000
700695
help
701-
Power save active timeout in milliseconds after which RPU recovery
696+
Power save active timeout in milliseconds, after which the RPU recovery
702697
mechanism will be triggered. This timeout is used to ensure that the
703698
RPU attempts to enter power save mode in case of inactivity.
704699

@@ -713,7 +708,7 @@ config NRF_WIFI_RPU_MIN_TIME_TO_ENTER_SLEEP_MS
713708
config NRF_WIFI_RPU_RECOVERY_DEBUG
714709
bool "RPU recovery debug logs"
715710
help
716-
Enable RPU recovery debug logs to help debug RPU recovery mechanism.
711+
Enable RPU recovery debug logs to help debug the RPU recovery mechanism.
717712

718713
config NRF_WIFI_RPU_RECOVERY_QUIET_PERIOD_MS
719714
int "RPU recovery quiet period in milliseconds"
@@ -727,7 +722,7 @@ config NRF_WIFI_RPU_RECOVERY_MAX_RETRIES
727722
default 0
728723
help
729724
Maximum number of consecutive RPU recovery retries before giving up
730-
and resetting the system. Set to 0 to keep retrying indefinitely.
725+
and resetting the system. Set it to 0 to keep retrying indefinitely.
731726

732727
config NRF_WIFI_RPU_RECOVERY_RETRY_WINDOW_S
733728
int "RPU recovery retry window in seconds"
@@ -741,16 +736,14 @@ config NRF_WIFI_RPU_RECOVERY_RETRY_WINDOW_S
741736
config NRF_WIFI_RPU_RECOVERY_PS_STATE_DEBUG
742737
bool "RPU recovery power save state debug logs"
743738
help
744-
Enable RPU recovery power save state debug logs to help debug RPU recovery mechanism.
745-
746-
739+
Enable RPU recovery power save state debug logs to help debug the RPU recovery mechanism.
747740
endif # NRF_WIFI_RPU_RECOVERY
748741

749742
config NRF_WIFI_FEAT_WMM
750743
bool "WMM/QoS support"
751744
default y
752745
help
753-
This option controls disable/enable of the WMM(Wireless Multi-Media) feature.
746+
This option controls disable/enable of the WMM (Wireless Multi-Media) feature.
754747

755748
choice NRF_WIFI_PS_DATA_RETRIEVAL_MECHANISM
756749
prompt "Power save data retrieval mechanism"
@@ -759,37 +752,36 @@ choice NRF_WIFI_PS_DATA_RETRIEVAL_MECHANISM
759752
Select the mechanism to retrieve buffered data from AP.
760753

761754
config NRF_WIFI_PS_POLL_BASED_RETRIEVAL
762-
bool "PS-Poll frame based mechanism to retrieve buffered data from AP"
755+
bool "PS-Poll frame-based mechanism to retrieve buffered data from AP"
763756
help
764-
When AP notifies about availability of buffered data, the STA stays in power save
765-
and retrieves the frames one-by-one, this conserved more power but adds latency
766-
to the traffic. Ideal for minimum number of frames.
757+
When the AP notifies about the availability of buffered data, the STA stays in power save
758+
and retrieves the frames one-by-one. This conserves more power but adds latency
759+
to the traffic. It is ideal for minimum number of frames.
767760

768761
config NRF_WIFI_QOS_NULL_BASED_RETRIEVAL
769-
bool "QoS null frame based mechanism to retrieve buffered data from AP"
762+
bool "QoS null frame-based mechanism to retrieve buffered data from AP"
770763
help
771-
When AP notifies about availability of buffered data, the STA comes out of
772-
power save and then AP can deliver all buffered frames without any additional
764+
When the AP notifies about the availability of buffered data, the STA comes out of
765+
power save, and then AP can deliver all buffered frames without any additional
773766
overhead or latency, but STA enters power save after a delay costing more power
774-
depending on the delay. Ideal for heavy buffered traffic.
775-
767+
depending on the delay. It is ideal for heavy buffered traffic.
776768
endchoice
777769

778770
config NRF_WIFI_MGMT_BUFF_OFFLOAD
779-
bool "management buffer offload"
771+
bool "Management buffer offload"
780772
default y
781773
help
782-
This option offloads the refilling of management buffers to UMAC, saves host
783-
having to exchange commands and events for every management packet even if it is
774+
This option offloads the refilling of management buffers to the UMAC, saving the host
775+
from having to exchange commands and events for every management packet even if it is
784776
consumed by UMAC.
785777

786778
config NRF_WIFI_FEAT_KEEPALIVE
787779
bool "Wi-Fi keepalive feature for connection maintenance"
788780
depends on NRF70_STA_MODE
789781
help
790-
Enable Wi-Fi keepalive feature to keep the connection alive by sending
791-
keepalive packets to the AP. Primarily intended to interoperate with APs
792-
that disconnect idle clients without any explicit checks. Slightly increases
782+
Enable the Wi-Fi keepalive feature to keep the connection alive by sending
783+
keepalive packets to the AP. This feature is primarily intended to interoperate with APs
784+
that disconnect idle clients without any explicit checks. It slightly increases
793785
power consumption.
794786

795787
if NRF_WIFI_FEAT_KEEPALIVE
@@ -816,9 +808,9 @@ config NRF_WIFI_PS_EXIT_EVERY_TIM
816808
config NRF_WIFI_PS_INT_PS
817809
bool "Exit power save based on an intelligent algorithm"
818810
help
819-
Exit power save based on an intelligent algorithm to retrieve buffered data from AP.
811+
Exit power save based on an intelligent algorithm to retrieve buffered data from the AP.
820812
The algorithm tracks the buffered data at the AP and then dynamically decides
821-
whether to stay in PS (for lower amount of buffered data) or exit PS (for higher
813+
whether to stay in PS (for a lower amount of buffered data) or exit PS (for a higher
822814
amount of buffered data).
823815
endchoice
824816

@@ -827,5 +819,5 @@ config NRF70_PASSIVE_SCAN_ONLY
827819
depends on NRF70_SCAN_ONLY
828820
help
829821
Enable this configuration to force passive scan on all channels.
830-
This will override application specified scan type.
822+
This will override application-specified scan type.
831823
endif # WIFI_NRF70

0 commit comments

Comments
 (0)