[nrf fromlist] Bluetooth: Host: Use memset to initialize psa_mac_operation_t

theob-pro · rlubos · commit a35da4f90d3a · 2025-02-26T12:05:53.000+01:00
In `db_hash_setup()` the state object for MAC operations was initialized
using `psa_mac_operation_init()`. This function was not always optimized
or inlined.

A way to reduce stack usage is to use `memset()` and set the object to
0. This is one of the option documented to initialize
`psa_mac_operation_t` object.

Upstream PR #: 86094

Signed-off-by: Théo Battrel &lt;theo.battrel@nordicsemi.no&gt;
diff --git a/subsys/bluetooth/host/gatt.c b/subsys/bluetooth/host/gatt.c
@@ -717,7 +717,7 @@ static int db_hash_setup(struct gen_hash_state *state, uint8_t *key)
 		LOG_ERR("Unable to import the key for AES CMAC %d", ret);
 		return -EIO;
 	}
-	state->operation = psa_mac_operation_init();
+	memset(&state->operation, 0, sizeof(state->operation));
 
 	ret = psa_mac_sign_setup(&(state->operation), state->key, PSA_ALG_CMAC);
 	if (ret != PSA_SUCCESS) {

Original file line number	Diff line number	Diff line change
`@@ -717,7 +717,7 @@ static int db_hash_setup(struct gen_hash_state state, uint8_t key)`
`717`	`717`	`LOG_ERR("Unable to import the key for AES CMAC %d", ret);`
`718`	`718`	`return -EIO;`
`719`	`719`	`}`
`720`		`- state->operation = psa_mac_operation_init();`
	`720`	`+ memset(&state->operation, 0, sizeof(state->operation));`
`721`	`721`
`722`	`722`	`ret = psa_mac_sign_setup(&(state->operation), state->key, PSA_ALG_CMAC);`
`723`	`723`	`if (ret != PSA_SUCCESS) {`