Skip to content

Commit aad40b6

Browse files
MaochenWang1krish2718
authored andcommitted
[nrf fromtree] net: l2: wifi: remove EAP TLS SHA256 security
Remove EAP TLS SHA256 security, as it was added to support the AKM of 00-0F-AC:5 in RSN IE, but actually this AKM is used by WPA3 enterprise only mode. Signed-off-by: Maochen Wang <[email protected]> (cherry picked from commit 4777dfa)
1 parent db413b6 commit aad40b6

File tree

4 files changed

+5
-17
lines changed

4 files changed

+5
-17
lines changed

include/zephyr/net/wifi.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,6 @@ enum wifi_security_type {
7676
WIFI_SECURITY_TYPE_EAP_TTLS_MSCHAPV2,
7777
/** EAP PEAP security - Enterprise. */
7878
WIFI_SECURITY_TYPE_EAP_PEAP_TLS,
79-
/** EAP TLS SHA256 security - Enterprise. */
80-
WIFI_SECURITY_TYPE_EAP_TLS_SHA256,
8179
/** FT-PSK security */
8280
WIFI_SECURITY_TYPE_FT_PSK,
8381
/** FT-SAE security */

modules/hostap/src/supp_api.c

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -481,7 +481,6 @@ static struct wifi_eap_config eap_config[] = {
481481
"auth=MSCHAPV2"},
482482
{WIFI_SECURITY_TYPE_EAP_PEAP_TLS, WIFI_EAP_TYPE_PEAP, WIFI_EAP_TYPE_TLS, "PEAP",
483483
"auth=TLS"},
484-
{WIFI_SECURITY_TYPE_EAP_TLS_SHA256, WIFI_EAP_TYPE_TLS, WIFI_EAP_TYPE_NONE, "TLS", NULL},
485484
};
486485

487486
int process_cipher_config(struct wifi_connect_req_params *params,
@@ -517,10 +516,6 @@ int process_cipher_config(struct wifi_connect_req_params *params,
517516
}
518517
}
519518

520-
if (params->security == WIFI_SECURITY_TYPE_EAP_TLS_SHA256) {
521-
cipher_config->key_mgmt = "WPA-EAP-SHA256";
522-
}
523-
524519
for (index = 0; index < ARRAY_SIZE(ciphers); index++) {
525520
if (cipher_capa == ciphers[index].capa) {
526521
cipher_config->group_cipher = ciphers[index].name;
@@ -557,8 +552,7 @@ static int is_eap_valid_security(int security)
557552
security == WIFI_SECURITY_TYPE_EAP_PEAP_MSCHAPV2 ||
558553
security == WIFI_SECURITY_TYPE_EAP_PEAP_GTC ||
559554
security == WIFI_SECURITY_TYPE_EAP_TTLS_MSCHAPV2 ||
560-
security == WIFI_SECURITY_TYPE_EAP_PEAP_TLS ||
561-
security == WIFI_SECURITY_TYPE_EAP_TLS_SHA256);
555+
security == WIFI_SECURITY_TYPE_EAP_PEAP_TLS);
562556
}
563557
#endif
564558

subsys/net/l2/wifi/wifi_mgmt.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,8 +83,6 @@ const char *wifi_security_txt(enum wifi_security_type security)
8383
return "EAP-TTLS-MSCHAPV2";
8484
case WIFI_SECURITY_TYPE_EAP_PEAP_TLS:
8585
return "EAP-PEAP-TLS";
86-
case WIFI_SECURITY_TYPE_EAP_TLS_SHA256:
87-
return "EAP-TLS-SHA256";
8886
case WIFI_SECURITY_TYPE_FT_PSK:
8987
return "FT-PSK";
9088
case WIFI_SECURITY_TYPE_FT_SAE:

subsys/net/l2/wifi/wifi_shell.c

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -915,8 +915,7 @@ static int cmd_wifi_connect(const struct shell *sh, size_t argc,
915915
cnx_params.security == WIFI_SECURITY_TYPE_EAP_PEAP_MSCHAPV2 ||
916916
cnx_params.security == WIFI_SECURITY_TYPE_EAP_PEAP_GTC ||
917917
cnx_params.security == WIFI_SECURITY_TYPE_EAP_TTLS_MSCHAPV2 ||
918-
cnx_params.security == WIFI_SECURITY_TYPE_EAP_PEAP_TLS ||
919-
cnx_params.security == WIFI_SECURITY_TYPE_EAP_TLS_SHA256) {
918+
cnx_params.security == WIFI_SECURITY_TYPE_EAP_PEAP_TLS) {
920919
cmd_wifi_set_enterprise_creds(sh, iface);
921920
}
922921
#endif
@@ -1924,8 +1923,7 @@ static int cmd_wifi_ap_enable(const struct shell *sh, size_t argc,
19241923
cnx_params.security == WIFI_SECURITY_TYPE_EAP_PEAP_MSCHAPV2 ||
19251924
cnx_params.security == WIFI_SECURITY_TYPE_EAP_PEAP_GTC ||
19261925
cnx_params.security == WIFI_SECURITY_TYPE_EAP_TTLS_MSCHAPV2 ||
1927-
cnx_params.security == WIFI_SECURITY_TYPE_EAP_PEAP_TLS ||
1928-
cnx_params.security == WIFI_SECURITY_TYPE_EAP_TLS_SHA256) {
1926+
cnx_params.security == WIFI_SECURITY_TYPE_EAP_PEAP_TLS) {
19291927
cmd_wifi_set_enterprise_creds(sh, iface);
19301928
}
19311929
#endif
@@ -3407,7 +3405,7 @@ SHELL_STATIC_SUBCMD_SET_CREATE(
34073405
"0:None, 1:WPA2-PSK, 2:WPA2-PSK-256, 3:SAE-HNP, 4:SAE-H2E, 5:SAE-AUTO, 6:WAPI,"
34083406
"7:EAP-TLS, 8:WEP, 9: WPA-PSK, 10: WPA-Auto-Personal, 11: DPP\n"
34093407
"12: EAP-PEAP-MSCHAPv2, 13: EAP-PEAP-GTC, 14: EAP-TTLS-MSCHAPv2,\n"
3410-
"15: EAP-PEAP-TLS, 16:EAP_TLS_SHA256\n"
3408+
"15: EAP-PEAP-TLS\n"
34113409
"-w --ieee-80211w=<MFP> (optional: needs security type to be specified)\n"
34123410
"0:Disable, 1:Optional, 2:Required\n"
34133411
"-b --band=<band> (2 -2.6GHz, 5 - 5Ghz, 6 - 6GHz)\n"
@@ -3650,7 +3648,7 @@ SHELL_SUBCMD_ADD((wifi), connect, NULL,
36503648
"0:None, 1:WPA2-PSK, 2:WPA2-PSK-256, 3:SAE-HNP, 4:SAE-H2E, 5:SAE-AUTO, 6:WAPI,"
36513649
"7:EAP-TLS, 8:WEP, 9: WPA-PSK, 10: WPA-Auto-Personal, 11: DPP\n"
36523650
"12: EAP-PEAP-MSCHAPv2, 13: EAP-PEAP-GTC, 14: EAP-TTLS-MSCHAPv2,\n"
3653-
"15: EAP-PEAP-TLS, 16:EAP_TLS_SHA256\n"
3651+
"15: EAP-PEAP-TLS\n"
36543652
"[-w, --ieee-80211w]: MFP (optional: needs security type to be specified)\n"
36553653
": 0:Disable, 1:Optional, 2:Required.\n"
36563654
"[-m, --bssid]: MAC address of the AP (BSSID).\n"

0 commit comments

Comments
 (0)