Skip to content

Commit b360e92

Browse files
mib1-nordicmasz-nordic
authored andcommitted
[nrf fromlist] drivers: nrf: Replace MDK symbols with new _HAS_ defines
Replace MDK symbols used in preprocessor #if statements for checking if a feature is present with dedicated _HAS_ macros defined in hal_nordic. Upstream PR #: 98333 Signed-off-by: Michał Bainczyk <[email protected]>
1 parent 7dee158 commit b360e92

File tree

4 files changed

+32
-71
lines changed

4 files changed

+32
-71
lines changed

drivers/adc/adc_nrfx_saadc.c

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,10 @@ BUILD_ASSERT((NRF_SAADC_AIN0 == NRFX_ANALOG_EXTERNAL_AIN0) &&
2424
(NRF_SAADC_AIN5 == NRFX_ANALOG_EXTERNAL_AIN5) &&
2525
(NRF_SAADC_AIN6 == NRFX_ANALOG_EXTERNAL_AIN6) &&
2626
(NRF_SAADC_AIN7 == NRFX_ANALOG_EXTERNAL_AIN7) &&
27-
#if defined(SAADC_CH_PSELP_PSELP_VDDHDIV5)
27+
#if NRF_SAADC_HAS_INPUT_VDDHDIV5
2828
(NRF_SAADC_VDDHDIV5 == NRFX_ANALOG_INTERNAL_VDDHDIV5) &&
2929
#endif
30-
#if defined(SAADC_CH_PSELP_PSELP_VDD)
30+
#if NRF_SAADC_HAS_INPUT_VDD
3131
(NRF_SAADC_VDD == NRFX_ANALOG_INTERNAL_VDD) &&
3232
#endif
3333
1,
@@ -117,42 +117,42 @@ static int gain_set(nrf_saadc_channel_config_t *ch_cfg, enum adc_gain gain)
117117
{
118118
#if NRF_SAADC_HAS_CH_GAIN
119119
switch (gain) {
120-
#if defined(SAADC_CH_CONFIG_GAIN_Gain1_6)
120+
#if NRF_SAADC_HAS_GAIN_1_6
121121
case ADC_GAIN_1_6:
122122
ch_cfg->gain = NRF_SAADC_GAIN1_6;
123123
break;
124124
#endif
125-
#if defined(SAADC_CH_CONFIG_GAIN_Gain1_5)
125+
#if NRF_SAADC_HAS_GAIN_1_5
126126
case ADC_GAIN_1_5:
127127
ch_cfg->gain = NRF_SAADC_GAIN1_5;
128128
break;
129129
#endif
130-
#if defined(SAADC_CH_CONFIG_GAIN_Gain1_4) || defined(SAADC_CH_CONFIG_GAIN_Gain2_8)
130+
#if NRF_SAADC_HAS_GAIN_1_4
131131
case ADC_GAIN_1_4:
132132
ch_cfg->gain = NRF_SAADC_GAIN1_4;
133133
break;
134134
#endif
135-
#if defined(SAADC_CH_CONFIG_GAIN_Gain2_7)
135+
#if NRF_SAADC_HAS_GAIN_2_7
136136
case ADC_GAIN_2_7:
137137
ch_cfg->gain = NRF_SAADC_GAIN2_7;
138138
break;
139139
#endif
140-
#if defined(SAADC_CH_CONFIG_GAIN_Gain1_3) || defined(SAADC_CH_CONFIG_GAIN_Gain2_6)
140+
#if NRF_SAADC_HAS_GAIN_1_3
141141
case ADC_GAIN_1_3:
142142
ch_cfg->gain = NRF_SAADC_GAIN1_3;
143143
break;
144144
#endif
145-
#if defined(SAADC_CH_CONFIG_GAIN_Gain2_5)
145+
#if NRF_SAADC_HAS_GAIN_2_5
146146
case ADC_GAIN_2_5:
147147
ch_cfg->gain = NRF_SAADC_GAIN2_5;
148148
break;
149149
#endif
150-
#if defined(SAADC_CH_CONFIG_GAIN_Gain1_2) || defined(SAADC_CH_CONFIG_GAIN_Gain2_4)
150+
#if NRF_SAADC_HAS_GAIN_1_2
151151
case ADC_GAIN_1_2:
152152
ch_cfg->gain = NRF_SAADC_GAIN1_2;
153153
break;
154154
#endif
155-
#if defined(SAADC_CH_CONFIG_GAIN_Gain2_3)
155+
#if NRF_SAADC_HAS_GAIN_2_3
156156
case ADC_GAIN_2_3:
157157
ch_cfg->gain = NRF_SAADC_GAIN2_3;
158158
break;
@@ -163,15 +163,15 @@ static int gain_set(nrf_saadc_channel_config_t *ch_cfg, enum adc_gain gain)
163163
case ADC_GAIN_2:
164164
ch_cfg->gain = NRF_SAADC_GAIN2;
165165
break;
166-
#if defined(SAADC_CH_CONFIG_GAIN_Gain4)
166+
#if NRF_SAADC_HAS_GAIN_4
167167
case ADC_GAIN_4:
168168
ch_cfg->gain = NRF_SAADC_GAIN4;
169169
break;
170170
#endif
171171
default:
172172
#else
173173
if (gain != ADC_GAIN_1) {
174-
#endif /* defined(NRF_SAADC_HAS_CH_GAIN) */
174+
#endif /* NRF_SAADC_HAS_CH_GAIN */
175175
LOG_ERR("Selected ADC gain is not valid");
176176
return -EINVAL;
177177
}
@@ -182,17 +182,17 @@ static int gain_set(nrf_saadc_channel_config_t *ch_cfg, enum adc_gain gain)
182182
static int reference_set(nrf_saadc_channel_config_t *ch_cfg, enum adc_reference reference)
183183
{
184184
switch (reference) {
185-
#if defined(SAADC_CH_CONFIG_REFSEL_Internal)
185+
#if NRF_SAADC_HAS_REFERENCE_INTERNAL
186186
case ADC_REF_INTERNAL:
187187
ch_cfg->reference = NRF_SAADC_REFERENCE_INTERNAL;
188188
break;
189189
#endif
190-
#if defined(SAADC_CH_CONFIG_REFSEL_VDD1_4)
190+
#if NRF_SAADC_HAS_REFERENCE_VDD4
191191
case ADC_REF_VDD_1_4:
192192
ch_cfg->reference = NRF_SAADC_REFERENCE_VDD4;
193193
break;
194194
#endif
195-
#if defined(SAADC_CH_CONFIG_REFSEL_External)
195+
#if NRF_SAADC_HAS_REFERENCE_EXTERNAL
196196
case ADC_REF_EXTERNAL0:
197197
ch_cfg->reference = NRF_SAADC_REFERENCE_EXTERNAL;
198198
break;

drivers/comparator/comparator_nrf_comp.c

Lines changed: 13 additions & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -43,20 +43,6 @@
4343

4444
#define SHIM_NRF_COMP_DT_INST_PSEL(inst) DT_INST_PROP(inst, psel)
4545

46-
#if defined(COMP_HYST_HYST_Hyst40mV)
47-
#define NRF_COMP_HYST_ENABLED NRF_COMP_HYST_40MV
48-
#elif defined(COMP_HYST_HYST_Hyst50mV)
49-
#define NRF_COMP_HYST_ENABLED NRF_COMP_HYST_50MV
50-
#endif
51-
52-
#define NRF_COMP_HYST_DISABLED NRF_COMP_HYST_NO_HYST
53-
54-
#if defined(NRF_COMP_HYST_ENABLED)
55-
#define NRF_COMP_HAS_HYST 1
56-
#else
57-
#define NRF_COMP_HAS_HYST 0
58-
#endif
59-
6046
struct shim_nrf_comp_data {
6147
uint32_t event_mask;
6248
bool started;
@@ -78,47 +64,33 @@ BUILD_ASSERT((NRF_COMP_AIN0 == NRFX_ANALOG_EXTERNAL_AIN0) &&
7864
(NRF_COMP_AIN5 == NRFX_ANALOG_EXTERNAL_AIN5) &&
7965
(NRF_COMP_AIN6 == NRFX_ANALOG_EXTERNAL_AIN6) &&
8066
(NRF_COMP_AIN7 == NRFX_ANALOG_EXTERNAL_AIN7) &&
81-
#if defined(COMP_PSEL_PSEL_VddhDiv5)
67+
#if NRF_COMP_HAS_VDDH_DIV5
8268
(NRF_COMP_AIN_VDDH_DIV5 == NRFX_ANALOG_INTERNAL_VDDHDIV5) &&
8369
#endif
84-
#if defined(COMP_PSEL_PSEL_VddDiv2)
70+
#if NRF_COMP_HAS_VDD_DIV2
8571
(NRF_COMP_AIN_VDD_DIV2 == NRFX_ANALOG_INTERNAL_VDDDIV2) &&
8672
#endif
8773
1,
8874
"Definitions from nrf-comp.h do not match those from nrfx_analog_common.h");
8975

90-
#ifndef COMP_MODE_SP_Normal
76+
#if !NRF_COMP_HAS_SP_MODE_NORMAL
9177
BUILD_ASSERT(SHIM_NRF_COMP_DT_INST_SP_MODE(0) != COMP_NRF_COMP_SP_MODE_NORMAL);
9278
#endif
9379

94-
#if NRF_COMP_HAS_ISOURCE
95-
#ifndef COMP_ISOURCE_ISOURCE_Ien2uA5
96-
BUILD_ASSERT(SHIM_NRF_COMP_DT_INST_ISOURCE(0) != COMP_NRF_COMP_ISOURCE_2UA5);
97-
#endif
98-
99-
#ifndef COMP_ISOURCE_ISOURCE_Ien5uA
100-
BUILD_ASSERT(SHIM_NRF_COMP_DT_INST_ISOURCE(0) != COMP_NRF_COMP_ISOURCE_5UA);
101-
#endif
102-
103-
#ifndef COMP_ISOURCE_ISOURCE_Ien10uA
104-
BUILD_ASSERT(SHIM_NRF_COMP_DT_INST_ISOURCE(0) != COMP_NRF_COMP_ISOURCE_10UA);
105-
#endif
106-
#endif
107-
10880
#if SHIM_NRF_COMP_DT_INST_MAIN_MODE_IS_SE(0)
109-
#ifndef COMP_REFSEL_REFSEL_Int1V8
81+
#if !NRF_COMP_HAS_REF_INT_1V8
11082
BUILD_ASSERT(SHIM_NRF_COMP_DT_INST_REFSEL(0) != COMP_NRF_COMP_REFSEL_INT_1V8);
11183
#endif
11284

113-
#ifndef COMP_REFSEL_REFSEL_Int2V4
85+
#if !NRF_COMP_HAS_REF_INT_2V4
11486
BUILD_ASSERT(SHIM_NRF_COMP_DT_INST_REFSEL(0) != COMP_NRF_COMP_REFSEL_INT_2V4);
11587
#endif
11688

117-
#ifndef COMP_REFSEL_REFSEL_AVDDAO1V8
89+
#if !NRF_COMP_HAS_REF_AVDDAO1V8
11890
BUILD_ASSERT(SHIM_NRF_COMP_DT_INST_REFSEL(0) != COMP_NRF_COMP_REFSEL_AVDDAO1V8);
11991
#endif
12092

121-
#ifndef COMP_REFSEL_REFSEL_VDD
93+
#if !NRF_COMP_HAS_REF_VDD
12294
BUILD_ASSERT(SHIM_NRF_COMP_DT_INST_REFSEL(0) != COMP_NRF_COMP_REFSEL_VDD);
12395
#endif
12496
#endif
@@ -218,7 +190,7 @@ static int shim_nrf_comp_sp_mode_to_nrf(enum comp_nrf_comp_sp_mode shim,
218190
*nrf = NRF_COMP_SP_MODE_LOW;
219191
break;
220192

221-
#if defined(COMP_MODE_SP_Normal)
193+
#if NRF_COMP_HAS_SP_MODE_NORMAL
222194
case COMP_NRF_COMP_SP_MODE_NORMAL:
223195
*nrf = NRF_COMP_SP_MODE_NORMAL;
224196
break;
@@ -237,31 +209,21 @@ static int shim_nrf_comp_sp_mode_to_nrf(enum comp_nrf_comp_sp_mode shim,
237209

238210
#if NRF_COMP_HAS_ISOURCE
239211
static int shim_nrf_comp_isource_to_nrf(enum comp_nrf_comp_isource shim,
240-
nrf_isource_t *nrf)
212+
nrf_comp_isource_t *nrf)
241213
{
242214
switch (shim) {
243215
case COMP_NRF_COMP_ISOURCE_DISABLED:
244216
*nrf = NRF_COMP_ISOURCE_OFF;
245217
break;
246-
247-
#if defined(COMP_ISOURCE_ISOURCE_Ien2uA5)
248218
case COMP_NRF_COMP_ISOURCE_2UA5:
249219
*nrf = NRF_COMP_ISOURCE_IEN_2UA5;
250220
break;
251-
#endif
252-
253-
#if defined(COMP_ISOURCE_ISOURCE_Ien5uA)
254221
case COMP_NRF_COMP_ISOURCE_5UA:
255222
*nrf = NRF_COMP_ISOURCE_IEN_5UA;
256223
break;
257-
#endif
258-
259-
#if defined(COMP_ISOURCE_ISOURCE_Ien10uA)
260224
case COMP_NRF_COMP_ISOURCE_10UA:
261225
*nrf = NRF_COMP_ISOURCE_IEN_10UA;
262226
break;
263-
#endif
264-
265227
default:
266228
return -EINVAL;
267229
}
@@ -278,25 +240,25 @@ static int shim_nrf_comp_refsel_to_nrf(enum comp_nrf_comp_refsel shim,
278240
*nrf = NRF_COMP_REF_INT_1V2;
279241
break;
280242

281-
#if defined(COMP_REFSEL_REFSEL_Int1V8)
243+
#if NRF_COMP_HAS_REF_INT_1V8
282244
case COMP_NRF_COMP_REFSEL_INT_1V8:
283245
*nrf = NRF_COMP_REF_INT_1V8;
284246
break;
285247
#endif
286248

287-
#if defined(COMP_REFSEL_REFSEL_Int2V4)
249+
#if NRF_COMP_HAS_REF_INT_2V4
288250
case COMP_NRF_COMP_REFSEL_INT_2V4:
289251
*nrf = NRF_COMP_REF_INT_2V4;
290252
break;
291253
#endif
292254

293-
#if defined(COMP_REFSEL_REFSEL_AVDDAO1V8)
255+
#if NRF_COMP_HAS_REF_AVDDAO1V8
294256
case COMP_NRF_COMP_REFSEL_AVDDAO1V8:
295257
*nrf = NRF_COMP_REF_AVDDAO1V8;
296258
break;
297259
#endif
298260

299-
#if defined(COMP_REFSEL_REFSEL_VDD)
261+
#if NRF_COMP_HAS_REF_VDD
300262
case COMP_NRF_COMP_REFSEL_VDD:
301263
*nrf = NRF_COMP_REF_VDD;
302264
break;

drivers/i2s/i2s_nrfx.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -419,8 +419,7 @@ static int i2s_nrfx_configure(const struct device *dev, enum i2s_dir dir,
419419
* the MCK output is used), find a suitable clock configuration for it.
420420
*/
421421
if (nrfx_cfg.mode == NRF_I2S_MODE_MASTER ||
422-
(nrf_i2s_mck_pin_get(drv_cfg->i2s.p_reg) & I2S_PSEL_MCK_CONNECT_Msk)
423-
== I2S_PSEL_MCK_CONNECT_Connected << I2S_PSEL_MCK_CONNECT_Pos) {
422+
nrf_i2s_mck_pin_connected_check(drv_cfg->i2s.p_reg)) {
424423
find_suitable_clock(drv_cfg, &nrfx_cfg, i2s_cfg);
425424
/* Unless the PCLK32M source is used with the HFINT oscillator
426425
* (which is always available without any additional actions),

drivers/serial/uart_nrfx_uarte.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -694,7 +694,7 @@ static int uarte_nrfx_configure(const struct device *dev,
694694
struct uarte_nrfx_data *data = dev->data;
695695
nrf_uarte_config_t uarte_cfg;
696696

697-
#if defined(UARTE_CONFIG_STOP_Msk)
697+
#if NRF_UARTE_HAS_STOP_MODES
698698
switch (cfg->stop_bits) {
699699
case UART_CFG_STOP_BITS_1:
700700
uarte_cfg.stop = NRF_UARTE_STOP_ONE;
@@ -726,7 +726,7 @@ static int uarte_nrfx_configure(const struct device *dev,
726726
return -ENOTSUP;
727727
}
728728

729-
#if defined(UARTE_CONFIG_PARITYTYPE_Msk)
729+
#if NRF_UARTE_HAS_PARITY_TYPES
730730
uarte_cfg.paritytype = NRF_UARTE_PARITYTYPE_EVEN;
731731
#endif
732732
switch (cfg->parity) {
@@ -736,7 +736,7 @@ static int uarte_nrfx_configure(const struct device *dev,
736736
case UART_CFG_PARITY_EVEN:
737737
uarte_cfg.parity = NRF_UARTE_PARITY_INCLUDED;
738738
break;
739-
#if defined(UARTE_CONFIG_PARITYTYPE_Msk)
739+
#if NRF_UARTE_HAS_PARITY_TYPES
740740
case UART_CFG_PARITY_ODD:
741741
uarte_cfg.parity = NRF_UARTE_PARITY_INCLUDED;
742742
uarte_cfg.paritytype = NRF_UARTE_PARITYTYPE_ODD;

0 commit comments

Comments
 (0)