Skip to content

Commit d6eec3b

Browse files
committed
Revert "[nrf fromlist] drivers: serial: nrfx_uarte: Workaround for spurious RXTO during restart"
This reverts commit b70dea6. Signed-off-by: Krzysztof Chruściński <[email protected]>
1 parent 72b10b3 commit d6eec3b

File tree

2 files changed

+0
-22
lines changed

2 files changed

+0
-22
lines changed

drivers/serial/Kconfig.nrfx

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -63,11 +63,6 @@ config UART_ASYNC_TX_CACHE_SIZE
6363
in RAM, because EasyDMA in UARTE peripherals can only transfer data
6464
from RAM.
6565

66-
config UART_NRFX_UARTE_SPURIOUS_RXTO_WORKAROUND
67-
bool
68-
help
69-
Apply workaround for spurious RXTO during restart.
70-
7166
if HAS_HW_NRF_UART0 || HAS_HW_NRF_UARTE0
7267
nrfx_uart_num = 0
7368
rsource "Kconfig.nrfx_uart_instance"

drivers/serial/uart_nrfx_uarte.c

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -266,9 +266,6 @@ struct uarte_nrfx_data {
266266
/* If enabled then UARTE peripheral is using memory which is cacheable. */
267267
#define UARTE_CFG_FLAG_CACHEABLE BIT(3)
268268

269-
/* Indicates that workaround for spurious RXTO during restart shall be applied. */
270-
#define UARTE_CFG_FLAG_SPURIOUS_RXTO BIT(3)
271-
272269
/* Formula for getting the baudrate settings is following:
273270
* 2^12 * (2^20 / (f_PCLK / desired_baudrate)) where f_PCLK is a frequency that
274271
* drives the UARTE.
@@ -1549,17 +1546,6 @@ static void endrx_isr(const struct device *dev)
15491546
unsigned int key = irq_lock();
15501547

15511548
if (async_rx->buf) {
1552-
1553-
#if CONFIG_UART_NRFX_UARTE_SPURIOUS_RXTO_WORKAROUND
1554-
/* Check for spurious RXTO event. */
1555-
const struct uarte_nrfx_config *config = dev->config;
1556-
1557-
if ((config->flags & UARTE_CFG_FLAG_SPURIOUS_RXTO) &&
1558-
nrf_uarte_event_check(uarte, NRF_UARTE_EVENT_RXTO)) {
1559-
nrf_uarte_event_clear(uarte, NRF_UARTE_EVENT_RXTO);
1560-
}
1561-
#endif
1562-
15631549
/* Check is based on assumption that ISR handler handles
15641550
* ENDRX before RXSTARTED so if short was set on time, RXSTARTED
15651551
* event will be set.
@@ -2581,9 +2567,6 @@ static int uarte_instance_init(const struct device *dev,
25812567
(!IS_ENABLED(CONFIG_HAS_NORDIC_DMM) ? 0 : \
25822568
(UARTE_IS_CACHEABLE(idx) ? \
25832569
UARTE_CFG_FLAG_CACHEABLE : 0)) | \
2584-
(IS_ENABLED(CONFIG_UART_NRFX_UARTE_SPURIOUS_RXTO_WORKAROUND) && \
2585-
INSTANCE_IS_HIGH_SPEED(_, /*empty*/, idx, _) ? \
2586-
UARTE_CFG_FLAG_SPURIOUS_RXTO : 0) | \
25872570
USE_LOW_POWER(idx), \
25882571
UARTE_DISABLE_RX_INIT(UARTE(idx)), \
25892572
.poll_out_byte = &uarte##idx##_poll_out_byte, \

0 commit comments

Comments
 (0)