Skip to content

Commit f3cee4e

Browse files
Revert "[nrf noup] drivers: spi_dw: Bring back custom EXMIF peripheral handling"
This reverts commit f5228b9. Signed-off-by: Bjarki Arge Andreasen <[email protected]>
1 parent 390d391 commit f3cee4e

File tree

3 files changed

+2
-41
lines changed

3 files changed

+2
-41
lines changed

drivers/pinctrl/pinctrl_nrf.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -428,8 +428,7 @@ int pinctrl_configure_pins(const pinctrl_soc_pin_t *pins, uint8_t pin_cnt,
428428
input = NRF_GPIO_PIN_INPUT_CONNECT;
429429
break;
430430
#endif /* DT_HAS_COMPAT_STATUS_OKAY(nordic_nrf_can) */
431-
#if DT_HAS_COMPAT_STATUS_OKAY(nordic_nrf_exmif) || \
432-
DT_HAS_COMPAT_STATUS_OKAY(nordic_nrf_exmif_spi)
431+
#if DT_HAS_COMPAT_STATUS_OKAY(nordic_nrf_exmif)
433432
/* Pin routing is controlled by secure domain, via UICR */
434433
case NRF_FUN_EXMIF_CK:
435434
case NRF_FUN_EXMIF_DQ0:

drivers/spi/spi_dw.c

Lines changed: 1 addition & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -41,14 +41,6 @@ LOG_MODULE_REGISTER(spi_dw);
4141
#include <zephyr/drivers/pinctrl.h>
4242
#endif
4343

44-
#ifdef CONFIG_HAS_NRFX
45-
#include <nrfx.h>
46-
#endif
47-
48-
#ifdef CONFIG_SOC_NRF54H20_GPD
49-
#include <nrf/gpd.h>
50-
#endif
51-
5244
static inline bool spi_dw_is_slave(struct spi_dw_data *spi)
5345
{
5446
return (IS_ENABLED(CONFIG_SPI_SLAVE) &&
@@ -266,7 +258,6 @@ static int spi_dw_configure(const struct device *dev,
266258
/* Baud rate and Slave select, for master only */
267259
write_baudr(dev, SPI_DW_CLK_DIVIDER(info->clock_frequency,
268260
config->frequency));
269-
write_ser(dev, BIT(config->slave));
270261
}
271262

272263
if (spi_dw_is_slave(spi)) {
@@ -521,10 +512,6 @@ void spi_dw_isr(const struct device *dev)
521512
uint32_t int_status;
522513
int error;
523514

524-
#ifdef CONFIG_HAS_NRFX
525-
NRF_EXMIF->EVENTS_CORE = 0;
526-
#endif
527-
528515
int_status = read_isr(dev);
529516

530517
LOG_DBG("SPI %p int_status 0x%x - (tx: %d, rx: %d)", dev, int_status,
@@ -573,18 +560,6 @@ int spi_dw_init(const struct device *dev)
573560

574561
DEVICE_MMIO_MAP(dev, K_MEM_CACHE_NONE);
575562

576-
#ifdef CONFIG_HAS_NRFX
577-
NRF_EXMIF->INTENSET = BIT(0);
578-
NRF_EXMIF->TASKS_START = 1;
579-
580-
#ifdef CONFIG_SOC_NRF54H20_GPD
581-
err = nrf_gpd_request(NRF_GPD_FAST_ACTIVE1);
582-
if (err < 0) {
583-
return err;
584-
}
585-
#endif
586-
#endif
587-
588563
info->config_func();
589564

590565
/* Masking interrupt and making sure controller is disabled */
@@ -609,11 +584,6 @@ int spi_dw_init(const struct device *dev)
609584
return 0;
610585
}
611586

612-
#define REG_ADDR(inst) \
613-
COND_CODE_1(DT_NODE_HAS_COMPAT(DT_DRV_INST(inst), nordic_nrf_exmif_spi), \
614-
(Z_DEVICE_MMIO_NAMED_ROM_INITIALIZER(core, DT_DRV_INST(inst))), \
615-
(DEVICE_MMIO_ROM_INIT(DT_DRV_INST(inst))))
616-
617587
#define SPI_CFG_IRQS_SINGLE_ERR_LINE(inst) \
618588
IRQ_CONNECT(DT_INST_IRQ_BY_NAME(inst, rx_avail, irq), \
619589
DT_INST_IRQ_BY_NAME(inst, rx_avail, priority), \
@@ -686,7 +656,7 @@ COND_CODE_1(IS_EQ(DT_NUM_IRQS(DT_DRV_INST(inst)), 1), \
686656
SPI_CONTEXT_CS_GPIOS_INITIALIZE(DT_DRV_INST(inst), ctx) \
687657
}; \
688658
static const struct spi_dw_config spi_dw_config_##inst = { \
689-
REG_ADDR(inst), \
659+
DEVICE_MMIO_ROM_INIT(DT_DRV_INST(inst)), \
690660
.clock_frequency = COND_CODE_1( \
691661
DT_NODE_HAS_PROP(DT_INST_PHANDLE(inst, clocks), clock_frequency), \
692662
(DT_INST_PROP_BY_PHANDLE(inst, clocks, clock_frequency)), \

dts/bindings/spi/nordic,nrf-exmif-spi.yaml

Lines changed: 0 additions & 8 deletions
This file was deleted.

0 commit comments

Comments
 (0)