[nrf fromlist] drivers: serial: nrfx_uarte2: Fix handling of errors in interrupt driven mode #1842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4dd0af5. Signed-off-by: Robert Lubos <[email protected]>
This reverts commit da1af7e. Signed-off-by: Robert Lubos <[email protected]>
…ct` command" This reverts commit 73bef57. Signed-off-by: Robert Lubos <[email protected]>
… get opt parsing" This reverts commit 08dee4b. Signed-off-by: Robert Lubos <[email protected]>
… platform allow" This reverts commit 51c8066. Signed-off-by: Robert Lubos <[email protected]>
…ccess" This reverts commit 2d2a2e0. Signed-off-by: Robert Lubos <[email protected]>
…ement API" This reverts commit 955ca26. Signed-off-by: Robert Lubos <[email protected]>
…gement" This reverts commit 4fa036e. Signed-off-by: Robert Lubos <[email protected]>
This reverts commit 1758a32. Signed-off-by: Robert Lubos <[email protected]>
This reverts commit ffbf62c. Signed-off-by: Robert Lubos <[email protected]>
…_posix" This reverts commit 1552882. Signed-off-by: Robert Lubos <[email protected]>
…ore samples" This reverts commit cce7219. Signed-off-by: Robert Lubos <[email protected]>
This reverts commit 634bfae. Signed-off-by: Robert Lubos <[email protected]>
…n nRF54L" This reverts commit b320a9e. Signed-off-by: Robert Lubos <[email protected]>
This reverts commit 2ef7c81. Signed-off-by: Robert Lubos <[email protected]>
This reverts commit 570c8c2. Signed-off-by: Robert Lubos <[email protected]>
… devices" This reverts commit f50ad41. Signed-off-by: Robert Lubos <[email protected]>
This reverts commit 253ee08. Signed-off-by: Robert Lubos <[email protected]>
This reverts commit 63c8c9d. Signed-off-by: Robert Lubos <[email protected]>
…dc_api test" This reverts commit 2da6498. Signed-off-by: Robert Lubos <[email protected]>
This reverts commit 51f7968. Signed-off-by: Robert Lubos <[email protected]>
…54L15 device" This reverts commit 57de7d1. Signed-off-by: Robert Lubos <[email protected]>
…s output set high" This reverts commit 3733e70. Signed-off-by: Robert Lubos <[email protected]>
…54 TWIS" This reverts commit 28e2f57. Signed-off-by: Robert Lubos <[email protected]>
This reverts commit f706d53. Signed-off-by: Robert Lubos <[email protected]>
…54h20" This reverts commit 5660de7. Signed-off-by: Robert Lubos <[email protected]>
This reverts commit a412cab. Signed-off-by: Robert Lubos <[email protected]>
…n call" This reverts commit 8e66a57. Signed-off-by: Robert Lubos <[email protected]>
…ting" This reverts commit f5c0d31. Signed-off-by: Robert Lubos <[email protected]>
…in suspend" This reverts commit 6e61c5e. Signed-off-by: Robert Lubos <[email protected]>
…nsole Extend automated testing on HW by veryfing console output. Signed-off-by: Piotr Kosycarz <[email protected]> (cherry picked from commit 83958eb)
Pins P0.06 and P0.07 are shorted on nRF5340 DKs prepared for on-target tests because that is required for UART tests. That causes background SPIM transfers in this sample to fail because SPIM is not able to drive its SCK line configured as P0.06. Rearrange then the pins used in this sample, so that SCK is not on a pin involved in a GPIO loopback. Signed-off-by: Andrzej Głąbek <[email protected]> (cherry picked from commit 9c874f0)
Allow for an additional buffer reference if callback is provided. This can be used to extend lifetime of the net buffer until the data transmission is confirmed by ACK of the remote. Jira: NCSDK-27422 Signed-off-by: Marek Pieta <[email protected]>
By default, the BLE stack calls sent callback for ATT data when the data is passed to BLE controller for transmission. Enabling this Kconfig option delays calling the sent callback until data transmission is finished by BLE controller (the callback is delayed until receiving the num complete packets event). Jira: NCSDK-27422 Signed-off-by: Marek Pieta <[email protected]>
…d is enabled Change updates log level only if UART log backend is enabled in Kconfig configuration. The log level update is not needed in case logs are provided over other backend (e.g. RTT). Change affects both USB stacks. Upstream PR: zephyrproject-rtos/zephyr#74520 Signed-off-by: Marek Pieta <[email protected]>
…ith J-Links The nrfutil runner calls "nrfutil --json device list" which outputs information about all connected serial ports. The list includes not only actual boards but also any ttyACM instance. If the ttyACM instance does not have serial number, then the nrfutil runner will fail on matching serial number regexp on NoneType. Fix the issue by limiting nrfutil runner board output to only devices that have trait jlink set. Signed-off-by: Tomasz Moń <[email protected]> (cherry picked from commit e136f02)
…lized
drivers/serial/uart_async_to_irq.c: In function 'get_rx_timeout':
drivers/serial/uart_async_to_irq.c:51:26:
warning: 'cfg.baudrate' may be used uninitialized
51 | baudrate = cfg.baudrate;
| ~~~~~~~~~^~~~~~~~~~~~~~
drivers/serial/uart_async_to_irq.c:45:28: note: 'cfg' declared here
45 | struct uart_config cfg;
Upstream PR: zephyrproject-rtos/zephyr#74530
Signed-off-by: Piotr Kosycarz <[email protected]>
In order for the --recover option to work properly on the nRF54H20, it requires executing it for both cores, the radio and the application one. Extend the recover_target() function so that it does so for both 53 and 54H20. Upstream PR: zephyrproject-rtos/zephyr#74489 Signed-off-by: Carles Cufi <[email protected]>
This is implementation of ICBMsg endpoint deregistration. The underlying ICMsg instance and blocks are not affected by deregistration, so it is possible to reuse the same address during the re-registration of the same endpoint. Upstream PR: zephyrproject-rtos/zephyr#74243 Signed-off-by: Dominik Kilian <[email protected]>
Add API which checks if error interrupt is enabled by the user of the interrupt driven API. Upstream PR: zephyrproject-rtos/zephyr#74643 Signed-off-by: Krzysztof Chruściński <[email protected]>
Fix case when interrupt driven API did not enable error interrupt and error occurs. Previously in that case error state was kept so device remained in a state in which it was expecting higher layer to read and clear error state by calling uart_err_check(). If error interrupt is not enabled it will never occur and in that case error information shall be dropped. Upstream PR: zephyrproject-rtos/zephyr#74643 Signed-off-by: Krzysztof Chruściński <[email protected]>
NordicBuilder
requested review from
jaz1-nordic,
kl-cruz,
magp-nordic,
masz-nordic and
nika-nordic
|
cleared milestone too late for NCS 2.7.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
57 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Driver was expecting that interrupt driven API will call uart_err_check() soon after error is reported and was keeping error state until that happens and because of that it was not reporting new bytes. This is not always the case and if error interrupt is not enabled then error should be ignored.
Fixes NRFX-6032