[nrf noup] ci: Fix manifest-pr-skip #2086
Conversation
57300
force-pushed
the
fix-manifest-pr-skip
branch
6 times, most recently
from
d2c0cfd to
93e8101
Compare
fixup! [nrf noup] ci: Enable action-manifest-pr When the PR title or body contains "manifest-pr-skip", this action will cancel itself, which results in a failure status. Use the same condition to skip the whole workflow instead. Signed-off-by: Grzegorz Swiderski <[email protected]>
57300
force-pushed
the
fix-manifest-pr-skip
branch
from
93e8101 to
6cdd669
Compare
| if: > | ||
| !(contains(github.event.pull_request.title, 'manifest-pr-skip') || | ||
| contains(github.event.pull_request.body, 'manifest-pr-skip')) |
There was a problem hiding this comment.
Hopefully it works, but I don't know how to verify it in advance.
There was a problem hiding this comment.
Yes I would recommend changing action itself if cancelled status is causing problems. However I did not fully understand in which case cancelled becomes the problem? Idea in action side was roughly : success == manifest PR created, failure == failed to create manifest PR (when it should have been created) and cancelled == "neutral status" i.e. no need to create manifest PR.
There was a problem hiding this comment.
Updating the action itself sounds reasonable. I'm just unsure what's the best way to do it, seems to me like it could make the code more convoluted.
The only problem with the cancel is that it makes the PR red, which is misleading. It also shows up when filtering PRs by "status:failure". I think a code owner would still be able to merge it though, so I guess it's minor.
|
Resolved via nrfconnect/action-manifest-pr#13 |
5 participants
fixup! [nrf noup] ci: Enable action-manifest-pr
When the PR title or body contains "manifest-pr-skip", this action will cancel itself, which results in a failure status. Use the same condition to skip the whole workflow instead.