[nrf noup] mgmt: mcumgr: Fix nRF5340 network core hook #2728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de-nordic
reviewed
Apr 8, 2025
| { | ||
| if (image_index == NET_CORE_IMAGE) { | ||
| if (image_index == CONFIG_MCUBOOT_NETWORK_CORE_IMAGE_NUMBER) { | ||
| /* Pretend that primary slot of image 1 unpopulated */ |
Contributor
There was a problem hiding this comment.
Seems that comment here is not representing what the if does.
de-nordic
approved these changes
Apr 8, 2025
nordicjm
force-pushed
the
nrf5340hook
branch
3 times, most recently
from
de0ed4e to
01f8671
Compare
nvlsianpu
approved these changes
Apr 9, 2025
Fixes an issue whereby just enabling hooks would enable the nrf5340 network core hook despite lacking other requirements Signed-off-by: Jamie McCrae <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue whereby just enabling hooks would enable the nrf5340 network core hook despite lacking other requirements