[nrf fromlist] boards: nordic: nrf54h20dk: Fix FLASH_LOAD_SIZE #3001
Conversation
Fix FLASH_LOAD_SIZE setting for builds with !USE_DT_CODE_PARTITION (for e.g. with no MCUBoot). Having it wrongly set to 0x0 caused problems when running multiple images (radio core, application core) on the same board. Upstream PR #: 92191 Related: NCSIDB-1628 Signed-off-by: Michal Kozikowski <[email protected]>
nordic-mik7
force-pushed
the
dev/flash_load_size_fix_downstream
branch
from
ad0fdd2 to
8a66e15
Compare
|
| default 0x30000 if !USE_DT_CODE_PARTITION | ||
|
|
||
| config FLASH_LOAD_SIZE | ||
| default $(dt_chosen_reg_size_hex,$(DT_CHOSEN_Z_CODE_PARTITION)) if !USE_DT_CODE_PARTITION |
There was a problem hiding this comment.
This doesn't seem the right approach, rather a fixed value should be used.
I do not thing that anything from zephyr,code-partition should be used if !USE_DT_CODE_PARTITION
Let's say you have flash start at 2c000, and zephyr-code-partition and 3c000 - than the zephyr-code-partition would be smaller than the actual available size
There was a problem hiding this comment.
doesn't FLASH_LOAD_SIZE indicate the code parition in fact ? why should we include the rest of available flash in it ?
|
Closing this PR as a result of conversation with @ahasztag. Please see upstream PR comment : zephyrproject-rtos/zephyr#92191 (comment) |
2 participants
Fix FLASH_LOAD_SIZE setting for builds with !USE_DT_CODE_PARTITION (for e.g. with no MCUBoot).
Having it wrongly set to 0x0 caused problems when running multiple images (radio core, application core) on the same board.
Upstream PR #: 92191
Related: NCSIDB-1628