Skip to content

Commit 95a0b73

Browse files
chore(nx-cloud): skip serviceAccountName if create is false
1 parent af000a5 commit 95a0b73

File tree

6 files changed

+9
-96
lines changed

6 files changed

+9
-96
lines changed

charts/nx-cloud/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ apiVersion: v2
22
name: nx-cloud
33
description: Nx Cloud Helm Chart
44
type: application
5-
version: 1.2.0-rc1
5+
version: 1.2.0-rc2
66
maintainers:
77
- name: nx
88
url: "https://nx.app/"

charts/nx-cloud/ci/existing-serviceaccount-values.yaml

Lines changed: 0 additions & 95 deletions
This file was deleted.

charts/nx-cloud/templates/aggregator/cronjob.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,9 @@ spec:
2626
{{- toYaml . | nindent 12 }}
2727
{{- end }}
2828
spec:
29+
{{- if .Values.aggregator.serviceAccount.create }}
2930
serviceAccountName: {{ .Values.aggregator.serviceAccount.name }}
31+
{{- end }}
3032
{{- with .Values.aggregator.cronjob.nodeSelector }}
3133
nodeSelector:
3234
{{- toYaml . | nindent 12 }}

charts/nx-cloud/templates/api/deployment.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,9 @@ spec:
3232
{{- toYaml . | nindent 8 }}
3333
{{- end }}
3434
spec:
35+
{{- if .Values.api.serviceAccount.create }}
3536
serviceAccountName: {{ .Values.api.serviceAccount.name }}
37+
{{- end }}
3638
{{- if or .Values.config.agentConfigs .Values.api.deployment.volumes }}
3739
volumes:
3840
{{- if .Values.config.agentConfigs }}

charts/nx-cloud/templates/file-server/deployment.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,9 @@ spec:
3232
{{- toYaml . | nindent 8 }}
3333
{{- end }}
3434
spec:
35+
{{- if .Values.fileServer.serviceAccount.create }}
3536
serviceAccountName: {{ .Values.fileServer.serviceAccount.name }}
37+
{{- end }}
3638
{{- if .Values.fileServer.deployment.securityContext }}
3739
securityContext: {{- toYaml .Values.fileServer.deployment.securityContext | nindent 8 }}
3840
{{- end }}

charts/nx-cloud/templates/frontend/deployment.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,9 @@ spec:
3535
{{- toYaml . | nindent 8 }}
3636
{{- end }}
3737
spec:
38+
{{- if .Values.frontend.serviceAccount.create }}
3839
serviceAccountName: {{ .Values.frontend.serviceAccount.name }}
40+
{{- end }}
3941
{{- if .Values.frontend.deployment.volumes }}
4042
volumes:
4143
{{- toYaml .Values.frontend.deployment.volumes | nindent 8 }}

0 commit comments

Comments
 (0)