From 6194558aefa5e26a62a070d38ef3c9e466ef35eb Mon Sep 17 00:00:00 2001 From: Max Kless Date: Mon, 10 Nov 2025 17:30:26 +0100 Subject: [PATCH 1/3] test(nxls): update nxls e2es to run vs 22.0.2 --- apps/nxls-e2e/src/generators/generator-options.default.test.ts | 1 - libs/shared/e2e-utils/src/lib/utils.ts | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/apps/nxls-e2e/src/generators/generator-options.default.test.ts b/apps/nxls-e2e/src/generators/generator-options.default.test.ts index f8d4643431..7a612968d2 100644 --- a/apps/nxls-e2e/src/generators/generator-options.default.test.ts +++ b/apps/nxls-e2e/src/generators/generator-options.default.test.ts @@ -78,7 +78,6 @@ describe('generator options', () => { 'skipTsConfig', 'buildable', 'compiler', - 'simpleName', ]); }); diff --git a/libs/shared/e2e-utils/src/lib/utils.ts b/libs/shared/e2e-utils/src/lib/utils.ts index 836ff16d32..1108e65a2e 100644 --- a/libs/shared/e2e-utils/src/lib/utils.ts +++ b/libs/shared/e2e-utils/src/lib/utils.ts @@ -5,7 +5,7 @@ import { join } from 'node:path'; import { readJsonFile, workspaceRoot } from 'nx/src/devkit-exports'; export const defaultVersion = - process.env['NXLS_E2E_DEFAULT_VERSION'] ?? '21.3.0'; + process.env['NXLS_E2E_DEFAULT_VERSION'] ?? '22.0.2'; export const e2eCwd = join( process.platform === 'darwin' ? join('/', 'private', tmpdir()) : tmpdir(), From 6e9f35607f590c07f8fc8e385784ae254898643f Mon Sep 17 00:00:00 2001 From: Max Kless Date: Tue, 11 Nov 2025 10:21:19 +0100 Subject: [PATCH 2/3] update two more e2es --- .../nxls-e2e/src/completion/nx-json-completion-default.test.ts | 2 ++ .../parse-target-string/parse-target-string.default.test.ts | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/apps/nxls-e2e/src/completion/nx-json-completion-default.test.ts b/apps/nxls-e2e/src/completion/nx-json-completion-default.test.ts index 29fd9ad3ee..c371479748 100644 --- a/apps/nxls-e2e/src/completion/nx-json-completion-default.test.ts +++ b/apps/nxls-e2e/src/completion/nx-json-completion-default.test.ts @@ -82,6 +82,7 @@ describe('nx.json completion - default', () => { expect(completionItemStrings).toEqual([ '@nx/cypress/plugin', '@nx/eslint/plugin', + '@nx/rollup/plugin', '@nx/vite/plugin', ]); }); @@ -125,6 +126,7 @@ describe('nx.json completion - default', () => { "affected", "cacheDirectory", "cli", + "conformance", "defaultBase", "defaultProject", "extends", diff --git a/apps/nxls-e2e/src/parse-target-string/parse-target-string.default.test.ts b/apps/nxls-e2e/src/parse-target-string/parse-target-string.default.test.ts index 4057f07b60..c85be5963c 100644 --- a/apps/nxls-e2e/src/parse-target-string/parse-target-string.default.test.ts +++ b/apps/nxls-e2e/src/parse-target-string/parse-target-string.default.test.ts @@ -222,7 +222,8 @@ describe('parse target string - default', () => { expect(target.result as Target).toEqual({ project: projectName, - target: 'lint:ci', + target: 'lint', + configuration: 'ci', }); const target2 = await nxlsWrapper.sendRequest({ From a88f09c01e3f9b60efdf0957c965d3feba76fa44 Mon Sep 17 00:00:00 2001 From: Max Kless Date: Tue, 11 Nov 2025 13:05:50 +0100 Subject: [PATCH 3/3] add git info to linux ci --- .github/workflows/ci_checks.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/ci_checks.yml b/.github/workflows/ci_checks.yml index 241697a938..2bc1f45033 100644 --- a/.github/workflows/ci_checks.yml +++ b/.github/workflows/ci_checks.yml @@ -11,6 +11,10 @@ env: NX_CLOUD_ACCESS_TOKEN: ${{ secrets.NX_CLOUD_READ_WRITE_TOKEN }} NX_CLOUD_NO_TIMEOUTS: true NX_PLUGIN_NO_TIMEOUTS: true + GIT_AUTHOR_EMAIL: test@test.com + GIT_AUTHOR_NAME: Test + GIT_COMMITTER_EMAIL: test@test.com + GIT_COMMITTER_NAME: Test jobs: main-linux: