Skip to content

Commit 391d23c

Browse files
authored
chore(repo): re-enable e2e tests disabled by api-extractor issue (#34519)
## Current Behavior 14 e2e test suites were disabled (`xdescribe`) due to an ESM import issue in `@microsoft/api-extractor@7.57.0` (see qmhc/unplugin-dts#461). ## Expected Behavior With the upstream issue resolved, all 14 e2e test suites are re-enabled (`describe`) and should pass normally. ## Related Issue(s) Reverts #34516
1 parent 092cea6 commit 391d23c

14 files changed

+14
-42
lines changed

e2e/js/src/js-ts-solution.test.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,7 @@ import {
1111
updateJson,
1212
} from '@nx/e2e-utils';
1313

14-
// TODO: Re-enable once @microsoft/api-extractor ESM import issue is resolved
15-
// See: https://github.com/qmhc/unplugin-dts/issues/461
16-
xdescribe('JS - TS solution setup', () => {
14+
describe('JS - TS solution setup', () => {
1715
beforeAll(() => {
1816
newProject({
1917
packages: ['@nx/js'],

e2e/next/src/next-ts-solutions.test.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,7 @@ import {
99
updateFile,
1010
updateJson,
1111
} from '@nx/e2e-utils';
12-
// TODO: Re-enable once @microsoft/api-extractor ESM import issue is resolved
13-
// See: https://github.com/qmhc/unplugin-dts/issues/461
14-
xdescribe('Next TS Solutions', () => {
12+
describe('Next TS Solutions', () => {
1513
let proj: string;
1614

1715
beforeAll(() => {

e2e/react/src/react-ts-solution.test.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,7 @@ import {
1212
updateJson,
1313
} from '@nx/e2e-utils';
1414

15-
// TODO: Re-enable once @microsoft/api-extractor ESM import issue is resolved
16-
// See: https://github.com/qmhc/unplugin-dts/issues/461
17-
xdescribe('React (TS solution)', () => {
15+
describe('React (TS solution)', () => {
1816
let workspaceName: string;
1917

2018
beforeAll(() => {

e2e/react/src/react-vite.test.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,7 @@ import {
1111
uniq,
1212
} from '@nx/e2e-utils';
1313

14-
// TODO: Re-enable once @microsoft/api-extractor ESM import issue is resolved
15-
// See: https://github.com/qmhc/unplugin-dts/issues/461
16-
xdescribe('Build React applications and libraries with Vite', () => {
14+
describe('Build React applications and libraries with Vite', () => {
1715
beforeAll(() => {
1816
newProject({
1917
packages: ['@nx/react'],

e2e/release/src/release-publishable-libraries-ts-solution.test.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,7 @@ expect.addSnapshotSerializer({
4747
},
4848
});
4949

50-
// TODO: Re-enable once @microsoft/api-extractor ESM import issue is resolved
51-
// See: https://github.com/qmhc/unplugin-dts/issues/461
52-
xdescribe('release publishable libraries in workspace with ts solution setup', () => {
50+
describe('release publishable libraries in workspace with ts solution setup', () => {
5351
let e2eRegistryUrl: string;
5452

5553
beforeAll(async () => {

e2e/release/src/release-publishable-libraries.test.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,7 @@ expect.addSnapshotSerializer({
4949
},
5050
});
5151

52-
// TODO: Re-enable once @microsoft/api-extractor ESM import issue is resolved
53-
// See: https://github.com/qmhc/unplugin-dts/issues/461
54-
xdescribe('release publishable libraries', () => {
52+
describe('release publishable libraries', () => {
5553
let e2eRegistryUrl: string;
5654

5755
beforeAll(async () => {

e2e/storybook/src/storybook-nested.test.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,7 @@ import {
1313
import { writeFileSync } from 'fs';
1414
import { createFileSync } from 'fs-extra';
1515

16-
// TODO: Re-enable once @microsoft/api-extractor ESM import issue is resolved
17-
// See: https://github.com/qmhc/unplugin-dts/issues/461
18-
xdescribe('Storybook generators and executors for standalone workspaces - using React + Vite', () => {
16+
describe('Storybook generators and executors for standalone workspaces - using React + Vite', () => {
1917
const appName = uniq('react');
2018

2119
beforeAll(() => {

e2e/vite/src/vite-legacy.test.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,7 @@ import {
2626
import { join } from 'path';
2727
import { ChildProcess } from 'child_process';
2828

29-
// TODO: Re-enable once @microsoft/api-extractor ESM import issue is resolved
30-
// See: https://github.com/qmhc/unplugin-dts/issues/461
31-
xdescribe('Vite Plugin', () => {
29+
describe('Vite Plugin', () => {
3230
let proj: string;
3331
let originalEnv: string;
3432
beforeAll(() => {

e2e/vite/src/vite-ts-solution.test.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,7 @@ import {
1111
updateJson,
1212
} from '@nx/e2e-utils';
1313

14-
// TODO: Re-enable once @microsoft/api-extractor ESM import issue is resolved
15-
// See: https://github.com/qmhc/unplugin-dts/issues/461
16-
xdescribe('Vite - TS solution setup', () => {
14+
describe('Vite - TS solution setup', () => {
1715
beforeAll(() => {
1816
newProject({
1917
packages: ['@nx/react', '@nx/js'],

e2e/vite/src/vite.test.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,7 @@ import { names } from '@nx/devkit';
1515
const myApp = uniq('my-app');
1616
const myVueApp = uniq('my-vue-app');
1717

18-
// TODO: Re-enable once @microsoft/api-extractor ESM import issue is resolved
19-
// See: https://github.com/qmhc/unplugin-dts/issues/461
20-
xdescribe('@nx/vite/plugin', () => {
18+
describe('@nx/vite/plugin', () => {
2119
let proj: string;
2220
let originalEnv: string;
2321
beforeAll(() => {

0 commit comments

Comments
 (0)