Skip to content

Commit 6ee7091

Browse files
authored
Revert "feat(js): add deps-sync generator (#34407)" (#34888)
This reverts commit 8d71d5b. ## Current Behavior <!-- This is the behavior we have today --> This generator causes unnecessary changes ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> The generator is removed for now and will be reintroduced when it is refined. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #
1 parent d6f22a2 commit 6ee7091

File tree

21 files changed

+22
-640
lines changed

21 files changed

+22
-640
lines changed

astro-docs/src/content/docs/concepts/sync-generators.mdoc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ In CI, the sync generator is run in `--dry-run` mode and if files would be chang
4242
"$schema": "packages/nx/schemas/nx-schema.json",
4343
...
4444
"sync": {
45-
"disabledTaskSyncGenerators": ["@nx/js:typescript-sync", "@nx/js:deps-sync"]
45+
"disabledTaskSyncGenerators": ["@nx/js:typescript-sync"]
4646
}
4747
}
4848

@@ -54,7 +54,7 @@ Use the project details view to **find registered sync generators** for a given
5454
nx show project <name>
5555
```
5656

57-
The above command opens up the project details view, and the registered sync generators are under the **Sync Generators** for each target. Most sync generators are inferred when using an [inference plugin](/docs/concepts/inferred-tasks). For example, the `@nx/js/typescript` plugin registers the `@nx/js:typescript-sync` and `@nx/js:deps-sync` generators on `build` and `typecheck` targets.
57+
The above command opens up the project details view, and the registered sync generators are under the **Sync Generators** for each target. Most sync generators are inferred when using an [inference plugin](/docs/concepts/inferred-tasks). For example, the `@nx/js/typescript` plugin registers the `@nx/js:typescript-sync` generator on `build` and `typecheck` targets.
5858

5959
{% project_details title="Project Details View" expandedTargets=["build"] %}
6060

@@ -75,7 +75,7 @@ The above command opens up the project details view, and the registered sync gen
7575
"{projectRoot}/src/**/*.ts"
7676
],
7777
"outputs": ["{workspaceRoot}/packages/foo/dist"],
78-
"syncGenerators": ["@nx/js:typescript-sync", "@nx/js:deps-sync"],
78+
"syncGenerators": ["@nx/js:typescript-sync"],
7979
"executor": "nx:run-commands",
8080
"options": {
8181
"command": "tsc --build tsconfig.lib.json --pretty --verbose"

graph/ui-project-details/src/lib/project-details/project-details.stories.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,6 @@ export const Primary = {
8585
configurations: {},
8686
syncGenerators: [
8787
'@nx/js:typescript-sync',
88-
'@nx/js:deps-sync',
8988
'@foo/bar:sync',
9089
'@baz/qux:sync',
9190
],

packages/js/generators.json

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -43,12 +43,6 @@
4343
"alias": ["sync"],
4444
"hidden": true
4545
},
46-
"deps-sync": {
47-
"factory": "./src/generators/deps-sync/deps-sync",
48-
"schema": "./src/generators/deps-sync/schema.json",
49-
"description": "Synchronize package.json dependencies for internal packages based on the project graph.",
50-
"hidden": true
51-
},
5246
"setup-prettier": {
5347
"factory": "./src/generators/setup-prettier/generator",
5448
"schema": "./src/generators/setup-prettier/schema.json",

packages/js/src/generators/deps-sync/deps-sync.spec.ts

Lines changed: 0 additions & 298 deletions
This file was deleted.

0 commit comments

Comments
 (0)