fix(core): remove windowsHide from fork() calls where it is not typed

FrozenPandaz · claude · FrozenPandaz · commit b6f768844f53 · 2026-03-18T11:32:49.000-04:00
ForkOptions in @types/node does not include windowsHide, causing
typecheck failures. Since fork() spawns Node.js processes (not
shell commands), there is no console window to hide on Windows.

Co-Authored-By: Claude Opus 4.6 (1M context) &lt;noreply@anthropic.com&gt;
diff --git a/astro-docs/src/plugins/utils/cnw-generation.ts b/astro-docs/src/plugins/utils/cnw-generation.ts
@@ -40,7 +40,6 @@ export async function loadCnwPackage(
     const child = fork(subprocessPath, [], {
       cwd: workspaceRoot,
       silent: true,
-      windowsHide: true,
     });
 
     let stdout = '';
diff --git a/packages/detox/src/executors/build/build.impl.ts b/packages/detox/src/executors/build/build.impl.ts
@@ -41,7 +41,6 @@ export function runCliBuild(
       {
         cwd: pathResolve(workspaceRoot, projectRoot),
         env: process.env,
-        windowsHide: true,
       }
     );
 
diff --git a/packages/detox/src/executors/test/test.impl.ts b/packages/detox/src/executors/test/test.impl.ts
@@ -62,7 +62,6 @@ function runCliTest(
       {
         cwd: pathResolve(workspaceRoot, projectRoot),
         env: process.env,
-        windowsHide: true,
       }
     );
 
diff --git a/packages/docker/src/release/version-utils.ts b/packages/docker/src/release/version-utils.ts
@@ -125,7 +125,9 @@ function updateProjectVersion(
   const fullImageRef =
     nxDockerImageRefEnvOverride ?? `${newImageRef}:${newVersion}`;
   if (!isDryRun) {
-    execSync(`docker tag ${imageRef} ${fullImageRef}`);
+    execSync(`docker tag ${imageRef} ${fullImageRef}`, {
+      windowsHide: true,
+    });
   }
   const logs = isDryRun
     ? [`Image would be tagged with ${fullImageRef} but dry run is enabled.`]
diff --git a/packages/expo/src/executors/build-list/build-list.impl.ts b/packages/expo/src/executors/build-list/build-list.impl.ts
@@ -48,7 +48,6 @@ export function runCliBuildList(
         cwd: pathResolve(workspaceRoot, projectRoot),
         env: process.env,
         stdio: ['inherit', 'pipe', 'inherit', 'ipc'], // only stream stdout on child process
-        windowsHide: true,
       }
     );
 
diff --git a/packages/expo/src/executors/build/build.impl.ts b/packages/expo/src/executors/build/build.impl.ts
@@ -65,7 +65,6 @@ function runCliBuild(
           ...(options.local ? { YARN_ENABLE_IMMUTABLE_INSTALLS: 'false' } : {}),
           ...process.env,
         },
-        windowsHide: true,
       }
     );
 
diff --git a/packages/expo/src/executors/export/export.impl.ts b/packages/expo/src/executors/export/export.impl.ts
@@ -47,7 +47,6 @@ function exportAsync(
       {
         cwd: pathResolve(workspaceRoot, projectRoot),
         env: process.env,
-        windowsHide: true,
       }
     );
 
diff --git a/packages/expo/src/executors/prebuild/prebuild.impl.ts b/packages/expo/src/executors/prebuild/prebuild.impl.ts
@@ -54,7 +54,6 @@ export function prebuildAsync(
       {
         cwd: join(workspaceRoot, projectRoot),
         env: process.env,
-        windowsHide: true,
       }
     );
 
diff --git a/packages/expo/src/executors/run/run.impl.ts b/packages/expo/src/executors/run/run.impl.ts
@@ -66,7 +66,6 @@ function runCliRun(
       {
         cwd: pathResolve(workspaceRoot, projectRoot),
         env: process.env,
-        windowsHide: true,
       }
     );
 
diff --git a/packages/expo/src/executors/serve/serve.impl.ts b/packages/expo/src/executors/serve/serve.impl.ts
@@ -80,7 +80,6 @@ function serveAsync(
         cwd: pathResolve(workspaceRoot, projectRoot),
         env: process.env,
         stdio: ['inherit', 'pipe', 'pipe', 'ipc'],
-        windowsHide: true,
       }
     );
 
diff --git a/packages/expo/src/executors/start/start.impl.ts b/packages/expo/src/executors/start/start.impl.ts
@@ -52,7 +52,6 @@ function startAsync(
           RCT_METRO_PORT: options.port.toString(),
           ...process.env,
         },
-        windowsHide: true,
       }
     );
 
diff --git a/packages/expo/src/executors/submit/submit.impl.ts b/packages/expo/src/executors/submit/submit.impl.ts
@@ -43,7 +43,6 @@ function runCliSubmit(
       {
         cwd: pathResolve(workspaceRoot, projectRoot),
         env: process.env,
-        windowsHide: true,
       }
     );
 
diff --git a/packages/expo/src/executors/update/update.impl.ts b/packages/expo/src/executors/update/update.impl.ts
@@ -46,7 +46,6 @@ function runCliUpdate(
       {
         cwd: pathResolve(workspaceRoot, projectRoot),
         env: process.env,
-        windowsHide: true,
       }
     );
 
diff --git a/packages/js/src/executors/node/node.impl.ts b/packages/js/src/executors/node/node.impl.ts
@@ -190,7 +190,6 @@ export async function* nodeExecutor(
                   NX_FILE_TO_RUN: fileToRunCorrectPath(fileToRun),
                   NX_MAPPINGS: JSON.stringify(mappings),
                 },
-                windowsHide: true,
               }
             );
 
@@ -307,7 +306,6 @@ export async function* nodeExecutor(
             {
               cwd: context.root,
               stdio: 'inherit',
-              windowsHide: true,
             }
           );
           childProcess.once('exit', (code) => {
diff --git a/packages/js/src/executors/verdaccio/verdaccio.impl.ts b/packages/js/src/executors/verdaccio/verdaccio.impl.ts
@@ -97,7 +97,6 @@ function startVerdaccio(
             : {}),
         },
         stdio: 'inherit',
-        windowsHide: true,
       }
     );
 
diff --git a/packages/js/src/plugins/jest/start-local-registry.ts b/packages/js/src/plugins/jest/start-local-registry.ts
@@ -35,7 +35,7 @@ export function startLocalRegistry({
         }`.split(' '),
         ...(storage ? [`--storage`, storage] : []),
       ],
-      { stdio: 'pipe', windowsHide: true }
+      { stdio: 'pipe' }
     );
 
     const listener = (data) => {
diff --git a/packages/next/src/executors/build/build.impl.ts b/packages/next/src/executors/build/build.impl.ts
@@ -195,7 +195,6 @@ function runCliBuild(
         cwd: pathResolve(workspaceRoot, projectRoot),
         stdio: ['ignore', 'inherit', 'inherit', 'ipc'],
         env: process.env,
-        windowsHide: true,
       }
     );
 
diff --git a/packages/next/src/executors/server/server.impl.ts b/packages/next/src/executors/server/server.impl.ts
@@ -107,7 +107,6 @@ export default async function* serveExecutor(
         {
           cwd: options.dev ? projectRoot : nextDir,
           stdio: 'inherit',
-          windowsHide: true,
         }
       );
 
diff --git a/packages/nx/src/plugins/js/lock-file/lock-file.ts b/packages/nx/src/plugins/js/lock-file/lock-file.ts
@@ -242,7 +242,9 @@ export function getLockFilePath(packageManager: PackageManager): string {
         return BUN_LOCK_PATH;
       }
 
-      const bunVersion = execSync('bun --version').toString().trim();
+      const bunVersion = execSync('bun --version', { windowsHide: true })
+        .toString()
+        .trim();
       // Version-based fallback
       if (gte(bunVersion, '1.2.0')) {
         return BUN_TEXT_LOCK_PATH;
diff --git a/packages/nx/src/project-graph/file-utils.ts b/packages/nx/src/project-graph/file-utils.ts
@@ -97,7 +97,9 @@ function defaultReadFileAtRevision(
 ): string {
   try {
     const fileFullPath = `${workspaceRoot}${sep}${file}`;
-    const gitRepositoryPath = execSync('git rev-parse --show-toplevel')
+    const gitRepositoryPath = execSync('git rev-parse --show-toplevel', {
+      windowsHide: true,
+    })
       .toString()
       .trim();
     const filePathInGitRepository = relative(gitRepositoryPath, fileFullPath)
diff --git a/packages/nx/src/tasks-runner/fork.ts b/packages/nx/src/tasks-runner/fork.ts
@@ -18,7 +18,6 @@ const childProcess = fork(script, {
   stdio: ['inherit', 'inherit', 'inherit', 'ipc'],
   env: process.env,
   execArgv,
-  windowsHide: true,
 });
 
 const pseudoIPC = new PseudoIPCClient(pseudoIPCPath);
diff --git a/packages/nx/src/tasks-runner/forked-process-task-runner.ts b/packages/nx/src/tasks-runner/forked-process-task-runner.ts
@@ -71,7 +71,6 @@ export class ForkedProcessTaskRunner {
         ...env,
         NX_FORKED_TASK_EXECUTOR: 'true',
       },
-      windowsHide: true,
     });
 
     // Register batch worker process with all tasks
@@ -218,7 +217,6 @@ export class ForkedProcessTaskRunner {
     const childId = task.id;
     const pseudoTerminal = await this.createPseudoTerminal();
     this.pseudoTerminals.add(pseudoTerminal);
-    // eslint-disable-next-line @nx/workspace/require-windows-hide -- this is the Rust pseudo-terminal fork, not child_process.fork
     const p = await pseudoTerminal.fork(childId, forkScript, {
       cwd: process.cwd(),
       execArgv: process.execArgv,
@@ -289,7 +287,6 @@ export class ForkedProcessTaskRunner {
           ...env,
           NX_FORKED_TASK_EXECUTOR: 'true',
         },
-        windowsHide: true,
       });
 
       // Register forked process for metrics collection
@@ -356,7 +353,6 @@ export class ForkedProcessTaskRunner {
           ...env,
           NX_FORKED_TASK_EXECUTOR: 'true',
         },
-        windowsHide: true,
       });
 
       // Register forked process for metrics collection
diff --git a/packages/nx/src/utils/analytics-prompt.ts b/packages/nx/src/utils/analytics-prompt.ts
@@ -111,6 +111,7 @@ export function generateWorkspaceId(cwd?: string): string | null {
     const remoteUrl = execSync('git remote get-url origin', {
       stdio: 'pipe',
       cwd: root,
+      windowsHide: true,
     })
       .toString()
       .trim();
@@ -127,6 +128,7 @@ export function generateWorkspaceId(cwd?: string): string | null {
     const firstCommit = execSync('git rev-list --max-parents=0 HEAD', {
       stdio: 'pipe',
       cwd: root,
+      windowsHide: true,
     })
       .toString()
       .trim()
diff --git a/packages/playwright/src/executors/playwright/playwright.impl.ts b/packages/playwright/src/executors/playwright/playwright.impl.ts
@@ -146,7 +146,6 @@ function runPlaywright(args: string[], cwd: string, env?: NodeJS.ProcessEnv) {
       stdio: ['pipe', 'pipe', 'pipe', 'ipc'],
       cwd,
       ...(env ? { env } : {}),
-      windowsHide: true,
     });
   } catch (e) {
     console.error(e);
diff --git a/packages/react-native/src/executors/build-android/build-android.impl.ts b/packages/react-native/src/executors/build-android/build-android.impl.ts
@@ -35,7 +35,6 @@ function runCliBuild(
         stdio: 'inherit',
         cwd: pathResolve(workspaceRoot, projectRoot),
         env: { ...process.env, RCT_METRO_PORT: options.port.toString() },
-        windowsHide: true,
       }
     );
 
diff --git a/packages/react-native/src/executors/build-ios/build-ios.impl.ts b/packages/react-native/src/executors/build-ios/build-ios.impl.ts
@@ -41,7 +41,6 @@ function runCliBuildIOS(
       {
         cwd: pathResolve(workspaceRoot, projectRoot),
         env: { ...process.env, RCT_METRO_PORT: options.port.toString() },
-        windowsHide: true,
       }
     );
 
diff --git a/packages/react-native/src/executors/bundle/bundle.impl.ts b/packages/react-native/src/executors/bundle/bundle.impl.ts
@@ -39,7 +39,6 @@ function runCliBuild(
         stdio: 'inherit',
         cwd: pathResolve(workspaceRoot, projectRoot),
         env: process.env,
-        windowsHide: true,
       }
     );
 
diff --git a/packages/react-native/src/executors/run-android/run-android.impl.ts b/packages/react-native/src/executors/run-android/run-android.impl.ts
@@ -56,7 +56,6 @@ function runCliRunAndroid(
         stdio: 'inherit',
         cwd: pathResolve(workspaceRoot, projectRoot),
         env: { ...process.env, RCT_METRO_PORT: options.port.toString() },
-        windowsHide: true,
       }
     );
 
diff --git a/packages/react-native/src/executors/run-ios/run-ios.impl.ts b/packages/react-native/src/executors/run-ios/run-ios.impl.ts
@@ -56,7 +56,6 @@ function runCliRunIOS(
         stdio: 'inherit',
         cwd: pathResolve(workspaceRoot, projectRoot),
         env: { ...process.env, RCT_METRO_PORT: options.port.toString() },
-        windowsHide: true,
       }
     );
 
diff --git a/packages/react-native/src/executors/start/start.impl.ts b/packages/react-native/src/executors/start/start.impl.ts
@@ -69,7 +69,6 @@ function startAsync(
         cwd: pathResolve(workspaceRoot, projectRoot),
         env: process.env,
         stdio: 'inherit',
-        windowsHide: true,
       }
     );
 
diff --git a/packages/react-native/src/executors/upgrade/upgrade.impl.ts b/packages/react-native/src/executors/upgrade/upgrade.impl.ts
@@ -36,7 +36,6 @@ export function runCliUpgrade(
         stdio: 'inherit',
         cwd: pathResolve(workspaceRoot, projectRoot),
         env: process.env,
-        windowsHide: true,
       }
     );
 
diff --git a/packages/remix/src/executors/build/build.impl.ts b/packages/remix/src/executors/build/build.impl.ts
@@ -34,7 +34,6 @@ async function runBuild(
     const p = fork(remixBin, args, {
       cwd: join(context.root, projectRoot),
       stdio: 'inherit',
-      windowsHide: true,
     });
     p.on('exit', (code) => {
       if (code === 0) resolve();
diff --git a/packages/remix/src/executors/serve/serve.impl.ts b/packages/remix/src/executors/serve/serve.impl.ts
@@ -65,7 +65,6 @@ export default async function* serveExecutor(
       const server = fork(remixBin, ['dev', ...args], {
         cwd: join(workspaceRoot, projectRoot),
         stdio: 'inherit',
-        windowsHide: true,
       });
 
       server.once('exit', (code) => {
diff --git a/packages/web/src/executors/file-server/file-server.impl.ts b/packages/web/src/executors/file-server/file-server.impl.ts
@@ -246,7 +246,6 @@ export default async function* fileServerExecutor(
       FORCE_COLOR: 'true',
       ...process.env,
     },
-    windowsHide: true,
   });
 
   const processExitListener = () => {
diff --git a/tools/eslint-rules/rules/require-windows-hide.spec.ts b/tools/eslint-rules/rules/require-windows-hide.spec.ts
@@ -10,9 +10,6 @@ ruleTester.run(RULE_NAME, rule, {
     // spawn with windowsHide: true
     `import { spawn } from 'child_process';
      spawn('echo', ['hello'], { stdio: 'inherit', windowsHide: true });`,
-    // fork with windowsHide: true
-    `import { fork } from 'child_process';
-     fork('script.js', { stdio: 'inherit', windowsHide: true });`,
     // execSync with windowsHide: true
     `import { execSync } from 'child_process';
      execSync('echo hello', { windowsHide: true });`,
@@ -21,6 +18,10 @@ ruleTester.run(RULE_NAME, rule, {
      spawnSync('echo', ['hello'], { windowsHide: true });`,
     // Not a spawn function, should not report
     `someOtherFunction({ stdio: 'inherit' });`,
+    // Variable as last arg (could be options) - skip
+    `import { spawn } from 'child_process';
+     const opts = { windowsHide: true };
+     spawn('echo', ['hello'], opts);`,
     // Test file should be ignored
     {
       code: `import { spawn } from 'child_process';
@@ -41,16 +42,23 @@ ruleTester.run(RULE_NAME, rule, {
              spawn('echo', ['hello'], { stdio: 'inherit', windowsHide: false });`,
       errors: [{ messageId: 'windowsHideMustBeTrue' }],
     },
-    // fork missing windowsHide
+    // execSync missing windowsHide
     {
-      code: `import { fork } from 'child_process';
-             fork('script.js', { stdio: ['inherit', 'pipe', 'pipe', 'ipc'] });`,
+      code: `import { execSync } from 'child_process';
+             execSync('echo hello', { encoding: 'utf-8' });`,
       errors: [{ messageId: 'missingWindowsHide' }],
     },
-    // execSync missing windowsHide
+    // execSync with no options at all
     {
       code: `import { execSync } from 'child_process';
-             execSync('echo hello', { encoding: 'utf-8' });`,
+             execSync('echo hello');`,
+      errors: [{ messageId: 'missingWindowsHide' }],
+    },
+    // spawn with variable command but no options
+    {
+      code: `import { spawn } from 'child_process';
+             const cmd = 'echo';
+             spawn(cmd, ['hello']);`,
       errors: [{ messageId: 'missingWindowsHide' }],
     },
     // Member expression: child_process.spawn
diff --git a/tools/eslint-rules/rules/require-windows-hide.ts b/tools/eslint-rules/rules/require-windows-hide.ts

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,6 @@ export function runCliBuild(`
`41`	`41`	`{`
`42`	`42`	`cwd: pathResolve(workspaceRoot, projectRoot),`
`43`	`43`	`env: process.env,`
`44`		`- windowsHide: true,`
`45`	`44`	`}`
`46`	`45`	`);`
`47`	`46`
Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,6 @@ function runCliTest(`
`62`	`62`	`{`
`63`	`63`	`cwd: pathResolve(workspaceRoot, projectRoot),`
`64`	`64`	`env: process.env,`
`65`		`- windowsHide: true,`
`66`	`65`	`}`
`67`	`66`	`);`
`68`	`67`
Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,6 @@ export function runCliBuildList(`
`48`	`48`	`cwd: pathResolve(workspaceRoot, projectRoot),`
`49`	`49`	`env: process.env,`
`50`	`50`	`stdio: ['inherit', 'pipe', 'inherit', 'ipc'], // only stream stdout on child process`
`51`		`- windowsHide: true,`
`52`	`51`	`}`
`53`	`52`	`);`
`54`	`53`
Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,6 @@ function runCliBuild(`
`65`	`65`	`...(options.local ? { YARN_ENABLE_IMMUTABLE_INSTALLS: 'false' } : {}),`
`66`	`66`	`...process.env,`
`67`	`67`	`},`
`68`		`- windowsHide: true,`
`69`	`68`	`}`
`70`	`69`	`);`
`71`	`70`
Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,6 @@ function exportAsync(`
`47`	`47`	`{`
`48`	`48`	`cwd: pathResolve(workspaceRoot, projectRoot),`
`49`	`49`	`env: process.env,`
`50`		`- windowsHide: true,`
`51`	`50`	`}`
`52`	`51`	`);`
`53`	`52`
Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,6 @@ export function prebuildAsync(`
`54`	`54`	`{`
`55`	`55`	`cwd: join(workspaceRoot, projectRoot),`
`56`	`56`	`env: process.env,`
`57`		`- windowsHide: true,`
`58`	`57`	`}`
`59`	`58`	`);`
`60`	`59`
Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,6 @@ function runCliRun(`
`66`	`66`	`{`
`67`	`67`	`cwd: pathResolve(workspaceRoot, projectRoot),`
`68`	`68`	`env: process.env,`
`69`		`- windowsHide: true,`
`70`	`69`	`}`
`71`	`70`	`);`
`72`	`71`
Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,6 @@ function serveAsync(`
`80`	`80`	`cwd: pathResolve(workspaceRoot, projectRoot),`
`81`	`81`	`env: process.env,`
`82`	`82`	`stdio: ['inherit', 'pipe', 'pipe', 'ipc'],`
`83`		`- windowsHide: true,`
`84`	`83`	`}`
`85`	`84`	`);`
`86`	`85`