fix(core): remove windowsHide from fork() calls where it is not typed

FrozenPandaz · claude · FrozenPandaz · commit dac84abf304f · 2026-03-18T11:05:45.000-04:00
ForkOptions in @types/node does not include windowsHide, causing
typecheck failures. Since fork() spawns Node.js processes (not
shell commands), there is no console window to hide on Windows.

Co-Authored-By: Claude Opus 4.6 (1M context) &lt;noreply@anthropic.com&gt;
diff --git a/astro-docs/src/plugins/utils/cnw-generation.ts b/astro-docs/src/plugins/utils/cnw-generation.ts
@@ -40,7 +40,6 @@ export async function loadCnwPackage(
     const child = fork(subprocessPath, [], {
       cwd: workspaceRoot,
       silent: true,
-      windowsHide: true,
     });
 
     let stdout = '';
diff --git a/packages/docker/src/release/version-utils.ts b/packages/docker/src/release/version-utils.ts
@@ -125,7 +125,9 @@ function updateProjectVersion(
   const fullImageRef =
     nxDockerImageRefEnvOverride ?? `${newImageRef}:${newVersion}`;
   if (!isDryRun) {
-    execSync(`docker tag ${imageRef} ${fullImageRef}`);
+    execSync(`docker tag ${imageRef} ${fullImageRef}`, {
+      windowsHide: true,
+    });
   }
   const logs = isDryRun
     ? [`Image would be tagged with ${fullImageRef} but dry run is enabled.`]
diff --git a/packages/expo/src/executors/export/export.impl.ts b/packages/expo/src/executors/export/export.impl.ts
@@ -47,7 +47,6 @@ function exportAsync(
       {
         cwd: pathResolve(workspaceRoot, projectRoot),
         env: process.env,
-        windowsHide: true,
       }
     );
 
diff --git a/packages/expo/src/executors/prebuild/prebuild.impl.ts b/packages/expo/src/executors/prebuild/prebuild.impl.ts
@@ -54,7 +54,6 @@ export function prebuildAsync(
       {
         cwd: join(workspaceRoot, projectRoot),
         env: process.env,
-        windowsHide: true,
       }
     );
 
diff --git a/packages/expo/src/executors/update/update.impl.ts b/packages/expo/src/executors/update/update.impl.ts
@@ -46,7 +46,6 @@ function runCliUpdate(
       {
         cwd: pathResolve(workspaceRoot, projectRoot),
         env: process.env,
-        windowsHide: true,
       }
     );
 
diff --git a/packages/js/src/executors/node/node.impl.ts b/packages/js/src/executors/node/node.impl.ts
@@ -190,7 +190,6 @@ export async function* nodeExecutor(
                   NX_FILE_TO_RUN: fileToRunCorrectPath(fileToRun),
                   NX_MAPPINGS: JSON.stringify(mappings),
                 },
-                windowsHide: true,
               }
             );
 
@@ -307,7 +306,6 @@ export async function* nodeExecutor(
             {
               cwd: context.root,
               stdio: 'inherit',
-              windowsHide: true,
             }
           );
           childProcess.once('exit', (code) => {
diff --git a/packages/js/src/executors/verdaccio/verdaccio.impl.ts b/packages/js/src/executors/verdaccio/verdaccio.impl.ts
@@ -97,7 +97,6 @@ function startVerdaccio(
             : {}),
         },
         stdio: 'inherit',
-        windowsHide: true,
       }
     );
 
diff --git a/packages/js/src/plugins/jest/start-local-registry.ts b/packages/js/src/plugins/jest/start-local-registry.ts
@@ -35,7 +35,7 @@ export function startLocalRegistry({
         }`.split(' '),
         ...(storage ? [`--storage`, storage] : []),
       ],
-      { stdio: 'pipe', windowsHide: true }
+      { stdio: 'pipe' }
     );
 
     const listener = (data) => {
diff --git a/packages/nx/src/plugins/js/lock-file/lock-file.ts b/packages/nx/src/plugins/js/lock-file/lock-file.ts
@@ -242,7 +242,9 @@ export function getLockFilePath(packageManager: PackageManager): string {
         return BUN_LOCK_PATH;
       }
 
-      const bunVersion = execSync('bun --version').toString().trim();
+      const bunVersion = execSync('bun --version', { windowsHide: true })
+        .toString()
+        .trim();
       // Version-based fallback
       if (gte(bunVersion, '1.2.0')) {
         return BUN_TEXT_LOCK_PATH;
diff --git a/packages/nx/src/project-graph/file-utils.ts b/packages/nx/src/project-graph/file-utils.ts
@@ -97,7 +97,9 @@ function defaultReadFileAtRevision(
 ): string {
   try {
     const fileFullPath = `${workspaceRoot}${sep}${file}`;
-    const gitRepositoryPath = execSync('git rev-parse --show-toplevel')
+    const gitRepositoryPath = execSync('git rev-parse --show-toplevel', {
+      windowsHide: true,
+    })
       .toString()
       .trim();
     const filePathInGitRepository = relative(gitRepositoryPath, fileFullPath)
diff --git a/packages/nx/src/tasks-runner/fork.ts b/packages/nx/src/tasks-runner/fork.ts
@@ -18,7 +18,6 @@ const childProcess = fork(script, {
   stdio: ['inherit', 'inherit', 'inherit', 'ipc'],
   env: process.env,
   execArgv,
-  windowsHide: true,
 });
 
 const pseudoIPC = new PseudoIPCClient(pseudoIPCPath);
diff --git a/packages/nx/src/tasks-runner/forked-process-task-runner.ts b/packages/nx/src/tasks-runner/forked-process-task-runner.ts
@@ -71,7 +71,6 @@ export class ForkedProcessTaskRunner {
         ...env,
         NX_FORKED_TASK_EXECUTOR: 'true',
       },
-      windowsHide: true,
     });
 
     // Register batch worker process with all tasks
@@ -218,7 +217,6 @@ export class ForkedProcessTaskRunner {
     const childId = task.id;
     const pseudoTerminal = await this.createPseudoTerminal();
     this.pseudoTerminals.add(pseudoTerminal);
-    // eslint-disable-next-line @nx/workspace/require-windows-hide -- this is the Rust pseudo-terminal fork, not child_process.fork
     const p = await pseudoTerminal.fork(childId, forkScript, {
       cwd: process.cwd(),
       execArgv: process.execArgv,
@@ -289,7 +287,6 @@ export class ForkedProcessTaskRunner {
           ...env,
           NX_FORKED_TASK_EXECUTOR: 'true',
         },
-        windowsHide: true,
       });
 
       // Register forked process for metrics collection
@@ -356,7 +353,6 @@ export class ForkedProcessTaskRunner {
           ...env,
           NX_FORKED_TASK_EXECUTOR: 'true',
         },
-        windowsHide: true,
       });
 
       // Register forked process for metrics collection
diff --git a/packages/nx/src/utils/analytics-prompt.ts b/packages/nx/src/utils/analytics-prompt.ts
@@ -111,6 +111,7 @@ export function generateWorkspaceId(cwd?: string): string | null {
     const remoteUrl = execSync('git remote get-url origin', {
       stdio: 'pipe',
       cwd: root,
+      windowsHide: true,
     })
       .toString()
       .trim();
@@ -127,6 +128,7 @@ export function generateWorkspaceId(cwd?: string): string | null {
     const firstCommit = execSync('git rev-list --max-parents=0 HEAD', {
       stdio: 'pipe',
       cwd: root,
+      windowsHide: true,
     })
       .toString()
       .trim()
diff --git a/packages/remix/src/executors/build/build.impl.ts b/packages/remix/src/executors/build/build.impl.ts
@@ -34,7 +34,6 @@ async function runBuild(
     const p = fork(remixBin, args, {
       cwd: join(context.root, projectRoot),
       stdio: 'inherit',
-      windowsHide: true,
     });
     p.on('exit', (code) => {
       if (code === 0) resolve();
diff --git a/packages/remix/src/executors/serve/serve.impl.ts b/packages/remix/src/executors/serve/serve.impl.ts
@@ -65,7 +65,6 @@ export default async function* serveExecutor(
       const server = fork(remixBin, ['dev', ...args], {
         cwd: join(workspaceRoot, projectRoot),
         stdio: 'inherit',
-        windowsHide: true,
       });
 
       server.once('exit', (code) => {
diff --git a/tools/eslint-rules/rules/require-windows-hide.spec.ts b/tools/eslint-rules/rules/require-windows-hide.spec.ts
@@ -10,9 +10,6 @@ ruleTester.run(RULE_NAME, rule, {
     // spawn with windowsHide: true
     `import { spawn } from 'child_process';
      spawn('echo', ['hello'], { stdio: 'inherit', windowsHide: true });`,
-    // fork with windowsHide: true
-    `import { fork } from 'child_process';
-     fork('script.js', { stdio: 'inherit', windowsHide: true });`,
     // execSync with windowsHide: true
     `import { execSync } from 'child_process';
      execSync('echo hello', { windowsHide: true });`,
@@ -21,6 +18,10 @@ ruleTester.run(RULE_NAME, rule, {
      spawnSync('echo', ['hello'], { windowsHide: true });`,
     // Not a spawn function, should not report
     `someOtherFunction({ stdio: 'inherit' });`,
+    // Variable as last arg (could be options) - skip
+    `import { spawn } from 'child_process';
+     const opts = { windowsHide: true };
+     spawn('echo', ['hello'], opts);`,
     // Test file should be ignored
     {
       code: `import { spawn } from 'child_process';
@@ -41,16 +42,23 @@ ruleTester.run(RULE_NAME, rule, {
              spawn('echo', ['hello'], { stdio: 'inherit', windowsHide: false });`,
       errors: [{ messageId: 'windowsHideMustBeTrue' }],
     },
-    // fork missing windowsHide
+    // execSync missing windowsHide
     {
-      code: `import { fork } from 'child_process';
-             fork('script.js', { stdio: ['inherit', 'pipe', 'pipe', 'ipc'] });`,
+      code: `import { execSync } from 'child_process';
+             execSync('echo hello', { encoding: 'utf-8' });`,
       errors: [{ messageId: 'missingWindowsHide' }],
     },
-    // execSync missing windowsHide
+    // execSync with no options at all
     {
       code: `import { execSync } from 'child_process';
-             execSync('echo hello', { encoding: 'utf-8' });`,
+             execSync('echo hello');`,
+      errors: [{ messageId: 'missingWindowsHide' }],
+    },
+    // spawn with variable command but no options
+    {
+      code: `import { spawn } from 'child_process';
+             const cmd = 'echo';
+             spawn(cmd, ['hello']);`,
       errors: [{ messageId: 'missingWindowsHide' }],
     },
     // Member expression: child_process.spawn
diff --git a/tools/eslint-rules/rules/require-windows-hide.ts b/tools/eslint-rules/rules/require-windows-hide.ts
@@ -6,7 +6,6 @@ export const RULE_NAME = 'require-windows-hide';
 const SPAWN_FUNCTIONS = new Set([
   'spawn',
   'spawnSync',
-  'fork',
   'exec',
   'execSync',
   'execFile',
@@ -19,7 +18,7 @@ export const rule = ESLintUtils.RuleCreator(() => __filename)({
     type: 'problem',
     docs: {
       description:
-        'Ensures that child_process spawn/exec/fork calls include windowsHide: true to prevent console windows from flashing on Windows.',
+        'Ensures that child_process spawn/exec calls include windowsHide: true to prevent console windows from flashing on Windows.',
     },
     schema: [],
     messages: {
@@ -53,18 +52,19 @@ export const rule = ESLintUtils.RuleCreator(() => __filename)({
         );
 
         if (!optionsArg) {
-          // If there's a spread or variable reference we can't statically analyze, skip
-          const hasNonLiteralObject = node.arguments.some(
-            (arg) =>
-              arg.type === 'Identifier' ||
-              arg.type === 'SpreadElement' ||
-              (arg.type === 'ObjectExpression' &&
-                arg.properties.some((p) => p.type === 'SpreadElement'))
-          );
-          // Only report if all args are literals and none is an options object
-          if (!hasNonLiteralObject) {
+          // Check if the last argument could be options passed as a variable
+          const lastArg = node.arguments[node.arguments.length - 1];
+          const hasVariableOptions =
+            lastArg &&
+            (lastArg.type === 'Identifier' || lastArg.type === 'SpreadElement');
+          if (hasVariableOptions) {
             return;
           }
+          // No options object provided at all - report error
+          context.report({
+            messageId: 'missingWindowsHide',
+            node: node,
+          });
           return;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,6 @@ function exportAsync(`
`47`	`47`	`{`
`48`	`48`	`cwd: pathResolve(workspaceRoot, projectRoot),`
`49`	`49`	`env: process.env,`
`50`		`- windowsHide: true,`
`51`	`50`	`}`
`52`	`51`	`);`
`53`	`52`
Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,6 @@ export function prebuildAsync(`
`54`	`54`	`{`
`55`	`55`	`cwd: join(workspaceRoot, projectRoot),`
`56`	`56`	`env: process.env,`
`57`		`- windowsHide: true,`
`58`	`57`	`}`
`59`	`58`	`);`
`60`	`59`
Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,6 @@ function runCliUpdate(`
`46`	`46`	`{`
`47`	`47`	`cwd: pathResolve(workspaceRoot, projectRoot),`
`48`	`48`	`env: process.env,`
`49`		`- windowsHide: true,`
`50`	`49`	`}`
`51`	`50`	`);`
`52`	`51`
Original file line number	Diff line number	Diff line change
`@@ -190,7 +190,6 @@ export async function* nodeExecutor(`
`190`	`190`	`NX_FILE_TO_RUN: fileToRunCorrectPath(fileToRun),`
`191`	`191`	`NX_MAPPINGS: JSON.stringify(mappings),`
`192`	`192`	`},`
`193`		`- windowsHide: true,`
`194`	`193`	`}`
`195`	`194`	`);`
`196`	`195`
`@@ -307,7 +306,6 @@ export async function* nodeExecutor(`
`307`	`306`	`{`
`308`	`307`	`cwd: context.root,`
`309`	`308`	`stdio: 'inherit',`
`310`		`- windowsHide: true,`
`311`	`309`	`}`
`312`	`310`	`);`
`313`	`311`	`childProcess.once('exit', (code) => {`
Original file line number	Diff line number	Diff line change
`@@ -97,7 +97,6 @@ function startVerdaccio(`
`97`	`97`	`: {}),`
`98`	`98`	`},`
`99`	`99`	`stdio: 'inherit',`
`100`		`- windowsHide: true,`
`101`	`100`	`}`
`102`	`101`	`);`
`103`	`102`