Skip to content

Conversation

@mabd-dev
Copy link
Contributor

Based on #123

Apparently TopAppBar have slight padding on the right. Alignment.Center is enough to center the text, no need for fillMaxWidth()

@nsh07
Copy link
Owner

nsh07 commented Nov 10, 2025

Why do you keep spamming PRs without creating issues? This is basic contribution etiquette.

And your change doesn't even fix anything, it actually breaks the existing animation. Did you even run the app after this change? Do it and see the animation and comment here if you still think this PR can be merged.

@mabd-dev
Copy link
Contributor Author

Here

Before After
Screenshot_20251110_084426_Tomato Screenshot_20251110_084401_Tomato

@mabd-dev
Copy link
Contributor Author

Take it easy my friend, all 3 PR's was already created before you told me to open issue first, so I did not know.

This PR is a fix for an opened issues, if you like my solution merge it, if not decline it

I am just trying to help and fix some of those small bugs

@nsh07
Copy link
Owner

nsh07 commented Nov 10, 2025

Here

Not really, the animation is broken

Before

Screen_recording_20251110_140859.mp4

After

Screen_recording_20251110_141002.mp4

@nsh07
Copy link
Owner

nsh07 commented Nov 10, 2025

Take it easy my friend, all 3 PR's was already created before you told me to open issue first, so I did not know.

I'm really sorry if I sounded rude. I received the mails for your PRs with quite a bit of delay, so I assumed you had read my earlier comments.

Anyway, you should discuss whatever implementation you are going to put in your PR with the maintainer at the very least, especially for code that affects the design like this one. Reviewing surprise PRs can take a bit of time off my regular schedule.

And even if I ignore all of that, you didn't even perform the due diligence of at least running the app to test your changes before making a PR. And you posted screenshots to show that the animation isn't broken, which is a bit weird lol

I assume it was a mistake/misunderstanding from your side, and so I don't really mind these PRs at all, it's fine and I would suggest you to keep contributing to this project! It is difficult to determine tone from text, so I might have sounded rude in my previous comment but I didn't really intend to. I'm sorry for that again.

@mabd-dev
Copy link
Contributor Author

No worries

The screenshots was to show that the centering was fixed, you said the change did not fix anything :)

Anyways, I will the animation and update the PR. Sorry for all this

@nsh07
Copy link
Owner

nsh07 commented Nov 11, 2025

I was in the middle of a class when I responded initially and I didn't pay attention to what I wrote, so I accidentally wrote that "doesn't fix anything" bit 😅

I'm sorry if I sounded rude lol

@mabd-dev
Copy link
Contributor Author

As expected, in TopAppBar internals their seems to be padding on the left (or navigation icon default size) which is causing this issue. Their is no parameter on TopAppBar composable to fix this.

Option 1: is to dig deeper into TopAppBar and find out the size, then do padding right with same amount
Option 2:: add dummy navigationIcon and actions icons, but with hidden alpha and no click handling. It's a hack but would work

What do you think ?

@mabd-dev mabd-dev force-pushed the fix/alignFocusText branch 4 times, most recently from d0bb70c to 3b22223 Compare November 21, 2025 04:49
@mabd-dev mabd-dev changed the base branch from main to dev November 21, 2025 04:51
@mabd-dev
Copy link
Contributor Author

@nsh07 can you take a look at this please

@nsh07 nsh07 linked an issue Nov 21, 2025 that may be closed by this pull request
@nsh07
Copy link
Owner

nsh07 commented Nov 21, 2025

This works, thank you for the fix!

Also, I would like to apologize once again for the way I talked to you before. I hope you didn't mind that :(

@nsh07 nsh07 merged commit 2184a71 into nsh07:dev Nov 21, 2025
1 check passed
@mabd-dev
Copy link
Contributor Author

No worries my friend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] <'Focus' Text is Misplaced/Misaligned>

2 participants