Skip to content

Commit 5764bef

Browse files
committed
Modify blurred image transparency, enable shared element transition on tablets
1 parent 521db5c commit 5764bef

File tree

3 files changed

+30
-9
lines changed

3 files changed

+30
-9
lines changed

app/src/main/java/org/nsh07/wikireader/ui/AppScreen.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -516,9 +516,9 @@ fun AppScreen(
516516
} else {
517517
FullScreenImage(
518518
photo = WikiPhoto(
519-
source = feedState.image?.image?.source ?: "",
520-
width = feedState.image?.image?.width ?: 1,
521-
height = feedState.image?.image?.height ?: 1
519+
source = feedState.image?.thumbnail?.source ?: "",
520+
width = feedState.image?.thumbnail?.width ?: 1,
521+
height = feedState.image?.thumbnail?.height ?: 1
522522
),
523523
photoDesc = feedState.image?.description?.text?.parseAsHtml()
524524
.toString(),

app/src/main/java/org/nsh07/wikireader/ui/homeScreen/ArticleFeed.kt

Lines changed: 25 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -239,14 +239,28 @@ fun SharedTransitionScope.ArticleFeed(
239239
imageLoader = imageLoader,
240240
background = imageBackground,
241241
loadingIndicator = false,
242-
modifier = Modifier.weight(1f)
242+
modifier = Modifier
243+
.sharedBounds(
244+
sharedContentState = rememberSharedContentState(
245+
feedState.tfa.originalImage?.source ?: "imgsrc"
246+
),
247+
animatedVisibilityScope = animatedVisibilityScope
248+
)
249+
.weight(1f)
243250
)
244251
Column(modifier = Modifier.weight(1f)) {
245252
Text(
246253
feedState.tfa.titles?.normalized ?: "",
247254
style = typography.headlineMedium,
248255
fontFamily = FontFamily.Serif,
249256
modifier = Modifier
257+
.sharedBounds(
258+
sharedContentState = rememberSharedContentState(
259+
feedState.tfa.titles?.normalized ?: "title"
260+
),
261+
animatedVisibilityScope = animatedVisibilityScope,
262+
zIndexInOverlay = 1f
263+
)
250264
.padding(horizontal = 16.dp)
251265
.padding(top = 16.dp)
252266
)
@@ -255,6 +269,13 @@ fun SharedTransitionScope.ArticleFeed(
255269
style = typography.bodyMedium,
256270
color = colorScheme.onSurfaceVariant,
257271
modifier = Modifier
272+
.sharedBounds(
273+
sharedContentState = rememberSharedContentState(
274+
feedState.tfa.description ?: "desc"
275+
),
276+
animatedVisibilityScope = animatedVisibilityScope,
277+
zIndexInOverlay = 1f
278+
)
258279
.padding(horizontal = 16.dp, vertical = 4.dp)
259280
)
260281
Text(
@@ -470,10 +491,10 @@ fun SharedTransitionScope.ArticleFeed(
470491
) {
471492
if (!expanded) {
472493
FeedImage(
473-
source = feedState.image.image?.source,
494+
source = feedState.image.thumbnail?.source,
474495
description = feedState.image.description?.text,
475-
width = feedState.image.image?.width ?: 1,
476-
height = feedState.image.image?.height ?: 1,
496+
width = feedState.image.thumbnail?.width ?: 1,
497+
height = feedState.image.thumbnail?.height ?: 1,
477498
imageLoader = imageLoader,
478499
background = imageBackground,
479500
loadingIndicator = false,

app/src/main/java/org/nsh07/wikireader/ui/image/FullScreenImage.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ fun FullScreenImage(
181181
modifier = Modifier
182182
.fillMaxSize()
183183
.blur(32.dp)
184-
.alpha(0.5f)
184+
.alpha(0.3f)
185185
)
186186
}
187187
Box(contentAlignment = Alignment.Center, modifier = Modifier.fillMaxSize()) {
@@ -352,7 +352,7 @@ fun FullScreenImage(
352352
modifier = Modifier
353353
.fillMaxSize()
354354
.blur(32.dp)
355-
.alpha(0.5f)
355+
.alpha(0.3f)
356356
)
357357
}
358358
Box(contentAlignment = Alignment.Center, modifier = Modifier.fillMaxSize()) {

0 commit comments

Comments
 (0)