Skip to content

Commit 1eba5b0

Browse files
bradfitzbradfitz
committed
util/eventbus: log goroutine stacks when hung in CI
Updates tailscale#17680 Change-Id: Ie48dc2d64b7583d68578a28af52f6926f903ca4f Signed-off-by: Brad Fitzpatrick <[email protected]>
1 parent 42ce5c8 commit 1eba5b0

File tree

9 files changed

+15
-8
lines changed

9 files changed

+15
-8
lines changed

‎cmd/derper/depaware.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ tailscale.com/cmd/derper dependencies: (generated by github.com/tailscale/depawa
139139
tailscale.com/types/structs from tailscale.com/ipn+
140140
tailscale.com/types/tkatype from tailscale.com/client/local+
141141
tailscale.com/types/views from tailscale.com/ipn+
142-
tailscale.com/util/cibuild from tailscale.com/health
142+
tailscale.com/util/cibuild from tailscale.com/health+
143143
tailscale.com/util/clientmetric from tailscale.com/net/netmon
144144
tailscale.com/util/cloudenv from tailscale.com/hostinfo+
145145
tailscale.com/util/ctxkey from tailscale.com/tsweb+

‎cmd/k8s-operator/depaware.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -848,7 +848,7 @@ tailscale.com/cmd/k8s-operator dependencies: (generated by github.com/tailscale/
848848
tailscale.com/types/views from tailscale.com/appc+
849849
tailscale.com/util/backoff from tailscale.com/cmd/k8s-operator+
850850
tailscale.com/util/checkchange from tailscale.com/ipn/ipnlocal+
851-
tailscale.com/util/cibuild from tailscale.com/health
851+
tailscale.com/util/cibuild from tailscale.com/health+
852852
tailscale.com/util/clientmetric from tailscale.com/cmd/k8s-operator+
853853
tailscale.com/util/cloudenv from tailscale.com/hostinfo+
854854
LW tailscale.com/util/cmpver from tailscale.com/net/dns+

‎cmd/tailscale/depaware.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ tailscale.com/cmd/tailscale dependencies: (generated by github.com/tailscale/dep
171171
tailscale.com/types/structs from tailscale.com/ipn+
172172
tailscale.com/types/tkatype from tailscale.com/types/key+
173173
tailscale.com/types/views from tailscale.com/tailcfg+
174-
tailscale.com/util/cibuild from tailscale.com/health
174+
tailscale.com/util/cibuild from tailscale.com/health+
175175
tailscale.com/util/clientmetric from tailscale.com/net/netcheck+
176176
tailscale.com/util/cloudenv from tailscale.com/net/dnscache+
177177
tailscale.com/util/cmpver from tailscale.com/net/tshttpproxy+

‎cmd/tailscaled/depaware-min.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ tailscale.com/cmd/tailscaled dependencies: (generated by github.com/tailscale/de
144144
tailscale.com/types/views from tailscale.com/appc+
145145
tailscale.com/util/backoff from tailscale.com/control/controlclient+
146146
tailscale.com/util/checkchange from tailscale.com/ipn/ipnlocal+
147-
tailscale.com/util/cibuild from tailscale.com/health
147+
tailscale.com/util/cibuild from tailscale.com/health+
148148
tailscale.com/util/clientmetric from tailscale.com/appc+
149149
tailscale.com/util/cloudenv from tailscale.com/hostinfo+
150150
tailscale.com/util/ctxkey from tailscale.com/client/tailscale/apitype+

‎cmd/tailscaled/depaware-minbox.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ tailscale.com/cmd/tailscaled dependencies: (generated by github.com/tailscale/de
171171
tailscale.com/types/views from tailscale.com/appc+
172172
tailscale.com/util/backoff from tailscale.com/control/controlclient+
173173
tailscale.com/util/checkchange from tailscale.com/ipn/ipnlocal+
174-
tailscale.com/util/cibuild from tailscale.com/health
174+
tailscale.com/util/cibuild from tailscale.com/health+
175175
tailscale.com/util/clientmetric from tailscale.com/appc+
176176
tailscale.com/util/cloudenv from tailscale.com/hostinfo+
177177
tailscale.com/util/cmpver from tailscale.com/clientupdate

‎cmd/tailscaled/depaware.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -416,7 +416,7 @@ tailscale.com/cmd/tailscaled dependencies: (generated by github.com/tailscale/de
416416
tailscale.com/types/views from tailscale.com/ipn/ipnlocal+
417417
tailscale.com/util/backoff from tailscale.com/cmd/tailscaled+
418418
tailscale.com/util/checkchange from tailscale.com/ipn/ipnlocal+
419-
tailscale.com/util/cibuild from tailscale.com/health
419+
tailscale.com/util/cibuild from tailscale.com/health+
420420
tailscale.com/util/clientmetric from tailscale.com/control/controlclient+
421421
tailscale.com/util/cloudenv from tailscale.com/net/dns/resolver+
422422
tailscale.com/util/cmpver from tailscale.com/net/dns+

‎cmd/tsidp/depaware.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,7 @@ tailscale.com/cmd/tsidp dependencies: (generated by github.com/tailscale/depawar
253253
tailscale.com/types/views from tailscale.com/appc+
254254
tailscale.com/util/backoff from tailscale.com/control/controlclient+
255255
tailscale.com/util/checkchange from tailscale.com/ipn/ipnlocal+
256-
tailscale.com/util/cibuild from tailscale.com/health
256+
tailscale.com/util/cibuild from tailscale.com/health+
257257
tailscale.com/util/clientmetric from tailscale.com/appc+
258258
tailscale.com/util/cloudenv from tailscale.com/hostinfo+
259259
LW tailscale.com/util/cmpver from tailscale.com/net/dns+

‎tsnet/depaware.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,7 @@ tailscale.com/tsnet dependencies: (generated by github.com/tailscale/depaware)
248248
tailscale.com/types/views from tailscale.com/appc+
249249
tailscale.com/util/backoff from tailscale.com/control/controlclient+
250250
tailscale.com/util/checkchange from tailscale.com/ipn/ipnlocal+
251-
tailscale.com/util/cibuild from tailscale.com/health
251+
tailscale.com/util/cibuild from tailscale.com/health+
252252
tailscale.com/util/clientmetric from tailscale.com/appc+
253253
tailscale.com/util/cloudenv from tailscale.com/hostinfo+
254254
LW tailscale.com/util/cmpver from tailscale.com/net/dns+

‎util/eventbus/subscribe.go‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,12 @@ import (
77
"context"
88
"fmt"
99
"reflect"
10+
"runtime"
1011
"sync"
1112
"time"
1213

1314
"tailscale.com/types/logger"
15+
"tailscale.com/util/cibuild"
1416
)
1517

1618
type DeliveredEvent struct {
@@ -329,6 +331,11 @@ func (s *SubscriberFunc[T]) dispatch(ctx context.Context, vals *queue[DeliveredE
329331
select {
330332
case <-s.slow.C:
331333
s.logf("giving up on subscriber for %T after %v at close", t, time.Since(start))
334+
if cibuild.On() {
335+
all := make([]byte, 2<<20)
336+
n := runtime.Stack(all, true)
337+
s.logf("goroutine stacks:\n%s", all[:n])
338+
}
332339
case <-callDone:
333340
}
334341
return false

0 commit comments

Comments
 (0)