Skip to content

Commit 36397f1

Browse files
authored
wgengine/magicsock: add clientmetrics for TX direction Peer Relay disco messages (tailscale#16831)
Updates tailscale/corp#30527 Signed-off-by: Jordan Whited <[email protected]>
1 parent 03c4b2a commit 36397f1

File tree

1 file changed

+27
-12
lines changed

1 file changed

+27
-12
lines changed

wgengine/magicsock/magicsock.go

Lines changed: 27 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2025,6 +2025,16 @@ func (c *Conn) sendDiscoMessage(dst epAddr, dstKey key.NodePublic, dstDisco key.
20252025
metricSentDiscoPong.Add(1)
20262026
case *disco.CallMeMaybe:
20272027
metricSentDiscoCallMeMaybe.Add(1)
2028+
case *disco.CallMeMaybeVia:
2029+
metricSentDiscoCallMeMaybeVia.Add(1)
2030+
case *disco.BindUDPRelayEndpoint:
2031+
metricSentDiscoBindUDPRelayEndpoint.Add(1)
2032+
case *disco.BindUDPRelayEndpointAnswer:
2033+
metricSentDiscoBindUDPRelayEndpointAnswer.Add(1)
2034+
case *disco.AllocateUDPRelayEndpointRequest:
2035+
metricSentDiscoAllocUDPRelayEndpointRequest.Add(1)
2036+
case *disco.AllocateUDPRelayEndpointResponse:
2037+
metricSentDiscoAllocUDPRelayEndpointResponse.Add(1)
20282038
}
20292039
} else if err == nil {
20302040
// Can't send. (e.g. no IPv6 locally)
@@ -3967,18 +3977,23 @@ var (
39673977
metricRecvDataPacketsPeerRelayIPv6 = clientmetric.NewAggregateCounter("magicsock_recv_data_peer_relay_ipv6")
39683978

39693979
// Disco packets
3970-
metricSendDiscoUDP = clientmetric.NewCounter("magicsock_disco_send_udp")
3971-
metricSendDiscoDERP = clientmetric.NewCounter("magicsock_disco_send_derp")
3972-
metricSentDiscoUDP = clientmetric.NewCounter("magicsock_disco_sent_udp")
3973-
metricSentDiscoDERP = clientmetric.NewCounter("magicsock_disco_sent_derp")
3974-
metricSentDiscoPing = clientmetric.NewCounter("magicsock_disco_sent_ping")
3975-
metricSentDiscoPong = clientmetric.NewCounter("magicsock_disco_sent_pong")
3976-
metricSentDiscoPeerMTUProbes = clientmetric.NewCounter("magicsock_disco_sent_peer_mtu_probes")
3977-
metricSentDiscoPeerMTUProbeBytes = clientmetric.NewCounter("magicsock_disco_sent_peer_mtu_probe_bytes")
3978-
metricSentDiscoCallMeMaybe = clientmetric.NewCounter("magicsock_disco_sent_callmemaybe")
3979-
metricRecvDiscoBadPeer = clientmetric.NewCounter("magicsock_disco_recv_bad_peer")
3980-
metricRecvDiscoBadKey = clientmetric.NewCounter("magicsock_disco_recv_bad_key")
3981-
metricRecvDiscoBadParse = clientmetric.NewCounter("magicsock_disco_recv_bad_parse")
3980+
metricSendDiscoUDP = clientmetric.NewCounter("magicsock_disco_send_udp")
3981+
metricSendDiscoDERP = clientmetric.NewCounter("magicsock_disco_send_derp")
3982+
metricSentDiscoUDP = clientmetric.NewCounter("magicsock_disco_sent_udp")
3983+
metricSentDiscoDERP = clientmetric.NewCounter("magicsock_disco_sent_derp")
3984+
metricSentDiscoPing = clientmetric.NewCounter("magicsock_disco_sent_ping")
3985+
metricSentDiscoPong = clientmetric.NewCounter("magicsock_disco_sent_pong")
3986+
metricSentDiscoPeerMTUProbes = clientmetric.NewCounter("magicsock_disco_sent_peer_mtu_probes")
3987+
metricSentDiscoPeerMTUProbeBytes = clientmetric.NewCounter("magicsock_disco_sent_peer_mtu_probe_bytes")
3988+
metricSentDiscoCallMeMaybe = clientmetric.NewCounter("magicsock_disco_sent_callmemaybe")
3989+
metricSentDiscoCallMeMaybeVia = clientmetric.NewCounter("magicsock_disco_sent_callmemaybevia")
3990+
metricSentDiscoBindUDPRelayEndpoint = clientmetric.NewCounter("magicsock_disco_sent_bind_udp_relay_endpoint")
3991+
metricSentDiscoBindUDPRelayEndpointAnswer = clientmetric.NewCounter("magicsock_disco_sent_bind_udp_relay_endpoint_answer")
3992+
metricSentDiscoAllocUDPRelayEndpointRequest = clientmetric.NewCounter("magicsock_disco_sent_alloc_udp_relay_endpoint_request")
3993+
metricSentDiscoAllocUDPRelayEndpointResponse = clientmetric.NewCounter("magicsock_disco_sent_alloc_udp_relay_endpoint_response")
3994+
metricRecvDiscoBadPeer = clientmetric.NewCounter("magicsock_disco_recv_bad_peer")
3995+
metricRecvDiscoBadKey = clientmetric.NewCounter("magicsock_disco_recv_bad_key")
3996+
metricRecvDiscoBadParse = clientmetric.NewCounter("magicsock_disco_recv_bad_parse")
39823997

39833998
metricRecvDiscoUDP = clientmetric.NewCounter("magicsock_disco_recv_udp")
39843999
metricRecvDiscoDERP = clientmetric.NewCounter("magicsock_disco_recv_derp")

0 commit comments

Comments
 (0)