sunos: improve installer, tun driver configurable

Author: nshalman

cmd/tailscaled/smf/install

@@ -54,6 +54,7 @@ ln -s tailscaled "/${PREFIX?}/local/sbin/tailscale"
 <tailscale.xml sed "s/@@PREFIX@@/${PREFIX?}/" > import.xml
 svccfg import import.xml
 svccfg -s vpn/tailscale setprop application/binary="/${PREFIX?}/local/sbin/tailscaled"
+svccfg -s vpn/tailscale setprop application/tun_driver="tun"
 svcadm enable -st vpn/tailscale
 rm tailscale.xml import.xml
 
@@ -62,3 +63,7 @@ rm -rf "${TMPDIR}"
 
 sleep 2
 tailscale status
+
+echo "To switch to non-tun userspace networking you can run:"
+echo 'svccfg -s vpn/tailscale setprop application/tun_driver="userspace-networking"'
+echo "and then restart tailscale"

cmd/tailscaled/smf/tailscale.xml

@@ -17,6 +17,7 @@
     <exec_method name='stop' type='method' exec='/@@PREFIX@@/local/lib/svc/method/vpn-tailscale %m %{restarter/contract}' timeout_seconds='5'/>
     <property_group name='application' type='application'>
       <propval name='binary' type='astring' value='/@@PREFIX@@/local/sbin/tailscaled'/>
+      <propval name='tun_driver' type='astring' value='tun'/>
     </property_group>
     <stability value='Evolving'/>
     <template>

cmd/tailscaled/smf/vpn-tailscale

@@ -3,14 +3,15 @@
 
 . /lib/svc/share/smf_include.sh
 
-TAILSCALED=$(svcprop -p application/binary $SMF_FMRI)
+TAILSCALED=$(svcprop -c -p application/binary "$SMF_FMRI")
+TUN_DRIVER=$(svcprop -c -p application/tun_driver "$SMF_FMRI")
 case "$1" in
 start)
 	smf_clear_env
-	"${TAILSCALED?}" &
+	"${TAILSCALED?}" -tun "${TUN_DRIVER?}" &
 	;;
 stop)
-	smf_kill_contract $2 TERM 60
+	smf_kill_contract "$2" TERM 60
 	"${TAILSCALED?}" --cleanup
 	;;
 *)
@@ -19,4 +20,4 @@ stop)
 	;;
 esac
 
-exit $SMF_EXIT_OK
+exit "$SMF_EXIT_OK"