Skip to content

Commit 4659af5

Browse files
committed
Update mypy and remove now-unnecessary type-ignores
1 parent 34ebde8 commit 4659af5

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ Changelog = "https://github.com/NSIDC/iceflow/releases"
4747
dev = [
4848
"bump-my-version",
4949
"invoke",
50-
"mypy >=1.11.1",
50+
"mypy >=1.15.0",
5151
"pandas-stubs >=2.2",
5252
"pre-commit",
5353
"pytest",

src/nsidc/iceflow/api.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -108,16 +108,16 @@ def make_iceflow_parquet(
108108
short_name, version = subdir.name.split("_")
109109
iceflow_df["dataset"] = [f"{short_name}v{version}"] * len(iceflow_df.latitude)
110110
common_columns = ["latitude", "longitude", "elevation", "dataset"]
111-
common_dask_df = dd.from_pandas(iceflow_df[common_columns]) # type: ignore[attr-defined]
111+
common_dask_df = dd.from_pandas(iceflow_df[common_columns])
112112
if parquet_subdir.exists():
113-
dd.to_parquet( # type: ignore[attr-defined]
113+
dd.to_parquet(
114114
df=common_dask_df,
115115
path=parquet_subdir,
116116
append=True,
117117
ignore_divisions=True,
118118
)
119119
else:
120-
dd.to_parquet( # type: ignore[attr-defined]
120+
dd.to_parquet(
121121
df=common_dask_df,
122122
path=parquet_subdir,
123123
)

tests/integration/test_e2e.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ def test_create_iceflow_parquet(tmp_path):
213213
target_itrf=target_itrf,
214214
)
215215

216-
df = dd.read_parquet(parquet_path) # type: ignore[attr-defined]
216+
df = dd.read_parquet(parquet_path)
217217

218218
# Assert that the parquet data has the expected columns
219219
expected_columns = sorted(["latitude", "longitude", "elevation", "dataset"])

0 commit comments

Comments
 (0)