[Semantic] Lvalues are not arrays and updated tests

Fixes #41

Author: JohnnyPol

.github/workflows/edge_and_extra_hard.yml

@@ -0,0 +1,62 @@
+name: Dana Compiler CI
+
+on:
+  push:
+  pull_request:
+
+jobs:
+  edge-and-extra-hard-cases:
+    runs-on: ubuntu-latest
+    env:
+      LLVM_VERSION: "14"
+      LLVM_CONFIG: "llvm-config-14"
+      CC: "clang-14"
+      CXX: "clang++-14"
+
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v4
+
+      - name: Install LLVM/Clang ${{ env.LLVM_VERSION }}
+        shell: bash
+        run: |
+          sudo apt-get update
+          sudo apt-get install -y \
+            llvm-${LLVM_VERSION} llvm-${LLVM_VERSION}-dev \
+            clang-${LLVM_VERSION} lld-${LLVM_VERSION} \
+            make build-essential
+
+          # Sanity checks
+          ${LLVM_CONFIG} --version
+          ${LLVM_CONFIG} --cxxflags
+          ${CC} --version
+          ${CXX} --version
+
+      - name: Provide plain llvm-config on PATH
+        shell: bash
+        run: |
+          # Your Makefile calls `llvm-config` (without suffix).
+          # Create a symlink to llvm-config-14 so those backticks work.
+          sudo ln -sf /usr/bin/llvm-config-14 /usr/local/bin/llvm-config
+          echo "/usr/local/bin" >> $GITHUB_PATH
+          which llvm-config
+          llvm-config --version
+          llvm-config --cxxflags
+
+      - name: Set up Python
+        uses: actions/setup-python@v5
+        with:
+          python-version: "3.10"
+
+      # test_compiler.py will run `make` in ./compiler, which now finds `llvm-config`
+      - name: Run Edge and Extra-Hard Tests
+        shell: bash
+        env:
+          LLVM_VERSION: ${{ env.LLVM_VERSION }}
+          LLVM_CONFIG: ${{ env.LLVM_CONFIG }}
+          CC: ${{ env.CC }}
+          CXX: ${{ env.CXX }}
+        run: |
+          echo "Executing Python Compiler test script..."
+          cd testing
+          python test_edge_and_extra.py

compiler/ast.hpp

@@ -1702,7 +1702,7 @@ class AssignStmt : public Stmt
         // Now we are sure that it's a variable
         lval->sem_analyze();
 
-        if (lval->isArrayType() && !lval->consideredStringVariable())
+        if (lval->isArrayType())
         {
             std::ostringstream oss;
             oss << "Cannot assign to an array: " << lval->getName();

llvm/ast.hpp

@@ -1691,7 +1691,7 @@ class AssignStmt : public Stmt
         // Now we are sure that it's a variable
         lval->sem_analyze();
 
-        if (lval->isArrayType() && !lval->consideredStringVariable())
+        if (lval->isArrayType())
         {
             std::ostringstream oss;
             oss << "Cannot assign to an array: " << lval->getName();

semantic/ast.hpp

@@ -967,7 +967,7 @@ class AssignStmt : public Stmt
         // Now we are sure that it's a variable
         lval->sem_analyze();
 
-        if (lval->isArrayType() && !lval->consideredStringVariable())
+        if (lval->isArrayType())
         {
             std::ostringstream oss;
             oss << "Cannot assign to an array: " << lval->getName();

testing/invalid_semantic/string_array_lvalue.dana

@@ -0,0 +1,4 @@
+def main
+    var s is byte [16]
+    s := "hello" # should've written: strcpy: s, "hello\n"
+    writeString: s