Fixed semantics for issue #44, code gen needs to be changed!

Author: nspyrop03

compiler/ast.hpp

@@ -857,7 +857,15 @@ class LValue : public Expr
     {
         if (stringLiteral)
         {
-            this->type = TYPE_BYTE_ARRAY;
+            if(!indices.empty()) {
+                if(indices.size() > 1) {
+                    semantic_error(line, column, "String literal can only be indexed once.");
+                }
+                indices[0]->check_type(TYPE_INT);
+                this->type = TYPE_BYTE;
+            } else {
+                this->type = TYPE_BYTE_ARRAY;
+            }
             return;
         }
 
@@ -935,11 +943,21 @@ class LValue : public Expr
 
             gvar->setAlignment(llvm::Align(1));
 
-            // Pointer to first character
             llvm::Constant *zero = AST::c32(0);
-            std::vector<llvm::Constant *> idxList = {zero, zero};
+
+            llvm::Value* charIdx = zero;
+            
+            /* TODO: Fix this for issue #44
+            if(!indices.empty()) {
+                llvm::Value *v = indices[0]->igen();
+                if (!v->getType()->isIntegerTy(32))
+                    v = AST::Builder.CreateZExtOrTrunc(v, AST::i32, "idx");
+                charIdx = v;
+            }
+            */
+
             llvm::Constant *strPtr = llvm::ConstantExpr::getGetElementPtr(
-                strConst->getType(), gvar, idxList);
+                strConst->getType(), gvar, {zero, charIdx});
 
             return strPtr;
         }

testing/issues/weird_string.dana

@@ -0,0 +1,9 @@
+def main
+    var c is byte
+    var i is int
+
+    i := 3
+    c := "gazonk"[i]
+
+    writeChar: c
+    writeChar: '\n'