fix: use accountId parameter for user lookups in Jira Cloud OAuth mode (sooperset#581)

- Fix is_cloud property to correctly identify Multi-Cloud OAuth as Cloud instance
- OAuth with cloud_id now always returns True for is_cloud check
- This ensures user lookups use accountId parameter instead of username
- Also fixes Confluence v2 adapter issues in Multi-Cloud OAuth mode
- Add test coverage for OAuth cloud detection

Reported-by: Muhammad Ali
Reported-by: Ian
Github-Issue: sooperset#560
Github-Issue: sooperset#580

Author: sooperset

src/mcp_atlassian/jira/config.py

@@ -45,7 +45,17 @@ def is_cloud(self) -> bool:
             True if this is a cloud instance (atlassian.net), False otherwise.
             Localhost URLs are always considered non-cloud (Server/Data Center).
         """
-        return is_atlassian_cloud_url(self.url)
+        # Multi-Cloud OAuth mode: URL might be None, but we use api.atlassian.com
+        if (
+            self.auth_type == "oauth"
+            and self.oauth_config
+            and self.oauth_config.cloud_id
+        ):
+            # OAuth with cloud_id uses api.atlassian.com which is always Cloud
+            return True
+
+        # For other auth types, check the URL
+        return is_atlassian_cloud_url(self.url) if self.url else False
 
     @property
     def verify_ssl(self) -> bool:

tests/unit/jira/test_config.py

@@ -179,3 +179,27 @@ def test_from_env_proxy_settings():
         assert config.https_proxy == "https://jira-proxy.example.com:8443"
         assert config.socks_proxy == "socks5://user:[email protected]:1080"
         assert config.no_proxy == "localhost,127.0.0.1,.internal.example.com"
+
+
+def test_is_cloud_oauth_with_cloud_id():
+    """Test that is_cloud returns True for OAuth with cloud_id regardless of URL."""
+    from mcp_atlassian.utils.oauth import BYOAccessTokenOAuthConfig
+
+    # OAuth with cloud_id and no URL - should be Cloud
+    oauth_config = BYOAccessTokenOAuthConfig(
+        cloud_id="test-cloud-id", access_token="test-token"
+    )
+    config = JiraConfig(
+        url=None,  # URL can be None in Multi-Cloud OAuth mode
+        auth_type="oauth",
+        oauth_config=oauth_config,
+    )
+    assert config.is_cloud is True
+
+    # OAuth with cloud_id and server URL - should still be Cloud
+    config = JiraConfig(
+        url="https://jira.example.com",  # Server-like URL
+        auth_type="oauth",
+        oauth_config=oauth_config,
+    )
+    assert config.is_cloud is True