[GTK] Layout test fast/scrolling/rtl-scrollbars-alternate-iframe-body-dir-attr-does-not-update-scrollbar-placement.html is flaky

obyknovenius · zdobersek · commit 142ba6531a02 · 2022-12-08T00:11:08.000-08:00
https://bugs.webkit.org/show_bug.cgi?id=186665 Reviewed by Žan Doberšek. The reason for the flakiness was the race condition when the screenshot was made before the iframe layout was done. The solution is to make the test asynchronous and explicitly notify TestRunner about finishing the test. * LayoutTests/fast/scrolling/rtl-scrollbars-alternate-iframe-body-dir-attr-does-not-update-scrollbar-placement.html: * LayoutTests/platform/glib/TestExpectations: Canonical link: https://commits.webkit.org/257543@main
diff --git a/LayoutTests/fast/scrolling/rtl-scrollbars-alternate-iframe-body-dir-attr-does-not-update-scrollbar-placement.html b/LayoutTests/fast/scrolling/rtl-scrollbars-alternate-iframe-body-dir-attr-does-not-update-scrollbar-placement.html
@@ -1,20 +1,26 @@
 <html>
-    <iframe width="200" height="100" scrolling="yes" src="data:text/html,
+    <iframe id="target" onload="setTimeout(finishTest, 0);" width="200" height="100" scrolling="yes" src="data:text/html,
         <html>
-            <script>
-                function load()
-                {
-                    var body = document.getElementById('body');
-                    body.style.direction='rtl';
-                }
-            </script>
-            <body id='body' onload='setTimeout(load, 0);'>
+            <body>
               Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.
               Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure
               dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non
               proident, sunt in culpa qui officia deserunt mollit anim id est laborum.
             </body>
         </html>">
     </iframe>
-</html>
+    <script>
+        function finishTest() {
+            var iframe = document.getElementById('target');
+            var body = iframe.contentDocument.body;
+            body.style.direction='rtl';
+            testRunner.notifyDone();
+        }
+
+        function startTest() {
+            testRunner.waitUntilDone();
+        }
 
+        window.addEventListener('load', startTest, false);
+    </script>
+</html>
diff --git a/LayoutTests/platform/glib/TestExpectations b/LayoutTests/platform/glib/TestExpectations
@@ -1144,13 +1144,6 @@ webkit.org/b/212202 fast/scrolling/overflow-scrollable-after-back.html [ Skip ]
 # Previous: webkit.org/b/223729 [ Debug ] css3/scroll-snap/scroll-snap-wheel-event.html [ Pass ]
 webkit.org/b/212202 css3/scroll-snap/scroll-snap-wheel-event.html [ Skip ]
 
-
-
-# Warning: this test is expected to fail in the global expectations file, but
-# we expect it to Pass because we support RTL scrollbars. When fixed, it should
-# not be removed, but moved to the expected passes section of this file.
-webkit.org/b/186665 fast/scrolling/rtl-scrollbars-alternate-iframe-body-dir-attr-does-not-update-scrollbar-placement.html [ ImageOnlyFailure ]
-
 webkit.org/b/213921 fast/visual-viewport/scroll-event-fired-during-scroll-alone.html [ Crash ]
 
 #////////////////////////////////////////////////////////////////////////////////////////
