Skip to content

Commit 64dda35

Browse files
committed
[content-visibility] Fix dynamic-change-paint-fully-obscuring-child-001.html
https://bugs.webkit.org/show_bug.cgi?id=247617 Reviewed by Simon Fraser. A child can't obscure a parent element that should skip its contents due to hidden content-visibility, so adjust foregroundIsKnownToBeOpaqueInRect to that. * LayoutTests/TestExpectations: * Source/WebCore/rendering/RenderBox.cpp: (WebCore::RenderBox::foregroundIsKnownToBeOpaqueInRect const): Canonical link: https://commits.webkit.org/257549@main
1 parent b626862 commit 64dda35

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

LayoutTests/TestExpectations

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4836,7 +4836,6 @@ imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visib
48364836
imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-with-top-layer-004.html [ ImageOnlyFailure ]
48374837
imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-with-top-layer-hide-after-addition.html [ ImageOnlyFailure ]
48384838
imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-video.html [ ImageOnlyFailure ]
4839-
imported/w3c/web-platform-tests/css/css-contain/content-visibility/dynamic-change-paint-fully-obscuring-child-001.html [ ImageOnlyFailure ]
48404839
imported/w3c/web-platform-tests/css/css-contain/counter-scoping-001.html [ ImageOnlyFailure ]
48414840
imported/w3c/web-platform-tests/css/css-contain/counter-scoping-002.html [ ImageOnlyFailure ]
48424841
imported/w3c/web-platform-tests/css/css-contain/quote-scoping-001.html [ ImageOnlyFailure ]

Source/WebCore/rendering/RenderBox.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1728,6 +1728,9 @@ bool RenderBox::foregroundIsKnownToBeOpaqueInRect(const LayoutRect& localRect, u
17281728
if (!maxDepthToTest)
17291729
return false;
17301730

1731+
if (shouldSkipContent())
1732+
return false;
1733+
17311734
for (auto& childBox : childrenOfType<RenderBox>(*this)) {
17321735
if (!isCandidateForOpaquenessTest(childBox))
17331736
continue;

0 commit comments

Comments
 (0)