[Curl] Add missing error domain check to ResourceErrorCurl.

https://bugs.webkit.org/show_bug.cgi?id=248920

Reviewed by Fujii Hironori.

Add missing error domain check to ResourceError::isSSLCertVerificationError.
Also, we delete ResourceError::isSSLConnectError as it is not used.

* Source/WebCore/platform/network/curl/ResourceError.h:
* Source/WebCore/platform/network/curl/ResourceErrorCurl.cpp:
(WebCore::curlErrorDomain):
(WebCore::ResourceError::httpError):
(WebCore::ResourceError::isSSLCertVerificationError const):
(WebCore::ResourceError::isSSLConnectError const): Deleted.

Canonical link: https://commits.webkit.org/257546@main

Author: kshukuwa

Source/WebCore/platform/network/curl/ResourceError.h

@@ -31,8 +31,6 @@
 namespace WebCore {
 
 class ResourceError : public ResourceErrorBase {
-    friend class ResourceErrorBase;
-
 public:
     ResourceError(Type type = Type::Null)
         : ResourceErrorBase(type)
@@ -46,15 +44,14 @@ class ResourceError : public ResourceErrorBase {
 
     WEBCORE_EXPORT static ResourceError httpError(int errorCode, const URL& failingURL, Type = Type::General);
 
-    bool isSSLConnectError() const;
     WEBCORE_EXPORT bool isSSLCertVerificationError() const;
 
     static bool platformCompare(const ResourceError& a, const ResourceError& b);
 
 private:
-    void doPlatformIsolatedCopy(const ResourceError&);
+    friend class ResourceErrorBase;
 
-    static ASCIILiteral curlErrorDomain;
+    void doPlatformIsolatedCopy(const ResourceError&);
 };
 
 } // namespace WebCore

Source/WebCore/platform/network/curl/ResourceErrorCurl.cpp

@@ -32,21 +32,20 @@
 
 namespace WebCore {
 
-ASCIILiteral ResourceError::curlErrorDomain = "CurlErrorDomain"_s;
-
-ResourceError ResourceError::httpError(int errorCode, const URL& failingURL, Type type)
+static const String& curlErrorDomain()
 {
-    return ResourceError(curlErrorDomain, errorCode, failingURL, CurlHandle::errorDescription(static_cast<CURLcode>(errorCode)), type);
+    static NeverDestroyed<const String> errorDomain(MAKE_STATIC_STRING_IMPL("CurlErrorDomain"));
+    return errorDomain;
 }
 
-bool ResourceError::isSSLConnectError() const
+ResourceError ResourceError::httpError(int errorCode, const URL& failingURL, Type type)
 {
-    return errorCode() == CURLE_SSL_CONNECT_ERROR;
+    return ResourceError(curlErrorDomain(), errorCode, failingURL, CurlHandle::errorDescription(static_cast<CURLcode>(errorCode)), type);
 }
 
 bool ResourceError::isSSLCertVerificationError() const
 {
-    return errorCode() == CURLE_PEER_FAILED_VERIFICATION;
+    return domain() == curlErrorDomain() && errorCode() == CURLE_PEER_FAILED_VERIFICATION;
 }
 
 void ResourceError::doPlatformIsolatedCopy(const ResourceError&)