Skip to content

Commit fc8aae2

Browse files
committed
In results.html, links to diffs for tests with periods in the name fail
https://bugs.webkit.org/show_bug.cgi?id=248745 rdar://103041235 Reviewed by Simon Fraser. Match results.html to test_result_writer.py per the existing comment. * LayoutTests/fast/harness/results.html: Canonical link: https://commits.webkit.org/257527@main
1 parent be35373 commit fc8aae2

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

LayoutTests/fast/harness/results.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -309,7 +309,7 @@
309309
prefix += '_' + remains.split('?')[1]
310310
else if (remains.includes('#'))
311311
prefix += '_' + remains.split('#')[1]
312-
} else if (Utils.splitExtension(parts[0])[1].length > 5) {
312+
} else if (Utils.splitExtension(parts[0])[1].length - 1 > 5) {
313313
// Temporary fix, also in Tools/Scripts/webkitpy/layout_tests/constrollers/test_result_writer.py, line 115.
314314
// FIXME: Refactor to avoid confusing reference to both test and process names.
315315
return testName;

0 commit comments

Comments
 (0)