Skip to content

Default value for COMMUTER_S3_ENDPOINT shouldn't be an empty string Β #298

@elvinx

Description

@elvinx

I am trying to use commuter with s3 and if I don't set COMMUTER_S3_ENDPOINT the default is

var s3Endpoint = env.COMMUTER_S3_ENDPOINT || ""

this causes

rror: connect ECONNREFUSED 127.0.0.1:443
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1129:14) {
  message: 'connect ECONNREFUSED 127.0.0.1:443',
  errno: -61,
  code: 'NetworkingError',
  syscall: 'connect',
  address: '127.0.0.1',
  port: 443,
  region: 'us-east-1',
  hostname: '',
  retryable: true,
  time: 2020-06-23T10:28:51.483Z
} Error: connect ECONNREFUSED 127.0.0.1:443
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1129:14)

However it works fine if it is set to null.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions