Merge pull request #2075 from nteract/dependencies

Author: aminya

.eslintrc.json

@@ -1,4 +1,7 @@
 {
-  "extends": "eslint-config-atomic",
+  "extends": [
+    "eslint-config-atomic",
+    "plugin:you-dont-need-lodash-underscore/compatible"
+  ],
   "ignorePatterns": ["dist/", "node_modules/"]
 }

.gitignore

@@ -12,3 +12,4 @@ package-lock.json
 
 # Build directories
 dist
+.parcel-cache/

lib/code-manager.ts

@@ -1,7 +1,7 @@
 import { Point, Range, TextEditor } from "atom";
 import escapeStringRegexp from "escape-string-regexp";
 import stripIndent from "strip-indent";
-import _ from "lodash";
+import compact from "lodash/compact";
 import {
   log,
   isMultilanguageGrammar,
@@ -92,7 +92,7 @@ export function removeCommentsMarkdownCell(
   const lines = text.split("\n");
   const editedLines = [];
 
-  _.forEach(lines, (line) => {
+  lines.forEach((line) => {
     if (line.startsWith(commentStartString)) {
       // Remove comment from start of line
       editedLines.push(line.slice(commentStartString.length));
@@ -109,7 +109,7 @@ export function getSelectedText(editor: TextEditor) {
 export function isComment(editor: TextEditor, position: Point) {
   const scope = editor.scopeDescriptorForBufferPosition(position);
   const scopeString = scope.getScopeChain();
-  return _.includes(scopeString, "comment.line");
+  return scopeString.includes("comment.line");
 }
 export function isBlank(editor: TextEditor, row: number) {
   return editor.getBuffer().isRowBlank(row);
@@ -272,7 +272,7 @@ function isEmbeddedCode(
   const scopes = editor
     .scopeDescriptorForBufferPosition(new Point(row, 0))
     .getScopesArray();
-  return _.includes(scopes, referenceScope);
+  return scopes.includes(referenceScope);
 }
 
 function getCurrentFencedCodeBlock(editor: TextEditor) {
@@ -323,8 +323,8 @@ export function getCellsForBreakPoints(
     start = new Point(match.range.start.row, 0);
     match.stop();
   });
-  return _.compact(
-    _.map(breakpoints, (end) => {
+  return compact(
+    breakpoints.map((end) => {
       const cell = end.isEqual(start) ? null : new Range(start, end);
       start = new Point(end.row + 1, 0);
       return cell;

lib/commands.ts

@@ -1,10 +1,4 @@
-import {
-  log,
-  reactFactory,
-  INSPECTOR_URI,
-  OUTPUT_AREA_URI,
-  openOrShowDock,
-} from "./utils";
+import { log, INSPECTOR_URI, OUTPUT_AREA_URI, openOrShowDock } from "./utils";
 import { getCodeToInspect } from "./code-manager";
 import OutputPane from "./panes/output-area";
 type store = typeof import("./store").default;

lib/components/kernel-monitor.tsx

@@ -2,7 +2,6 @@ import React from "react";
 import ReactTable, { ReactTableDefaults } from "react-table";
 
 import { observer } from "mobx-react";
-import _ from "lodash";
 import tildify from "tildify";
 type store = typeof import("../store").default;
 import Kernel from "../kernel";
@@ -105,7 +104,7 @@ const KernelMonitor = observer(({ store }: { store: store }) => {
     );
   }
 
-  const data = _.map(store.runningKernels, (kernel, key: number) => {
+  const data = store.runningKernels.map((kernel, key: number) => {
     return {
       gateway: kernel.transport.gatewayName || "Local",
       kernelInfo: {

lib/components/result-view/plotly.tsx

@@ -9,7 +9,7 @@
  * @NOTE: This `PlotlyTransform` component could be used exactly same as the original `PlotlyTransform` component of @nteract/transform-plotly,
  *        except that this file adds the ability to download a plot from an electron context.
  */
-import { cloneDeep } from "lodash";
+import cloneDeep from "lodash/cloneDeep";
 import * as React from "react";
 interface Props {
   data: string | Record<string, any>;

lib/components/result-view/result-view.tsx

@@ -122,7 +122,7 @@ class ResultViewComponent extends React.Component<Props> {
       userSelect: "text",
     };
 
-    if (outputs.length === 0 || this.props.showResult === false) {
+    if (outputs.length === 0 || !this.props.showResult) {
       const kernel = this.props.kernel;
       return (
         <Status
@@ -220,8 +220,8 @@ class ResultViewComponent extends React.Component<Props> {
   scrollToBottom() {
     if (
       !this.el ||
-      this.expanded === true ||
-      this.props.store.isPlain === true ||
+      this.expanded ||
+      this.props.store.isPlain ||
       atom.config.get(`Hydrogen.autoScroll`) === false
     ) {
       return;

lib/components/watch-sidebar/index.tsx

@@ -1,9 +1,7 @@
-import { CompositeDisposable } from "atom";
 import React from "react";
 import { observer } from "mobx-react";
 import Watch from "./watch";
 import { WATCHES_URI, EmptyMessage } from "../../utils";
-import type Kernel from "../../kernel";
 type store = typeof import("../../store").default;
 const Watches = observer(({ store: { kernel } }: { store: store }) => {
   if (!kernel) {

lib/existing-kernel-picker.ts

@@ -1,7 +1,6 @@
 import { Panel } from "atom";
-import SelectListView from "atom-select-list";
+import SelectListView, { SelectListProperties } from "atom-select-list";
 import store from "./store";
-import _ from "lodash";
 import tildify from "tildify";
 import {
   kernelSpecProvidesGrammar,
@@ -29,14 +28,14 @@ export default class ExistingKernelPicker {
   constructor() {
     this.selectListView = new SelectListView({
       itemsClassList: ["mark-active"],
-      items: [],
-      filterKeyForItem: (kernel) => getName(kernel),
-      elementForItem: (kernel) => {
+      items: [] as Kernel[],
+      filterKeyForItem: (kernel: Kernel) => getName(kernel),
+      elementForItem: (kernel: Kernel) => {
         const element = document.createElement("li");
         element.textContent = getName(kernel);
         return element;
       },
-      didConfirmSelection: (kernel) => {
+      didConfirmSelection: (kernel: Kernel) => {
         const { filePath, editor, grammar } = store;
         if (!filePath || !editor || !grammar) {
           return this.cancel();
@@ -86,7 +85,7 @@ export default class ExistingKernelPicker {
         items: store.runningKernels.filter((kernel) =>
           kernelSpecProvidesGrammar(kernel.kernelSpec, store.grammar)
         ),
-      });
+      } as SelectListProperties);
       const markers = store.markers;
       if (markers) {
         markers.clear();

lib/import-notebook.ts

@@ -2,7 +2,6 @@ import { TextEditor, Grammar } from "atom";
 import * as path from "path";
 import { promises } from "fs";
 const { readFile } = promises;
-import _ from "lodash";
 import type { HydrogenCellType } from "./hydrogen";
 
 import { remote } from "electron";
@@ -42,7 +41,7 @@ export function ipynbOpener(uri: string) {
  */
 export function importNotebook(event?: CustomEvent) {
   // Use selected filepath if called from tree-view context menu
-  const filenameFromTreeView = _.get(event, "target.dataset.path");
+  const filenameFromTreeView = event.target.dataset?.path;
 
   if (filenameFromTreeView && path.extname(filenameFromTreeView) === ".ipynb") {
     return _loadNotebook(
@@ -265,8 +264,8 @@ function getGrammarForFileExtension(ext: string): Grammar | null | undefined {
   }
   ext = ext.startsWith(".") ? ext.slice(1) : ext;
   const grammars = atom.grammars.getGrammars();
-  return _.find(grammars, (grammar) => {
-    return _.includes(grammar.fileTypes, ext);
+  return grammars.find((grammar) => {
+    return grammar.fileTypes.includes(ext);
   });
 }